rm stencil_coefs SVector, move generate_coordinates out of constructor

Author: fgerick

src/derivative_operators/derivative_operator.jl

@@ -67,6 +67,18 @@ function CenteredDifference{N}(derivative_order::Int,
         )
 end
 
+function generate_coordinates(i::Int, stencil_x, dummy_x, dx::AbstractVector{T}) where T <: Real
+    len = length(stencil_x)
+    stencil_x .= stencil_x.*zero(T)
+    for idx in 1:div(len,2)
+        shifted_idx1 = index(idx, len)
+        shifted_idx2 = index(-idx, len)
+        stencil_x[shifted_idx1] = stencil_x[shifted_idx1-1] + dx[i+idx-1]
+        stencil_x[shifted_idx2] = stencil_x[shifted_idx2+1] - dx[i-idx]
+    end
+    return stencil_x
+end
+
 function CenteredDifference{N}(derivative_order::Int,
                             approximation_order::Int, dx::AbstractVector{T},
                             len::Int, coeff_func=nothing) where {T<:Real,N}
@@ -84,19 +96,7 @@ function CenteredDifference{N}(derivative_order::Int,
     deriv_spots             = (-div(stencil_length,2)+1) : -1
     boundary_deriv_spots    = boundary_x[2:div(stencil_length,2)]
 
-    function generate_coordinates(i, stencil_x, dummy_x, dx)
-        len = length(stencil_x)
-        stencil_x .= stencil_x.*zero(T)
-        for idx in 1:div(len,2)
-            shifted_idx1 = index(idx, len)
-            shifted_idx2 = index(-idx, len)
-            stencil_x[shifted_idx1] = stencil_x[shifted_idx1-1] + dx[i+idx-1]
-            stencil_x[shifted_idx2] = stencil_x[shifted_idx2+1] - dx[i-idx]
-        end
-        return stencil_x
-    end
-
-    stencil_coefs           = convert(SVector{length(interior_x)}, [convert(SVector{stencil_length, T}, calculate_weights(derivative_order, zero(T), generate_coordinates(i, stencil_x, dummy_x, dx))) for i in interior_x])
+    stencil_coefs           = [convert(SVector{stencil_length, T}, calculate_weights(derivative_order, zero(T), generate_coordinates(i, stencil_x, dummy_x, dx))) for i in interior_x]
     _low_boundary_coefs     = SVector{boundary_stencil_length, T}[convert(SVector{boundary_stencil_length, T}, calculate_weights(derivative_order, oneunit(T)*x0, boundary_x)) for x0 in boundary_deriv_spots]
     low_boundary_coefs      = convert(SVector{boundary_point_count},_low_boundary_coefs)
     high_boundary_coefs     = convert(SVector{boundary_point_count},reverse(SVector{boundary_stencil_length, T}[reverse(low_boundary_coefs[i]) for i in 1:boundary_point_count]))