Merge pull request #111 from CoolTomatos/indexedAccess

Pouria Derakhshanfar · web-flow · commit a985b48cc625 · 2019-11-06T18:36:45.000+01:00
ITFFForArrayIndex now works with indexed String access as well.
diff --git a/botsing-reproduction/evosuite-client-botsing-1.1.0.jar b/botsing-reproduction/evosuite-client-botsing-1.1.0.jar
diff --git a/botsing-reproduction/src/main/java/eu/stamp/botsing/CrashProperties.java b/botsing-reproduction/src/main/java/eu/stamp/botsing/CrashProperties.java
@@ -68,7 +68,7 @@ public enum TestGenerationStrategy {
     public enum FitnessFunction {
         WeightedSum,
         SimpleSum,
-        IntegrationArrayIndex,
+        IntegrationIndexedAccess,
         IntegrationSingleObjective;
         FitnessFunction() {
         }
diff --git a/botsing-reproduction/src/main/java/eu/stamp/botsing/StackTrace.java b/botsing-reproduction/src/main/java/eu/stamp/botsing/StackTrace.java
@@ -100,12 +100,12 @@ public void setup(String logPath, int frameLevel) throws IllegalArgumentExceptio
             LOG.info("Target Class is set to: " + targetClass);
 
             // If the target exception is ArrayIndexOutOfBoundsException
-            if (exceptionType.equals(ArrayIndexOutOfBoundsException.class.getName())) {
+            if (exceptionType.equals(ArrayIndexOutOfBoundsException.class.getName()) || exceptionType.equals(StringIndexOutOfBoundsException.class.getName())) {
                 // Set the line number where the array access call is located at.
-                Properties.TARGET_ARRAY_LINE = frames.get(0).getLineNumber();
+                Properties.TARGET_INDEXED_ACCESS_LINE = frames.get(0).getLineNumber();
                 // Set the fitness function for this crash to be the customized one.
                 CrashProperties.fitnessFunctions[CrashProperties.getInstance().getCrashesSize() - 1] =
-                        CrashProperties.FitnessFunction.IntegrationArrayIndex;
+                        CrashProperties.FitnessFunction.IntegrationIndexedAccess;
             }
         } catch (FileNotFoundException e) {
             LOG.debug("Stack trace file not found!", e);
diff --git a/botsing-reproduction/src/main/java/eu/stamp/botsing/fitnessfunction/FitnessFunctionHelper.java b/botsing-reproduction/src/main/java/eu/stamp/botsing/fitnessfunction/FitnessFunctionHelper.java
@@ -28,56 +28,55 @@
 
 public class FitnessFunctionHelper {
 
-    public boolean isConstructor(BytecodeInstruction targetInstruction){
+    public boolean isConstructor(BytecodeInstruction targetInstruction) {
         String methodName = targetInstruction.getMethodName();
         methodName = methodName.substring(0, methodName.indexOf('('));
         String classPath = targetInstruction.getClassName();
         int lastOccurrence = classPath.lastIndexOf(".");
-        if (lastOccurrence == -1){
+        if (lastOccurrence == -1) {
             return false;
         }
-        String className = classPath.substring(lastOccurrence+1);
+        String className = classPath.substring(lastOccurrence + 1);
         return className.equals(methodName);
-
     }
 
-    public TestFitnessFunction getSingleObjective(){
-        return getFF(CrashProperties.fitnessFunctions[0],CrashProperties.getInstance().getStackTrace(0));
+    public TestFitnessFunction getSingleObjective() {
+        return getFF(CrashProperties.fitnessFunctions[0], CrashProperties.getInstance().getStackTrace(0));
     }
-    public TestFitnessFunction[] getMultiObjectives(){
-        if(CrashProperties.fitnessFunctions.length > 1){
+
+    public TestFitnessFunction[] getMultiObjectives() {
+        if (CrashProperties.fitnessFunctions.length > 1) {
             // Here, we have 1 crash and multiple fitness functions
-            TestFitnessFunction[] result =  new TestFitnessFunction[CrashProperties.fitnessFunctions.length];
+            TestFitnessFunction[] result = new TestFitnessFunction[CrashProperties.fitnessFunctions.length];
             StackTrace singleCrash = CrashProperties.getInstance().getStackTrace(0);
-            for (int i = 0; i<CrashProperties.fitnessFunctions.length;i++){
-                result[i] = getFF(CrashProperties.fitnessFunctions[i],singleCrash);
+            for (int i = 0; i < CrashProperties.fitnessFunctions.length; i++) {
+                result[i] = getFF(CrashProperties.fitnessFunctions[i], singleCrash);
             }
             return result;
-        }else if(CrashProperties.getInstance().getCrashesSize() > 1){
+        } else if (CrashProperties.getInstance().getCrashesSize() > 1) {
             // Here, we have multiple crashes and 1 fitness function
             int numberOfCrashes = CrashProperties.getInstance().getCrashesSize();
-            TestFitnessFunction[] result =  new TestFitnessFunction[numberOfCrashes];
-            for (int i = 0; i<numberOfCrashes;i++){
-                result[i]= getFF(CrashProperties.fitnessFunctions[0],CrashProperties.getInstance().getStackTrace(i));
+            TestFitnessFunction[] result = new TestFitnessFunction[numberOfCrashes];
+            for (int i = 0; i < numberOfCrashes; i++) {
+                result[i] = getFF(CrashProperties.fitnessFunctions[0], CrashProperties.getInstance().getStackTrace(i));
             }
             return result;
-        }else{
-            throw new IllegalStateException("Number of crashes and fitness functions are 1. Botsing cannot use a multi-objective algorithm");
+        } else {
+            throw new IllegalStateException("Number of crashes and fitness functions are 1. Botsing cannot use a " +
+                    "multi-objective algorithm");
         }
     }
 
-    private TestFitnessFunction getFF(CrashProperties.FitnessFunction givenFFName, StackTrace crash){
-        switch (givenFFName){
+    private TestFitnessFunction getFF(CrashProperties.FitnessFunction givenFFName, StackTrace crash) {
+        switch (givenFFName) {
             case WeightedSum:
                 return new WeightedSum(crash);
             case IntegrationSingleObjective:
                 return new IntegrationTestingFF(crash);
-            case IntegrationArrayIndex:
-                return new ITFFForArrayIndex(crash);
+            case IntegrationIndexedAccess:
+                return new ITFFForIndexedAccess(crash);
             default:
                 return new WeightedSum(crash);
         }
     }
-
-
 }
diff --git a/botsing-reproduction/src/main/java/eu/stamp/botsing/fitnessfunction/ITFFForIndexedAccess.java b/botsing-reproduction/src/main/java/eu/stamp/botsing/fitnessfunction/ITFFForIndexedAccess.java
@@ -5,12 +5,12 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.Map;
+import java.util.Set;
 
-public class ITFFForArrayIndex extends IntegrationTestingFF {
-    private static final Logger logger = LoggerFactory.getLogger(ITFFForArrayIndex.class);
+public class ITFFForIndexedAccess extends IntegrationTestingFF {
+    private static final Logger logger = LoggerFactory.getLogger(ITFFForIndexedAccess.class);
 
-    public ITFFForArrayIndex(StackTrace crash) {
+    public ITFFForIndexedAccess(StackTrace crash) {
         super(crash);
     }
 
@@ -19,16 +19,17 @@ protected double exceptionCoverage(ExecutionResult executionResult) {
         if (super.exceptionCoverage(executionResult) == 0) {
             return 0;
         }
-        Map<Integer, int[]> arrayAccessInfo = executionResult.getTrace().getArrayAccessInfo();
-        if (arrayAccessInfo.isEmpty()) {
-            return 1;
+        double exceptionCoverage = 1;
+        Set<int[]> indexedAccessInfo = executionResult.getTrace().getIndexedAccessInfo();
+        if (indexedAccessInfo.isEmpty()) {
+            return exceptionCoverage;
         }
-        double exceptionCoverage = 0;
-        for (Map.Entry<Integer, int[]> entry : arrayAccessInfo.entrySet()) {
-            int[] indexAndLength = entry.getValue();
-            exceptionCoverage += distance(indexAndLength[0], indexAndLength[1]);
+
+        for (int[] pair : indexedAccessInfo) {
+            double distance = distance(pair[0], pair[1]);
+            exceptionCoverage = Math.min(distance, exceptionCoverage);
         }
-        return exceptionCoverage / arrayAccessInfo.size();
+        return exceptionCoverage;
     }
 
     /**
diff --git a/botsing-reproduction/src/main/java/eu/stamp/botsing/fitnessfunction/IntegrationTestingFF.java b/botsing-reproduction/src/main/java/eu/stamp/botsing/fitnessfunction/IntegrationTestingFF.java
@@ -66,7 +66,7 @@ protected double exceptionCoverage(ExecutionResult executionResult) {
             do {
                 crashingClass = resultException.getStackTrace()[++frame].getClassName();
             }
-            while (frame < resultException.getStackTrace().length && (crashingClass.startsWith("java") || crashingClass.startsWith("javax")));
+            while (frame < resultException.getStackTrace().length && (crashingClass.startsWith("java.") || crashingClass.startsWith("javax.")));
             if (frame == resultException.getStackTrace().length) {
                 continue;
             }
diff --git a/botsing-reproduction/src/test/java/eu/stamp/botsing/fitnessfunction/ITFFForIndexedAccessTest.java b/botsing-reproduction/src/test/java/eu/stamp/botsing/fitnessfunction/ITFFForIndexedAccessTest.java
@@ -20,9 +20,9 @@
 import static org.mockito.Mockito.mock;
 
 @RunWith(Parameterized.class)
-public class ITFFForArrayIndexTest extends IntegrationTestingFFTest {
+public class ITFFForIndexedAccessTest extends IntegrationTestingFFTest {
 
-    @Parameterized.Parameters(name = "index:{0}, arrayLength:{1}, expectedDistance:{2}")
+    @Parameterized.Parameters(name = "index:{0}, length:{1}, expectedDistance:{2}")
     public static Iterable<Object[]> data() {
         return Arrays.asList(new Object[][]{
                 {-1, 1, 0},
@@ -52,8 +52,10 @@ public void testExceptionCoverage_executionResultWithoutTargetCrash() throws Fil
         doReturn(exceptionLocators).when(executionResult).getPositionsWhereExceptionsWereThrown();
 
         ExecutionTraceImpl executionTrace = new ExecutionTraceImpl();
-        executionTrace.arrayIndexAndLength = new HashMap<>();
-        executionTrace.arrayIndexAndLength.put(0, new int[]{index, arrayLength});
+        executionTrace.indexAndLengthMap = new HashMap<>();
+        executionTrace.indexAndLengthMap.put("eu.stamp.ClassB", new HashMap<>());
+        executionTrace.indexAndLengthMap.get("eu.stamp.ClassB").put("method1", new HashMap<>());
+        executionTrace.indexAndLengthMap.get("eu.stamp.ClassB").get("method1").put(0, new int[]{index, arrayLength});
 
         doReturn(executionTrace).when(executionResult).getTrace();
 
@@ -73,7 +75,7 @@ public void testExceptionCoverage_executionResultWithoutTargetCrash() throws Fil
         Mockito.doReturn(obj).when(target).readFromFile(anyString());
         target.setup("", 2);
 
-        ITFFForArrayIndex itffForArrayIndex = new ITFFForArrayIndex(target);
-        Assert.assertEquals(expectedDistance, itffForArrayIndex.exceptionCoverage(executionResult), 0.00000001);
+        ITFFForIndexedAccess itffForIndexedAccess = new ITFFForIndexedAccess(target);
+        Assert.assertEquals(expectedDistance, itffForIndexedAccess.exceptionCoverage(executionResult), 0.00000001);
     }
 }
diff --git a/docs/pages/contributing.md b/docs/pages/contributing.md
@@ -12,7 +12,7 @@ Currently, Botsing using a customized version of the `evoSuite-client`. Hence, t
 
 1. Installing the customized version of EvoSuite-client:
 ```Bash
-mvn install:install-file -Dfile=botsing-reproduction/evosuite-client-botsing-1.0.7.jar -DgroupId=org.evosuite -DartifactId=evosuite-client-botsing -Dversion=1.0.7 -Dpackaging=jar
+mvn install:install-file -Dfile=botsing-reproduction/evosuite-client-botsing-1.1.0.jar -DgroupId=org.evosuite -DartifactId=evosuite-client-botsing -Dversion=1.1.0 -Dpackaging=jar
 ```
 
 2. Build the Botsing project:

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public enum TestGenerationStrategy {`
`68`	`68`	`public enum FitnessFunction {`
`69`	`69`	`WeightedSum,`
`70`	`70`	`SimpleSum,`
`71`		`- IntegrationArrayIndex,`
	`71`	`+ IntegrationIndexedAccess,`
`72`	`72`	`IntegrationSingleObjective;`
`73`	`73`	`FitnessFunction() {`
`74`	`74`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ protected double exceptionCoverage(ExecutionResult executionResult) {`
`66`	`66`	`do {`
`67`	`67`	`crashingClass = resultException.getStackTrace()[++frame].getClassName();`
`68`	`68`	`}`
`69`		`- while (frame < resultException.getStackTrace().length && (crashingClass.startsWith("java") \|\| crashingClass.startsWith("javax")));`
	`69`	`+ while (frame < resultException.getStackTrace().length && (crashingClass.startsWith("java.") \|\| crashingClass.startsWith("javax.")));`
`70`	`70`	`if (frame == resultException.getStackTrace().length) {`
`71`	`71`	`continue;`
`72`	`72`	`}`