From 42cb023b6a59474381402837aa070ad5f971c770 Mon Sep 17 00:00:00 2001 From: mmilko01 Date: Fri, 17 Apr 2026 17:25:50 +0300 Subject: [PATCH 1/8] fix: translation texts --- packages/adp-tooling/src/translations/adp-tooling.i18n.json | 2 +- .../adp-tooling/test/unit/prompts/add-new-model/index.test.ts | 2 +- .../generator-adp/src/translations/generator-adp.i18n.json | 4 ++-- packages/generator-adp/src/types.ts | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/adp-tooling/src/translations/adp-tooling.i18n.json b/packages/adp-tooling/src/translations/adp-tooling.i18n.json index f39e52e733f..2b8751540c8 100644 --- a/packages/adp-tooling/src/translations/adp-tooling.i18n.json +++ b/packages/adp-tooling/src/translations/adp-tooling.i18n.json @@ -70,7 +70,7 @@ "missingIconOrTitleOrSubtitle": "At least one of the Title, Subtitle, or Icon fields must have a value.", "fileDoesNotExist": "This file does not exist.", "annotationFileAlreadyExists": "There is already an annotation file with the same name. Please choose another file or rename the file and select it again.", - "errorDuplicatedValueOData": "An OData annotation or service with the same name was already added to the project. Rename and try again.", + "errorDuplicatedValueOData": "An Data Source and SAPUI5 model with the same name was already added to the project. Rename and try again.", "errorDuplicatedValueSapui5Model": "An SAPUI5 model with the same name was already added to the project. Rename and try again.", "errorDuplicateValueComponentId": "A component usage with the same name was already added to the project. Rename and try again.", "errorDuplicateValueLibrary": "A library with the same name was already added to the project. Rename and try again.", diff --git a/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts b/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts index 14dc0476ef9..a331894f49c 100644 --- a/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts +++ b/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts @@ -156,7 +156,7 @@ describe('getPrompts', () => { expect(typeof validation).toBe('function'); expect(validation?.('customer.testName')).toBe( - 'An OData annotation or service with the same name was already added to the project. Rename and try again.' + 'An Data Source and SAPUI5 model with the same name was already added to the project. Rename and try again.' ); }); diff --git a/packages/generator-adp/src/translations/generator-adp.i18n.json b/packages/generator-adp/src/translations/generator-adp.i18n.json index 71cf42a93f8..08e3d445054 100644 --- a/packages/generator-adp/src/translations/generator-adp.i18n.json +++ b/packages/generator-adp/src/translations/generator-adp.i18n.json @@ -13,8 +13,8 @@ "deployConfigDescr": "Configure deployment settings.", "addComponentUsagesName": "Add SAPUI5 Component Usages", "addComponentUsagesDescr": "Select SAPUI5 component usages.", - "addNewModelName": "Add Datasource and SAPUI5 Model", - "addNewModelDescr": "Select a Datasource and SAPUI5 model.", + "addNewModelName": "Add Data Source and SAPUI5 Model", + "addNewModelDescr": "Select a Data Source and SAPUI5 model.", "addLocalAnnotationFileName": "Add Local Annotation File", "addLocalAnnotationFileDescr": "Select an OData service and annotation XML file.", "replaceODataServiceName": "Replace OData Service", diff --git a/packages/generator-adp/src/types.ts b/packages/generator-adp/src/types.ts index 441ea628bbc..c97aed621e7 100644 --- a/packages/generator-adp/src/types.ts +++ b/packages/generator-adp/src/types.ts @@ -1,7 +1,7 @@ export enum GeneratorTypes { ADD_ANNOTATIONS_TO_DATA = 'Add Local Annotation File', ADD_COMPONENT_USAGES = 'Add SAPUI5 Component Usages', - ADD_NEW_MODEL = 'Add Datasource and SAPUI5 Model', + ADD_NEW_MODEL = 'Add Data Source and SAPUI5 Model', CHANGE_DATA_SOURCE = 'Replace OData Service' } From a556da0ebcc272a31dfa8de3548ca0505f358282 Mon Sep 17 00:00:00 2001 From: mmilko01 Date: Fri, 17 Apr 2026 18:00:59 +0300 Subject: [PATCH 2/8] fix: text --- packages/adp-tooling/src/translations/adp-tooling.i18n.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/adp-tooling/src/translations/adp-tooling.i18n.json b/packages/adp-tooling/src/translations/adp-tooling.i18n.json index 2b8751540c8..e52ff8f6d67 100644 --- a/packages/adp-tooling/src/translations/adp-tooling.i18n.json +++ b/packages/adp-tooling/src/translations/adp-tooling.i18n.json @@ -70,7 +70,7 @@ "missingIconOrTitleOrSubtitle": "At least one of the Title, Subtitle, or Icon fields must have a value.", "fileDoesNotExist": "This file does not exist.", "annotationFileAlreadyExists": "There is already an annotation file with the same name. Please choose another file or rename the file and select it again.", - "errorDuplicatedValueOData": "An Data Source and SAPUI5 model with the same name was already added to the project. Rename and try again.", + "errorDuplicatedValueOData": "Data Source and SAPUI5 model with the same name was already added to the project. Rename and try again.", "errorDuplicatedValueSapui5Model": "An SAPUI5 model with the same name was already added to the project. Rename and try again.", "errorDuplicateValueComponentId": "A component usage with the same name was already added to the project. Rename and try again.", "errorDuplicateValueLibrary": "A library with the same name was already added to the project. Rename and try again.", From 78592afcf46bcbafd501fb214942bfbd2aaa4ded Mon Sep 17 00:00:00 2001 From: mmilko01 Date: Mon, 20 Apr 2026 10:37:04 +0300 Subject: [PATCH 3/8] test: adapt test --- .../adp-tooling/test/unit/prompts/add-new-model/index.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts b/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts index a331894f49c..25846cd50c3 100644 --- a/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts +++ b/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts @@ -156,7 +156,7 @@ describe('getPrompts', () => { expect(typeof validation).toBe('function'); expect(validation?.('customer.testName')).toBe( - 'An Data Source and SAPUI5 model with the same name was already added to the project. Rename and try again.' + 'Data Source and SAPUI5 model with the same name was already added to the project. Rename and try again.' ); }); From 4de2bd62ac1cdbe3470ed18e8e666d0fd2a7bc8b Mon Sep 17 00:00:00 2001 From: mmilko01 Date: Mon, 20 Apr 2026 18:04:11 +0300 Subject: [PATCH 4/8] fix: plural --- packages/adp-tooling/src/translations/adp-tooling.i18n.json | 2 +- .../adp-tooling/test/unit/prompts/add-new-model/index.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/adp-tooling/src/translations/adp-tooling.i18n.json b/packages/adp-tooling/src/translations/adp-tooling.i18n.json index e52ff8f6d67..21623dc3671 100644 --- a/packages/adp-tooling/src/translations/adp-tooling.i18n.json +++ b/packages/adp-tooling/src/translations/adp-tooling.i18n.json @@ -70,7 +70,7 @@ "missingIconOrTitleOrSubtitle": "At least one of the Title, Subtitle, or Icon fields must have a value.", "fileDoesNotExist": "This file does not exist.", "annotationFileAlreadyExists": "There is already an annotation file with the same name. Please choose another file or rename the file and select it again.", - "errorDuplicatedValueOData": "Data Source and SAPUI5 model with the same name was already added to the project. Rename and try again.", + "errorDuplicatedValueOData": "Data Source and SAPUI5 model with the same name were already added to the project. Rename and try again.", "errorDuplicatedValueSapui5Model": "An SAPUI5 model with the same name was already added to the project. Rename and try again.", "errorDuplicateValueComponentId": "A component usage with the same name was already added to the project. Rename and try again.", "errorDuplicateValueLibrary": "A library with the same name was already added to the project. Rename and try again.", diff --git a/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts b/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts index 25846cd50c3..f2c061ebb8c 100644 --- a/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts +++ b/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts @@ -156,7 +156,7 @@ describe('getPrompts', () => { expect(typeof validation).toBe('function'); expect(validation?.('customer.testName')).toBe( - 'Data Source and SAPUI5 model with the same name was already added to the project. Rename and try again.' + 'Data Source and SAPUI5 model with the same name were already added to the project. Rename and try again.' ); }); From 6c39450a9d6e345b48b169f91fce47761254adaf Mon Sep 17 00:00:00 2001 From: mmilko01 <162288787+mmilko01@users.noreply.github.com> Date: Mon, 20 Apr 2026 18:07:04 +0300 Subject: [PATCH 5/8] chore: create changeset --- .changeset/cyan-glasses-own.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/cyan-glasses-own.md diff --git a/.changeset/cyan-glasses-own.md b/.changeset/cyan-glasses-own.md new file mode 100644 index 00000000000..2b843ea751d --- /dev/null +++ b/.changeset/cyan-glasses-own.md @@ -0,0 +1,6 @@ +--- +"@sap-ux/adp-tooling": patch +"@sap-ux/generator-adp": patch +--- + +fix: Translation texts for Add Data Source and SAPUI5 Model title and subtitle From 6922d078d8fcb8766c63c3c74ec408e25a413106 Mon Sep 17 00:00:00 2001 From: mmilko01 <162288787+mmilko01@users.noreply.github.com> Date: Tue, 21 Apr 2026 13:10:11 +0300 Subject: [PATCH 6/8] Chore: update error text Co-authored-by: Louise Findlay --- packages/adp-tooling/src/translations/adp-tooling.i18n.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/adp-tooling/src/translations/adp-tooling.i18n.json b/packages/adp-tooling/src/translations/adp-tooling.i18n.json index 21623dc3671..7e9cf2a15a7 100644 --- a/packages/adp-tooling/src/translations/adp-tooling.i18n.json +++ b/packages/adp-tooling/src/translations/adp-tooling.i18n.json @@ -70,7 +70,7 @@ "missingIconOrTitleOrSubtitle": "At least one of the Title, Subtitle, or Icon fields must have a value.", "fileDoesNotExist": "This file does not exist.", "annotationFileAlreadyExists": "There is already an annotation file with the same name. Please choose another file or rename the file and select it again.", - "errorDuplicatedValueOData": "Data Source and SAPUI5 model with the same name were already added to the project. Rename and try again.", + "errorDuplicatedValueOData": "A data source and SAPUI5 model with the same name were already added to the project. Rename and try again.", "errorDuplicatedValueSapui5Model": "An SAPUI5 model with the same name was already added to the project. Rename and try again.", "errorDuplicateValueComponentId": "A component usage with the same name was already added to the project. Rename and try again.", "errorDuplicateValueLibrary": "A library with the same name was already added to the project. Rename and try again.", From 682e87d8bb41a43ebe0fe588c2741fb333747b25 Mon Sep 17 00:00:00 2001 From: mmilko01 <162288787+mmilko01@users.noreply.github.com> Date: Tue, 21 Apr 2026 13:10:44 +0300 Subject: [PATCH 7/8] chore: update subtitle text Co-authored-by: Louise Findlay --- packages/generator-adp/src/translations/generator-adp.i18n.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/generator-adp/src/translations/generator-adp.i18n.json b/packages/generator-adp/src/translations/generator-adp.i18n.json index 08e3d445054..228667c0f0d 100644 --- a/packages/generator-adp/src/translations/generator-adp.i18n.json +++ b/packages/generator-adp/src/translations/generator-adp.i18n.json @@ -14,7 +14,7 @@ "addComponentUsagesName": "Add SAPUI5 Component Usages", "addComponentUsagesDescr": "Select SAPUI5 component usages.", "addNewModelName": "Add Data Source and SAPUI5 Model", - "addNewModelDescr": "Select a Data Source and SAPUI5 model.", + "addNewModelDescr": "Select a data source and SAPUI5 model.", "addLocalAnnotationFileName": "Add Local Annotation File", "addLocalAnnotationFileDescr": "Select an OData service and annotation XML file.", "replaceODataServiceName": "Replace OData Service", From 597a68ecc3407f1293371ea1f4c7e4566e3253a3 Mon Sep 17 00:00:00 2001 From: mmilko01 Date: Tue, 21 Apr 2026 13:32:31 +0300 Subject: [PATCH 8/8] test: fix error message in tests --- .../adp-tooling/test/unit/prompts/add-new-model/index.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts b/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts index f2c061ebb8c..a2ce85471f8 100644 --- a/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts +++ b/packages/adp-tooling/test/unit/prompts/add-new-model/index.test.ts @@ -156,7 +156,7 @@ describe('getPrompts', () => { expect(typeof validation).toBe('function'); expect(validation?.('customer.testName')).toBe( - 'Data Source and SAPUI5 model with the same name were already added to the project. Rename and try again.' + 'A data source and SAPUI5 model with the same name were already added to the project. Rename and try again.' ); });