fix(adp-tooling): Improve logging for Cloud Foundry setup (#4599)

* fix: improve logging

* chore: create changeset

* fix: lint issue

* Linting auto fix commit

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: mmilko01

.changeset/young-birds-decide.md

@@ -0,0 +1,5 @@
+---
+"@sap-ux/adp-tooling": patch
+---
+
+fix(adp-tooling): Improve logging for Cloud Foundry setup

packages/adp-tooling/src/cf/core/auth.ts

@@ -29,8 +29,7 @@ export async function isLoggedInCf(cfConfig: CfConfig, logger: ToolsLogger): Pro
     }
 
     try {
-        const token = await cfGetAuthToken();
-        logger?.log(`Retrieved CF auth token: ${token}`);
+        await cfGetAuthToken();
         return true;
     } catch (e) {
         logger?.error(`Error occurred while trying to check if it is logged in: ${e?.message}`);

packages/adp-tooling/src/cf/services/api.ts

@@ -171,7 +171,7 @@ export async function getCfUi5AppInfo(
         appId
     )}&${appHostIdParams}`;
 
-    logger?.log(`Fetching ui5AppInfo.json from FDC: ${url}`);
+    logger?.log(`Fetching ui5AppInfo.json`);
 
     try {
         const response = await axios.get(url, requestArguments.options);

packages/adp-tooling/src/writer/cf.ts

@@ -159,5 +159,8 @@ export async function setupCfPreview(
     }
 
     await writeUi5AppInfo(basePath, ui5AppInfo, logger);
+
+    logger?.log('Starting build');
     await runBuild(basePath, { ADP_BUILDER_MODE: 'preview' });
+    logger?.log('Build completed');
 }

packages/adp-tooling/test/unit/cf/core/auth.test.ts

@@ -72,7 +72,6 @@ describe('CF Core Auth', () => {
 
             expect(result).toBe(true);
             expect(mockCfGetAuthToken).toHaveBeenCalledTimes(1);
-            expect(mockLogger.log).toHaveBeenCalledWith(`Retrieved CF auth token: ${mockToken}`);
         });
 
         test('should return false when cfGetAuthToken throws an error', async () => {

packages/adp-tooling/test/unit/cf/services/api.test.ts

@@ -261,9 +261,7 @@ describe('CF Services API', () => {
                     } as Record<string, string>)
                 } as Record<string, unknown>)
             );
-            expect(mockLogger.log).toHaveBeenCalledWith(
-                'Fetching ui5AppInfo.json from FDC: https://ui5-flexibility-design-and-configuration.sapui5flex.cfapps.test.cf.com/api/business-service/ui5appinfo?appId=test-app-id&appHostId=host-1&appHostId=host-2'
-            );
+            expect(mockLogger.log).toHaveBeenCalledWith('Fetching ui5AppInfo.json');
             expect(mockLogger.log).toHaveBeenCalledWith('Successfully retrieved ui5AppInfo.json from FDC');
         });
 

packages/adp-tooling/test/unit/writer/cf.test.ts

@@ -232,7 +232,8 @@ describe('CF Writer', () => {
     describe('setupCfPreview', () => {
         const mockLogger = {
             info: jest.fn(),
-            error: jest.fn()
+            error: jest.fn(),
+            log: jest.fn()
         } as unknown as ToolsLogger;
 
         const mockCfConfig: CfConfig = {
@@ -287,6 +288,8 @@ describe('CF Writer', () => {
             expect(mockGetBaseAppId).toHaveBeenCalledWith(projectDir);
             expect(mockGetCfUi5AppInfo).toHaveBeenCalledWith('test-app-id', ['host-123'], mockCfConfig, mockLogger);
             expect(mockRunBuild).toHaveBeenCalledWith(projectDir, { ADP_BUILDER_MODE: 'preview' });
+            expect(mockLogger.log).toHaveBeenCalledWith('Starting build');
+            expect(mockLogger.log).toHaveBeenCalledWith('Build completed');
         });
 
         test('should throw error when serviceInstanceName not found', async () => {