fix: SSH tunnel not started in BAS for on-premise connectivity for CF ADP (#4559)

* fix: remove bas check

* chore: add cset

Author: nikmace

.changeset/tall-rivers-tie.md

@@ -0,0 +1,5 @@
+---
+'@sap-ux/backend-proxy-middleware-cf': patch
+---
+
+fix: SSH tunnel not started in BAS for on-premise connectivity for CF ADP

packages/backend-proxy-middleware-cf/src/tunnel/tunnel.ts

@@ -2,7 +2,6 @@ import net from 'node:net';
 import { spawn } from 'node:child_process';
 import type { ChildProcess } from 'node:child_process';
 
-import { isAppStudio } from '@sap-ux/btp-utils';
 import type { ToolsLogger } from '@sap-ux/logger';
 import { ensureTunnelAppExists, enableSshAndRestart, DEFAULT_TUNNEL_APP_NAME } from '@sap-ux/adp-tooling';
 
@@ -118,7 +117,7 @@ function registerCleanup(tunnelProcess: ChildProcess, logger: ToolsLogger): void
 
 /**
  * Start an SSH tunnel to the connectivity proxy if needed.
- * Skips if running in BAS, if the port is already in use, or if no connectivity service is present.
+ * Skips if the port is already in use or if no connectivity service is present.
  * Errors are logged as warnings; the middleware continues without the tunnel.
  *
  * @param connectivityInfo - Original connectivity proxy host and port from VCAP_SERVICES.
@@ -134,11 +133,6 @@ export async function startSshTunnelIfNeeded(
     options?: SshTunnelOptions
 ): Promise<ChildProcess | undefined> {
     try {
-        if (isAppStudio()) {
-            logger.debug('Running in BAS, SSH tunnel not needed.');
-            return undefined;
-        }
-
         const localPort = options?.localPort ?? connectivityInfo.port;
 
         if (await isPortInUse(localPort)) {

packages/backend-proxy-middleware-cf/test/unit/tunnel/tunnel.test.ts

@@ -2,7 +2,6 @@ import net from 'node:net';
 import { EventEmitter } from 'node:events';
 
 import type { ToolsLogger } from '@sap-ux/logger';
-import { isAppStudio } from '@sap-ux/btp-utils';
 import { ensureTunnelAppExists, enableSshAndRestart } from '@sap-ux/adp-tooling';
 import { spawn } from 'node:child_process';
 
@@ -14,10 +13,6 @@ jest.mock('node:child_process', () => ({
     spawn: jest.fn()
 }));
 
-jest.mock('@sap-ux/btp-utils', () => ({
-    isAppStudio: jest.fn()
-}));
-
 jest.mock('@sap-ux/adp-tooling', () => ({
     ensureTunnelAppExists: jest.fn(),
     enableSshAndRestart: jest.fn(),
@@ -29,7 +24,6 @@ jest.mock('../../../src/tunnel/destination-check', () => ({
 }));
 
 const mockSpawn = spawn as jest.Mock;
-const mockIsAppStudio = isAppStudio as jest.Mock;
 const mockEnsureTunnel = ensureTunnelAppExists as jest.Mock;
 const mockEnableSsh = enableSshAndRestart as jest.Mock;
 const mockHasOnPremise = hasOnPremiseDestination as jest.Mock;
@@ -100,7 +94,6 @@ describe('tunnel', () => {
 
     beforeEach(() => {
         jest.clearAllMocks();
-        mockIsAppStudio.mockReturnValue(false);
         processOnSpy = jest.spyOn(process, 'on');
         processOnceSpy = jest.spyOn(process, 'once');
     });
@@ -125,15 +118,6 @@ describe('tunnel', () => {
     }
 
     describe('startSshTunnelIfNeeded', () => {
-        test('should return undefined when running in BAS', async () => {
-            mockIsAppStudio.mockReturnValue(true);
-
-            const result = await startSshTunnelIfNeeded(connectivityInfo, 'tunnel-app', logger);
-
-            expect(result).toBeUndefined();
-            expect(logger.debug).toHaveBeenCalledWith(expect.stringContaining('BAS'));
-        });
-
         test('should return undefined when port is already in use', async () => {
             createServerSpy = jest
                 .spyOn(net, 'createServer')
@@ -254,7 +238,6 @@ describe('tunnel', () => {
         test('should deploy tunnel app and start tunnel when OnPremise found', async () => {
             mockHasOnPremise.mockResolvedValue(true);
             mockEnsureTunnel.mockResolvedValue(undefined);
-            mockIsAppStudio.mockReturnValue(true);
 
             await setupSshTunnel('/root', connectivityInfo, effectiveOptions, logger);
 
@@ -264,7 +247,6 @@ describe('tunnel', () => {
         test('should use custom tunnelAppName from options', async () => {
             mockHasOnPremise.mockResolvedValue(true);
             mockEnsureTunnel.mockResolvedValue(undefined);
-            mockIsAppStudio.mockReturnValue(true);
 
             const opts = { ...effectiveOptions, tunnelAppName: 'custom-app' } as unknown as EffectiveOptions;
             await setupSshTunnel('/root', connectivityInfo, opts, logger);