fix(ui5-test-writer): fix Object Page tests (#4521)

docirl · sap-sebelao · web-flow · commit 17d8e4287345 · 2026-04-09T21:32:43.000+01:00
* remove goToSecion method

* Replace iGoToSection with custom action

- always generate a simple action to click tab buttons on object pages
- use action as a replacement for
iGoToSection

* Fix template, update snapshots

* Update dependent package snapshots

* Skip number of sections check for single section object pages

* changeset

* remove change to project-integrity

---------

Co-authored-by: I334706 &lt;ondrej.sebela@sap.com&gt;
Co-authored-by: Ondřej Šebela &lt;91870542+sap-sebelao@users.noreply.github.com&gt;
diff --git a/.changeset/mighty-humans-switch.md b/.changeset/mighty-humans-switch.md
@@ -0,0 +1,5 @@
+---
+'@sap-ux/ui5-test-writer': patch
+---
+
+fixes for object page opa test failures
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/alp_v4/webapp/test/integration/pages/MaterialDetailsObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/alp_v4/webapp/test/integration/pages/MaterialDetailsObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/alp_v4/webapp/test/integration/pages/SalesOrderItemObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/alp_v4/webapp/test/integration/pages/SalesOrderItemObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/alp_v4_cap/app/alp_v4_cap/webapp/test/integration/pages/BooksObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/alp_v4_cap/app/alp_v4_cap/webapp/test/integration/pages/BooksObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/alp_v4_cap_typescript/app/alp_v4_cap_typescript/webapp/test/integration/pages/BooksObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/alp_v4_cap_typescript/app/alp_v4_cap_typescript/webapp/test/integration/pages/BooksObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/feop_v4_cap/app/feop_v4_cap/webapp/test/integration/pages/BooksObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/feop_v4_cap/app/feop_v4_cap/webapp/test/integration/pages/BooksObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/form_entry_v4/webapp/test/integration/pages/BookingObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/form_entry_v4/webapp/test/integration/pages/BookingObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/form_entry_v4/webapp/test/integration/pages/TravelObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/form_entry_v4/webapp/test/integration/pages/TravelObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/headless/lrop_v4_no_ui5_version/webapp/test/integration/pages/BookingObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/headless/lrop_v4_no_ui5_version/webapp/test/integration/pages/BookingObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/headless/lrop_v4_no_ui5_version/webapp/test/integration/pages/TravelObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/headless/lrop_v4_no_ui5_version/webapp/test/integration/pages/TravelObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/lrop_v4/webapp/test/integration/pages/BookingObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/lrop_v4/webapp/test/integration/pages/BookingObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/lrop_v4/webapp/test/integration/pages/TravelObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/lrop_v4/webapp/test/integration/pages/TravelObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/lrop_v4_cap/app/lrop_v4_cap/webapp/test/integration/pages/BooksObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/lrop_v4_cap/app/lrop_v4_cap/webapp/test/integration/pages/BooksObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/lrop_v4_cap_java/app/lrop_v4_cap_java/webapp/test/integration/pages/BooksObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/lrop_v4_cap_java/app/lrop_v4_cap_java/webapp/test/integration/pages/BooksObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/lrop_v4_version_not_specified/app/lrop_v4_version_not_specified/webapp/test/integration/pages/BooksObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/lrop_v4_version_not_specified/app/lrop_v4_version_not_specified/webapp/test/integration/pages/BooksObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/worklist_v4/webapp/test/integration/pages/BookingObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/worklist_v4/webapp/test/integration/pages/BookingObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/worklist_v4/webapp/test/integration/pages/TravelObjectPage.js b/packages/fiori-app-sub-generator/test/int/fiori-elements/expected-output/worklist_v4/webapp/test/integration/pages/TravelObjectPage.js
@@ -1,8 +1,15 @@
-sap.ui.define(['sap/fe/test/ObjectPage'], function(ObjectPage) {
+sap.ui.define(['sap/fe/test/ObjectPage', 'sap/ui/test/actions/Press'], function(ObjectPage, Press) {
     'use strict';
 
     var CustomPageDefinitions = {
-        actions: {},
+        actions: {
+            iPressSectionIconTabFilterButton: function (section) {
+                return this.waitFor({
+                    id: new RegExp(`.*--fe::FacetSection::${section}-anchor$`),
+                    actions: new Press()
+                });
+            }
+        },
         assertions: {}
     };
 
diff --git a/packages/fiori-elements-writer/test/__snapshots__/lrop.test.ts.snap b/packages/fiori-elements-writer/test/__snapshots__/lrop.test.ts.snap
diff --git a/packages/fiori-elements-writer/test/__snapshots__/worklist.test.ts.snap b/packages/fiori-elements-writer/test/__snapshots__/worklist.test.ts.snap
diff --git a/packages/ui5-test-writer/templates/v4/integration/ObjectPageJourney.js b/packages/ui5-test-writer/templates/v4/integration/ObjectPageJourney.js
diff --git a/packages/ui5-test-writer/templates/v4/integration/pages/ObjectPage.js b/packages/ui5-test-writer/templates/v4/integration/pages/ObjectPage.js
diff --git a/packages/ui5-test-writer/test/unit/__snapshots__/fiori-elements.test.ts.snap b/packages/ui5-test-writer/test/unit/__snapshots__/fiori-elements.test.ts.snap
diff --git a/packages/ui5-test-writer/test/unit/fiori-elements.test.ts b/packages/ui5-test-writer/test/unit/fiori-elements.test.ts

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@sap-ux/ui5-test-writer': patch
 +---
++
 +fixes for object page opa test failures