feat: support eslint 10 (#4439)

* feat: add eslint 10 support

* fix: add eslint 10 for rest of modules

* fix: remove deprecated property

* fix: add change set

* Linting auto fix commit

* fix Jest 30 Enzyme compatibility by resolving Cheerio exports and required web API polyfills

* fix: failing test

* fix: failing test and review comment

* chore: merge main into feat/support-eslint-10 and resolve conflicts

- examples/fe-fpm-cli: take mains newer @types/vinyl and typescript-eslint
- examples/ui-prompting-examples: take mains css-loader 7.1.4, keep eslint 9.39.1 (React package)
- package.json: keep eslint 10.0.3 from PR; take mains newer @types/node, esbuild, typescript-eslint
- eslint-plugin-fiori-tools: peerDep eslint set to >=9 (supports both 9 and 10)
- eslint-plugin-fiori-tools/src/index.ts: keep fioriRules alias in both config exports
- preview-middleware-client/eslint.config.js: take mains corrected tseslint.plugin/parser usage

* chore: merge origin/main into feat/support-eslint-10 (batch 2)

* chore: update pnpm-lock.yaml after merging main into feat/support-eslint-10

* chore: remove WIP files that don't belong on this branch

Candidate 1 mta-config refactor files and RFC docs were accidentally
committed during the main merge. They belong on a separate
refactor/cf-deploy-config-mta-god-class branch.

* chore: consolidate eslint-10 changesets

* fix(ui-components): resolve cheerio/lib/utils to physical pnpm path for Jest moduleNameMapper

* test: improve coverage for eslint-10 migration changes

- sap-no-override-rendering: add valid/invalid cases with custom ns options
  to cover the context.options[0]?.ns ternary branch
- create-table-custom-column-config-change: add test for findAnchor() IIFE
  branch when metaPath does not contain 'LineItem', triggering
  getLineItemAnnotation() to compute the annotation path

* fix: adapte peerDependencies

* Update packages/app-config-writer/test/unit/eslint-config/convert.test.ts

Co-authored-by: Dominik Heim <[email protected]>

* fix: remove un-used file

* fix: cst

* fix: exclude type declaration files from coverage

* fix: major bump for @sap-ux/eslint-plugin-fiori-tools

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: John Long <[email protected]>
Co-authored-by: Dominik Heim <[email protected]>

Author: 4 people

.changeset/fair-adults-cheat.md

@@ -0,0 +1,9 @@
+---
+'@sap-ux/eslint-plugin-fiori-tools': major
+'@sap-ux/app-config-writer': patch
+'@sap-ux/ui5-application-writer': patch
+'@sap-ux/ui5-library-writer': patch
+'@sap-ux-private/preview-middleware-client': patch
+---
+
+feat: support ESLint 10

examples/ui-prompting-examples/package.json

@@ -53,6 +53,7 @@
         "babel-loader": "10.1.1",
         "copyfiles": "2.4.1",
         "css-loader": "7.1.4",
+        "eslint": "9.39.1",
         "eslint-plugin-react": "7.37.5",
         "eslint-plugin-storybook": "0.6.15",
         "mem-fs": "2.1.0",

package.json

@@ -7,15 +7,15 @@
     "devDependencies": {
         "@changesets/cli": "2.30.0",
         "@eslint/eslintrc": "3.3.5",
-        "@eslint/js": "9.22.0",
+        "@eslint/js": "10.0.1",
         "@playwright/test": "1.58.2",
         "@types/jest": "30.0.0",
         "@types/node": "20.19.37",
         "autoprefixer": "10.4.27",
         "check-dependency-version-consistency": "6.0.0",
         "esbuild": "0.27.4",
         "esbuild-sass-plugin": "3.7.0",
-        "eslint": "9.39.1",
+        "eslint": "10.0.3",
         "eslint-config-prettier": "10.1.8",
         "eslint-import-resolver-typescript": "4.4.4",
         "eslint-plugin-import": "2.32.0",

packages/app-config-writer/src/eslint-config/convert.ts

@@ -369,8 +369,8 @@ async function updatePackageJson(basePath: string, fs: Editor, logger?: ToolsLog
     const packageJsonPath = join(basePath, FileName.Package);
     const packageJson = fs.readJSON(packageJsonPath) as Package;
     packageJson.devDependencies ??= {};
-    packageJson.devDependencies[packageName.ESLINT] = '^9.0.0';
-    packageJson.devDependencies[packageName.ESLINT_PLUGIN_FIORI_TOOLS] = '^9.0.0';
+    packageJson.devDependencies[packageName.ESLINT] = '^10.0.0';
+    packageJson.devDependencies[packageName.ESLINT_PLUGIN_FIORI_TOOLS] = '^10.0.0';
     delete packageJson.devDependencies[packageName.ESLINT_PLUGIN_FIORI_CUSTOM];
     packageJson.scripts ??= {};
     if (packageJson.scripts['lint']) {

packages/app-config-writer/test/unit/eslint-config/add.test.ts

@@ -79,8 +79,8 @@ describe('generateEslintConfig', () => {
             const packageJson = fs.readJSON(packageJsonPath) as Package;
 
             expect(packageJson.devDependencies).toBeDefined();
-            expect(packageJson.devDependencies?.eslint).toBe('^9');
-            expect(packageJson.devDependencies?.['@sap-ux/eslint-plugin-fiori-tools']).toBe('^9.0.0');
+            expect(packageJson.devDependencies?.eslint).toBe('^10');
+            expect(packageJson.devDependencies?.['@sap-ux/eslint-plugin-fiori-tools']).toBe('^10.0.0');
         });
 
         test('should add lint script to package.json', async () => {

packages/app-config-writer/test/unit/eslint-config/convert.test.ts

@@ -610,17 +610,17 @@ describe('convertEslintConfig', () => {
             const packageJsonPath = join(basePath, 'package.json');
             const packageJson = fs.readJSON(packageJsonPath) as Package;
 
-            expect(packageJson.devDependencies?.eslint).toBe('^9.0.0');
+            expect(packageJson.devDependencies?.eslint).toBe('^10.0.0');
         });
 
-        test('should update @sap-ux/eslint-plugin-fiori-tools version to ^9.0.0', async () => {
+        test('should update @sap-ux/eslint-plugin-fiori-tools version to ^10.0.0', async () => {
             const basePath = join(__dirname, '../../fixtures/eslint-config/existing-config');
             await convertEslintConfig(basePath, { logger: loggerMock, fs });
 
             const packageJsonPath = join(basePath, 'package.json');
             const packageJson = fs.readJSON(packageJsonPath) as Package;
 
-            expect(packageJson.devDependencies?.['@sap-ux/eslint-plugin-fiori-tools']).toBe('^9.0.0');
+            expect(packageJson.devDependencies?.['@sap-ux/eslint-plugin-fiori-tools']).toBe('^10.0.0');
         });
 
         test('should preserve existing devDependencies', async () => {
@@ -660,7 +660,7 @@ describe('convertEslintConfig', () => {
 
             const updatedPackageJson = fs.readJSON(packageJsonPath) as Package;
             expect(updatedPackageJson.devDependencies).toBeDefined();
-            expect(updatedPackageJson.devDependencies?.eslint).toBe('^9.0.0');
+            expect(updatedPackageJson.devDependencies?.eslint).toBe('^10.0.0');
         });
     });
 
@@ -762,8 +762,8 @@ describe('convertEslintConfig', () => {
             // Verify package.json was updated
             const packageJsonPath = join(basePath, 'package.json');
             const packageJson = fs.readJSON(packageJsonPath) as Package;
-            expect(packageJson.devDependencies?.eslint).toBe('^9.0.0');
-            expect(packageJson.devDependencies?.['@sap-ux/eslint-plugin-fiori-tools']).toBe('^9.0.0');
+            expect(packageJson.devDependencies?.eslint).toBe('^10.0.0');
+            expect(packageJson.devDependencies?.['@sap-ux/eslint-plugin-fiori-tools']).toBe('^10.0.0');
 
             // Verify result is the fs instance
             expect(result).toBe(fs);

packages/control-property-editor/package.json

@@ -37,6 +37,7 @@
         "@types/remote-redux-devtools": "0.5.8",
         "@types/source-map-support": "0.5.10",
         "@types/react": "16.14.69",
+        "eslint": "9.39.1",
         "eslint-plugin-react": "7.37.5",
         "http-proxy-middleware": "3.0.5",
         "i18next": "25.10.10",

packages/eslint-plugin-fiori-tools/jest.config.js

@@ -3,5 +3,11 @@ module.exports = {
     ...config,
     // coverageProvider: 'v8' overrides jest.base default ('babel'); collectCoverage: true is inherited from jest.base
     coverageProvider: 'v8',
-    setupFiles: ['<rootDir>/test/global-setup.ts']
-}
+    setupFiles: ['<rootDir>/test/global-setup.ts'],
+    coveragePathIgnorePatterns: [
+        'src/types.ts',
+        'src/language/annotations/types.ts',
+        'src/language/json/types.ts',
+        'src/language/xml/types.ts'
+    ]
+};

packages/eslint-plugin-fiori-tools/package.json

@@ -26,17 +26,18 @@
         "cross-env": "10.1.0",
         "eslint": "9.39.1",
         "@typescript-eslint/rule-tester": "8.57.2",
-        "eslint-plugin-eslint-plugin": "7.3.2"
+        "eslint-plugin-eslint-plugin": "7.3.2",
+        "@types/semver": "7.7.1"
     },
     "dependencies": {
         "@babel/core": "7.29.0",
         "@babel/eslint-parser": "^7.28.5",
-        "@eslint/js": "9.22.0",
+        "@eslint/js": "10.0.1",
         "@eslint/json": "0.14.0",
-        "@eslint/core": "0.17.0",
+        "@eslint/core": "1.1.1",
         "@eslint/config-helpers": "0.5.3",
-        "@typescript-eslint/eslint-plugin": ">=8.57.2",
-        "@typescript-eslint/parser": ">=8.57.2",
+        "@typescript-eslint/eslint-plugin": "8.57.2",
+        "@typescript-eslint/parser": "8.57.2",
         "@sap-ux/fiori-annotation-api": "workspace:*",
         "@sap-ux/odata-annotation-core": "workspace:*",
         "@sap-ux/odata-vocabularies": "workspace:*",
@@ -46,7 +47,7 @@
         "@xml-tools/ast": "5.0.5",
         "@xml-tools/parser": "1.0.11",
         "@humanwhocodes/momoa": "^3.3.9",
-        "@eslint/plugin-kit": "0.5.0",
+        "@eslint/plugin-kit": "0.6.1",
         "globals": "17.4.0",
         "lodash": "4.18.1",
         "requireindex": "^1.2.0",
@@ -55,9 +56,8 @@
         "semver": "7.7.4"
     },
     "peerDependencies": {
-        "eslint": "^9",
-        "typescript-eslint": "^8.57.2",
-        "@types/semver": "7.7.1"
+        "eslint": "^9 || ^10",
+        "typescript-eslint": "^8.57.2"
     },
     "engines": {
         "node": ">=20.x"

packages/eslint-plugin-fiori-tools/src/index.ts

@@ -40,6 +40,8 @@ export const languages = {
     fiori: new FioriLanguage()
 };
 
+const fioriRules = rules as Plugin['rules'];
+
 /**
  * Default export following ESLint 9 plugin structure.
  * This is the recommended way to export plugins in ESLint 9.
@@ -52,7 +54,7 @@ const plugin: Plugin = {
         namespace: '@sap-ux/fiori-tools'
     },
     languages,
-    rules: rules as Plugin['rules'],
+    rules: fioriRules,
     processors: {}
 };
 
@@ -493,7 +495,7 @@ export const configs: Record<string, Linter.Config[]> = {
             plugins: {
                 '@sap-ux/fiori-tools': {
                     meta,
-                    rules: rules as Plugin['rules']
+                    rules: fioriRules
                 }
             }
         },
@@ -507,7 +509,7 @@ export const configs: Record<string, Linter.Config[]> = {
                 '@sap-ux/fiori-tools': {
                     meta,
                     languages,
-                    rules: rules as Plugin['rules']
+                    rules: fioriRules
                 }
             }
         },