fix(eslint): check min UI5 version for rule sap-width-including-column-header (#4470)

* fix(eslint): check min UI5 version for rule sap-width-including-column-header

* add changeset

* docs: improved wording

* update changeset to use patch

* Delete .changeset/small-bags-chew.md

* Apply suggestions from code review

Co-authored-by: Louise Findlay <[email protected]>

---------

Co-authored-by: Louise Findlay <[email protected]>
Co-authored-by: igorsVoronins <[email protected]>

Author: 3 people

.changeset/public-pandas-guess.md

@@ -0,0 +1,5 @@
+---
+'@sap-ux/eslint-plugin-fiori-tools': patch
+---
+
+Fix: Check minUI5 version for the sap-width-including-column-header rule

packages/eslint-plugin-fiori-tools/docs/rules/sap-width-including-column-header.md

@@ -1,6 +1,6 @@
 # Require `widthIncludingColumnHeader` for Small Tables (`sap-width-including-column-header`)
 
-Ensures that small tables (less than six columns) include the `widthIncludingColumnHeader` property set to `true` for improved calculation of the column width.
+Ensures that small tables (less than six columns) include the `widthIncludingColumnHeader` property set to `true` for improved calculation of the column width. The rule is applicable to OData V4 applications with a minimum SAPUI5 version of 1.120.
 
 ## Rule Details
 

packages/eslint-plugin-fiori-tools/src/rules/sap-width-including-column-header.ts

@@ -10,6 +10,7 @@ import { getRecordType } from '../project-context/linker/annotations';
 import type { FeV4ObjectPage, FeV4ListReport, Table } from '../project-context/linker/fe-v4';
 import type { ParsedApp, ParsedService } from '../project-context/parser';
 import { createJsonFixer } from '../language/rule-fixer';
+import { isLowerThanMinimalUi5Version } from '../utils/version';
 
 export type RequireWidthIncludingColumnHeaderOptions = {
     form: string;
@@ -110,8 +111,14 @@ const rule: FioriRuleDefinition = createFioriRule({
             if (app.type !== 'fe-v4') {
                 continue;
             }
+            const parsedApp = context.sourceCode.projectContext.index.apps[appKey];
+            if (
+                !parsedApp.manifest.minUI5Version ||
+                isLowerThanMinimalUi5Version(parsedApp.manifest.minUI5Version, { major: 1, minor: 120 })
+            ) {
+                continue;
+            }
             for (const page of app.pages) {
-                const parsedApp = context.sourceCode.projectContext.index.apps[appKey];
                 const parsedService = context.sourceCode.projectContext.getIndexedServiceForMainService(parsedApp);
                 if (!parsedService) {
                     continue;

packages/eslint-plugin-fiori-tools/test/rules/sap-width-including-column-header.test.ts

@@ -116,6 +116,14 @@ ruleTester.run(TEST_NAME, flexEnabledRule, {
                 code: JSON.stringify(V4_MANIFEST)
             },
             [_6_COLUMNS_ANNOTATIONS]
+        ),
+        createValidTest(
+            {
+                name: 'ui5 version lower than 1.120 - no warning for small table',
+                filename: V4_MANIFEST_PATH,
+                code: getManifestAsCode(V4_MANIFEST, [])
+            },
+            [ORIGINAL_ANNOTATIONS]
         )
     ],
 
@@ -124,7 +132,12 @@ ruleTester.run(TEST_NAME, flexEnabledRule, {
             {
                 name: 'widthIncludingColumnHeader missing for small table',
                 filename: V4_MANIFEST_PATH,
-                code: getManifestAsCode(V4_MANIFEST, []),
+                code: getManifestAsCode(V4_MANIFEST, [
+                    {
+                        path: ['sap.ui5', 'dependencies', 'minUI5Version'],
+                        value: '1.120.0'
+                    }
+                ]),
                 errors: [
                     {
                         messageId: 'width-including-column-header-manifest',
@@ -133,6 +146,10 @@ ruleTester.run(TEST_NAME, flexEnabledRule, {
                     }
                 ],
                 output: getManifestAsCode(V4_MANIFEST, [
+                    {
+                        path: ['sap.ui5', 'dependencies', 'minUI5Version'],
+                        value: '1.120.0'
+                    },
                     {
                         path: [
                             'sap.ui5',
@@ -170,7 +187,12 @@ ruleTester.run(TEST_NAME, flexEnabledRule, {
             [
                 {
                     filename: V4_MANIFEST_PATH,
-                    code: JSON.stringify(V4_MANIFEST, undefined, 2)
+                    code: getManifestAsCode(V4_MANIFEST, [
+                        {
+                            path: ['sap.ui5', 'dependencies', 'minUI5Version'],
+                            value: '1.120.0'
+                        }
+                    ])
                 }
             ]
         ),
@@ -179,6 +201,10 @@ ruleTester.run(TEST_NAME, flexEnabledRule, {
                 name: 'small object page table',
                 filename: V4_MANIFEST_PATH,
                 code: getManifestAsCode(V4_MANIFEST, [
+                    {
+                        path: ['sap.ui5', 'dependencies', 'minUI5Version'],
+                        value: '1.120.0'
+                    },
                     {
                         path: [
                             'sap.ui5',
@@ -203,6 +229,10 @@ ruleTester.run(TEST_NAME, flexEnabledRule, {
                     }
                 ],
                 output: getManifestAsCode(V4_MANIFEST, [
+                    {
+                        path: ['sap.ui5', 'dependencies', 'minUI5Version'],
+                        value: '1.120.0'
+                    },
                     {
                         path: [
                             'sap.ui5',