Build images for node 10, 12 and 14 (#17)

Co-authored-by: Christopher Fenner <[email protected]>
Co-authored-by: Stephan Aßmus <[email protected]>

Author: 3 people

.github/workflows/build.yml

@@ -0,0 +1,35 @@
+name: Build images and push (on master branch or on schedule)
+
+on:
+  push:
+    branches:
+      - "**"
+  schedule:
+    - cron:  '0 0 * * 0'
+  workflow_dispatch:
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        base-image-tag: [10-buster, 12-buster, 14-buster]
+    steps:
+    - uses: actions/checkout@master
+    - name: Test
+      run: |
+        chmod +x runTests.sh && ./runTests.sh ${{ matrix.base-image-tag }}
+    - name: Build
+      run: |
+        docker build --build-arg=BASE_IMAGE_TAG=${{ matrix.base-image-tag }} --tag ppiper/node-browsers:${{ matrix.base-image-tag }} .
+    - name: Tag latest image
+      if: ${{ matrix.base-image-tag == 10-buster }}
+      run: docker tag ppiper/node-browsers:${{ matrix.base-image-tag }} ppiper/node-browsers:latest
+    - name: Push
+      if: ${{ github.ref == 'ref/head/master' }}
+      run: |
+        echo ${{ secrets.DOCKERHUB_PASSWORD }} | docker login -u ${{ secrets.DOCKERHUB_USER }} --password-stdin
+        docker push ppiper/node-browsers:${{ matrix.base-image-tag }}
+        if [ "${{ matrix.base-image-tag }}" == 10-buster ]; then
+          docker push ppiper/node-browsers:latest
+        fi

.github/workflows/lint.yml

@@ -13,4 +13,5 @@ jobs:
         # https://github.com/hadolint/hadolint/wiki/DL3016
         # https://github.com/hadolint/hadolint/wiki/DL3018
         # https://github.com/hadolint/hadolint/wiki/DL3015
-        args: --ignore DL3008 --ignore DL3013 --ignore DL3016 --ignore DL3018 --ignore DL3015
+        # https://github.com/hadolint/hadolint/wiki/DL3006 Make it work to build multiple node versions in one dockerfile via matrix build
+        args: --ignore DL3008 --ignore DL3013 --ignore DL3016 --ignore DL3018 --ignore DL3015 --ignore DL3006

.github/workflows/push.yml

@@ -10,8 +10,14 @@ on:
 jobs:
   create-release:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        base-image-tag: [10-buster, 12-buster, 14-buster]
     steps:
       - uses: actions/checkout@v1
+      - name: Test
+        run: |
+          chmod +x runTests.sh && ./runTests.sh ${{ matrix.base-image-tag }}
       - name: Prepare Release
         run: |
           CURRENT_VERSION_LONG=$(curl --silent "https://api.github.com/repos/SAP/devops-docker-node-browsers/releases" | jq -r '.[].tag_name' | head -n1)
@@ -26,14 +32,16 @@ jobs:
           fi
           echo "::set-env name=PIPER_version::$NEXT_VERSION"
 
-      - name: Build, test and push
+      - name: Build and push
         run: |
           echo ${{ secrets.DOCKERHUB_PASSWORD }} | docker login -u ${{ secrets.DOCKERHUB_USER }} --password-stdin
-          docker build -t ppiper/node-browsers:${{ env.PIPER_version }} .
-          docker build -t ppiper/node-browsers:${{ env.PIPER_version }}-node12 node12
+          docker build --build-arg=BASE_IMAGE_TAG=${{ matrix.base-image-tag }} --tag ppiper/node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }} .
+          docker push ppiper/node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }}
+      - name: Tag and push node 10 image
+        if: ${{ matrix.base-image-tag == 10-buster }}
+        run: |
+          docker tag ppiper/node-browsers:10-buster ppiper/node-browsers:${{ env.PIPER_version }}
           docker push ppiper/node-browsers:${{ env.PIPER_version }}
-          docker push ppiper/node-browsers:${{ env.PIPER_version }}-node12
-
       - uses: SAP/project-piper-action@master
         with:
           piper-version: latest

.github/workflows/release.yml

@@ -1 +1,2 @@
 test-project
+.vscode

.gitignore

@@ -1,5 +1,6 @@
-# node-10 is LTS and required for sap approuter. EOL: 2021-04-01
-FROM node:10-buster
+ARG BASE_IMAGE_TAG
+
+FROM node:$BASE_IMAGE_TAG
 
 RUN apt-get update && \
     apt-get install -y chromium firefox-esr xvfb libxi6 libgbm1 libgconf-2-4 openjdk-11-jre && \

.travis.yml

@@ -20,22 +20,26 @@ This image is published to Docker Hub and can be pulled via the command
 docker pull ppiper/node-browsers
 ```
 
-The default tag contains node 10 due to compatibility reasons with approuter.
+The default tag `latest` contains node 10 for compatibility reasons with approuter, which is a Maintenance LTS and will be end of life after 2021-04-30.
 
-For node 12, use the tag `node12`:
+For node-12 or node-14, use the tag `12-buster` or `14-buster`:
 
 ```
-docker pull ppiper/node-browsers:node12
+docker pull ppiper/node-browsers:12-buster
+docker pull ppiper/node-browsers:14-buster
 ```
 
 ## Build
 
 To build this image locally, open a terminal in the directory of the Dockerfile and run
 
 ```
-docker build -t ppiper/node-browsers .
+docker build --build-arg=BASE_IMAGE_TAG=10-buster -t ppiper/node-browsers .
 ```
 
+Where the `BASE_IMAGE_TAG=10-buster` build argument can be replaced with `BASE_IMAGE_TAG=12-buster` or `BASE_IMAGE_TAG=14-buster`.
+The given tag **must** exist in the [node](https://hub.docker.com/_/node) base image **and** use Debian GNU/Linux.
+
 ## Usage
 
 See this [blog post](https://blogs.sap.com/2017/12/11/sap-s4hana-cloud-sdk-end-to-end-tests-against-secured-applications/) for usage of this image in a Jenkins pipeline based on `ppiper/jenkins-master`.

Dockerfile

@@ -1,12 +1,13 @@
 #!/bin/bash -ex
 
-DOCKERFILE_PATH=${1:-.}
+TAG=${1:-.}
 
 # Start a local registry, to which we push the images built in this test, and from which they will be consumed in the test
 docker run -d -p 5000:5000 --restart always --name registry registry:2 || true
 
-docker build -t localhost:5000/ppiper/node-browsers:latest ${DOCKERFILE_PATH}
-docker tag localhost:5000/ppiper/node-browsers:latest ppiper/node-browsers:latest
+echo Testing version $TAG
+
+docker build --build-arg=BASE_IMAGE_TAG=${TAG} -t localhost:5000/ppiper/node-browsers:latest .
 docker push localhost:5000/ppiper/node-browsers:latest
 
 git clone https://github.com/piper-validation/cloud-s4-sdk-book.git -b validate-node-browsers test-project