Support node 12 (#8)

Author: fwilhe

.travis.yml

@@ -5,4 +5,4 @@ branches:
 language: minimal
 services:
 - docker
-script: chmod +x runTests.sh && ./runTests.sh
+script: chmod +x runTests.sh && ./runTests.sh . && ./runTests.sh node12

Dockerfile

@@ -1,5 +1,5 @@
 # node-10 is LTS and required for sap approuter. EOL: 2021-04-01
-FROM node:10-stretch 
+FROM node:10-stretch
 
 RUN apt-get update && \
     apt-get install -y chromium=70.0.3538.110-1~deb9u1 firefox-esr xvfb libxi6 libgconf-2-4 default-jre && \

README.md

@@ -1,6 +1,6 @@
 # Node Browsers Image
 
-This [_Dockerfile_](https://docs.docker.com/engine/reference/builder/) can be used in _Continuous Delivery_ (CD) pipelines for SAP development projects. 
+This [_Dockerfile_](https://docs.docker.com/engine/reference/builder/) can be used in _Continuous Delivery_ (CD) pipelines for SAP development projects.
 The image is optimized for use with project ["Piper"](https://github.com/SAP/jenkins-library) on [Jenkins](https://jenkins.io/).
 Docker containers simplify your CD tool setup, encapsulating tools and environments that are required to execute pipeline steps.
 
@@ -20,6 +20,14 @@ This image is published to Docker Hub and can be pulled via the command
 docker pull ppiper/node-browsers
 ```
 
+The default tag contains node 10 due to compatibility reasons with approuter.
+
+For node 12, use the tag `node12`:
+
+```
+docker pull ppiper/node-browsers:node12
+```
+
 ## Build
 
 To build this image locally, open a terminal in the directory of the Dockerfile and run

node12/Dockerfile

@@ -0,0 +1,11 @@
+FROM node:12-stretch
+
+RUN apt-get update && \
+    apt-get install -y chromium firefox-esr xvfb libxi6 libgconf-2-4 default-jre && \
+    rm -rf /var/lib/apt/lists/* /var/cache/apt/*
+
+RUN ln -s /usr/bin/chromium /usr/bin/google-chrome
+
+RUN npm config set @sap:registry https://npm.sap.com --global
+
+USER node

runTests.sh

@@ -1,9 +1,11 @@
 #!/bin/bash -ex
 
+DOCKERFILE_PATH=${1:-.}
+
 # Start a local registry, to which we push the images built in this test, and from which they will be consumed in the test
 docker run -d -p 5000:5000 --restart always --name registry registry:2 || true
 
-docker build -t localhost:5000/ppiper/node-browsers:latest .
+docker build -t localhost:5000/ppiper/node-browsers:latest ${DOCKERFILE_PATH}
 docker tag localhost:5000/ppiper/node-browsers:latest ppiper/node-browsers:latest
 docker push localhost:5000/ppiper/node-browsers:latest