Skip to content

(ExternalName) KymaModule Add full external name support #320

@enrico-kaack-comp

Description

@enrico-kaack-comp

Problem

KymaModule MR has no support for external name now.
We need to set it during Create and use it for matching during observe.

First evaluate if KymaModule can have external name support since it maps the MR to one cr in the Kyma Cluster. It might not need external-name support for the export/import functionality.

NOTE: follow the external-name ADR here https://github.com/SAP/crossplane-provider-btp/blob/main/docs/development/external-name-handling.md

Context

During Create external-name is set to forProvider.name. Kyma CR contains a list of modules in this cluster, one KymaModule is only mapped into this list. There is no unique key besides the module name. Every module can only exist once with one channel specified. Choosing a forProvider.name is a parameter and unique key.

Acceptance Criteria

  • Create sets the external-name to the external identifier (either an id or a composite key that is used for later matching)
  • Observe uses the external-name annotation as primary matching key so the initial observe would match an existing resource even if it was not created in a previous reconcile of the provider
  • Unit test tests the external-name matching behaviour

Metadata

Metadata

Assignees

Labels

BTPBTP Provider

Type

Projects

Status

Done

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions