Skip to content

Commit 7d805e1

Browse files
committed
8380222: Refactor test/jdk/java/lang/Character TestNG tests to JUnit
Reviewed-by: jlu, bpb, liach, iris
1 parent b6de5ae commit 7d805e1

2 files changed

Lines changed: 32 additions & 32 deletions

File tree

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2023, 2026, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -21,17 +21,16 @@
2121
* questions.
2222
*/
2323

24-
import org.testng.annotations.Test;
25-
26-
import static org.testng.Assert.assertEquals;
27-
import static org.testng.Assert.fail;
24+
import org.junit.jupiter.api.Test;
25+
import static org.junit.jupiter.api.Assertions.assertEquals;
26+
import static org.junit.jupiter.api.Assertions.fail;
2827

2928
/**
3029
* @test
3130
* @bug 8302877
3231
* @summary Provides exhaustive verification of Character.toUpperCase and Character.toLowerCase
3332
* for all code points in the latin1 range 0-255.
34-
* @run testng Latin1CaseConversion
33+
* @run junit Latin1CaseConversion
3534
*/
3635
public class Latin1CaseConversion {
3736

@@ -44,49 +43,49 @@ public void shouldUpperCaseAndLowerCaseLatin1() {
4443
if (c < 0x41) { // Before A
4544
assertUnchanged(upper, lower, c);
4645
} else if (c <= 0x5A) { // A-Z
47-
assertEquals(upper, c);
48-
assertEquals(lower, c + 32);
46+
assertEquals(c, upper);
47+
assertEquals(c + 32, lower);
4948
} else if (c < 0x61) { // Between Z and a
5049
assertUnchanged(upper, lower, c);
5150
} else if (c <= 0x7A) { // a-z
52-
assertEquals(upper, c - 32);
53-
assertEquals(lower, c);
51+
assertEquals(c - 32, upper);
52+
assertEquals(c, lower);
5453
} else if (c < 0xB5) { // Between z and Micro Sign
5554
assertUnchanged(upper, lower, c);
5655
} else if (c == 0xB5) { // Special case for Micro Sign
57-
assertEquals(upper, 0x39C);
58-
assertEquals(lower, c);
56+
assertEquals(0x39C, upper);
57+
assertEquals(c, lower);
5958
} else if (c < 0xC0) { // Between my and A-grave
6059
assertUnchanged(upper, lower, c);
6160
} else if (c < 0xD7) { // A-grave - O with Diaeresis
62-
assertEquals(upper, c);
63-
assertEquals(lower, c + 32);
61+
assertEquals(c, upper);
62+
assertEquals(c + 32, lower);
6463
} else if (c == 0xD7) { // Multiplication
6564
assertUnchanged(upper, lower, c);
6665
} else if (c <= 0xDE) { // O with slash - Thorn
67-
assertEquals(upper, c);
68-
assertEquals(lower, c + 32);
66+
assertEquals(c, upper);
67+
assertEquals(c + 32, lower);
6968
} else if (c == 0xDF) { // Sharp s
7069
assertUnchanged(upper, lower, c);
7170
} else if (c < 0xF7) { // a-grave - divsion
72-
assertEquals(upper, c - 32);
73-
assertEquals(lower, c);
71+
assertEquals(c - 32, upper);
72+
assertEquals(c, lower);
7473
} else if (c == 0xF7) { // Division
7574
assertUnchanged(upper, lower, c);
7675
} else if (c < 0xFF) { // o with slash - thorn
77-
assertEquals(upper, c - 32);
78-
assertEquals(lower, c);
76+
assertEquals(c - 32, upper);
77+
assertEquals(c, lower);
7978
} else if (c == 0XFF) { // Special case for y with Diaeresis
80-
assertEquals(upper, 0x178);
81-
assertEquals(lower, c);
79+
assertEquals(0x178, upper);
80+
assertEquals(c, lower);
8281
} else {
8382
fail("Uncovered code point: " + Integer.toHexString(c));
8483
}
8584
}
8685
}
8786

8887
private static void assertUnchanged(int upper, int lower, int c) {
89-
assertEquals(upper, c);
90-
assertEquals(lower, c);
88+
assertEquals(c, upper);
89+
assertEquals(c, lower);
9190
}
9291
}

test/jdk/java/lang/Character/UnicodeBlock/NumberEntities.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2015, 2026, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -28,31 +28,32 @@
2828
* of Character.UnicodeBlock constants. Also checks the size of
2929
* Character.UnicodeScript's "aliases" map.
3030
* @modules java.base/java.lang:open
31-
* @run testng NumberEntities
31+
* @run junit NumberEntities
3232
*/
3333

34-
import static org.testng.Assert.assertEquals;
35-
import org.testng.annotations.Test;
36-
3734
import java.lang.reflect.Field;
3835
import java.util.Map;
3936

40-
@Test
37+
import org.junit.jupiter.api.Test;
38+
import static org.junit.jupiter.api.Assertions.assertEquals;
39+
4140
public class NumberEntities {
41+
@Test
4242
public void test_UnicodeBlock_NumberEntities() throws Throwable {
4343
// The number of entries in Character.UnicodeBlock.map.
4444
// See src/java.base/share/classes/java/lang/Character.java
4545
Field n = Character.UnicodeBlock.class.getDeclaredField("NUM_ENTITIES");
4646
Field m = Character.UnicodeBlock.class.getDeclaredField("map");
4747
n.setAccessible(true);
4848
m.setAccessible(true);
49-
assertEquals(((Map)m.get(null)).size(), n.getInt(null));
49+
assertEquals(n.getInt(null), ((Map)m.get(null)).size());
5050
}
51+
@Test
5152
public void test_UnicodeScript_aliases() throws Throwable {
5253
// The number of entries in Character.UnicodeScript.aliases.
5354
// See src/java.base/share/classes/java/lang/Character.java
5455
Field aliases = Character.UnicodeScript.class.getDeclaredField("aliases");
5556
aliases.setAccessible(true);
56-
assertEquals(((Map)aliases.get(null)).size(), Character.UnicodeScript.UNKNOWN.ordinal() + 1);
57+
assertEquals(Character.UnicodeScript.UNKNOWN.ordinal() + 1, ((Map)aliases.get(null)).size());
5758
}
5859
}

0 commit comments

Comments
 (0)