Skip to content

Commit e7c3b57

Browse files
committed
Fixes requested for pull request
- Grafana was automatically adding the current values of variables in the JSON code the way we were exporting it. Removed the values from alldashboard - Ensured all Inspector with hidden variable would always have a default values not generating Grafana missing variable error : could have been confusing for the user - Reset the default port of the server to 8080. However the new bridge server still have 8043 as default port
1 parent 01f6d5f commit e7c3b57

6 files changed

Lines changed: 24 additions & 61 deletions

File tree

deploy/infrabox/grafana/dashboards/build_inspector.json

Lines changed: 12 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -190,40 +190,23 @@
190190
"templating": {
191191
"list": [
192192
{
193-
"allValue": null,
194-
"current": {
195-
"text": "0006fa7e-b193-4dd2-a746-6c6be16f7d8c",
196-
"value": "0006fa7e-b193-4dd2-a746-6c6be16f7d8c"
197-
},
193+
"allValue": null,
194+
"datasource": "infrabox",
198195
"hide": 2,
199196
"includeAll": false,
200197
"label": "",
201198
"multi": false,
202199
"name": "bid",
203-
"options": [
204-
{
205-
"selected": true,
206-
"text": "0006fa7e-b193-4dd2-a746-6c6be16f7d8c",
207-
"value": "0006fa7e-b193-4dd2-a746-6c6be16f7d8c"
208-
},
209-
{
210-
"selected": false,
211-
"text": "0009ad79-6814-44c4-b33b-66326af7e849",
212-
"value": "0009ad79-6814-44c4-b33b-66326af7e849"
213-
},
214-
{
215-
"selected": false,
216-
"text": "00225b05-6417-49d6-846a-6aab6a105695",
217-
"value": "00225b05-6417-49d6-846a-6aab6a105695"
218-
},
219-
{
220-
"selected": false,
221-
"text": "005d6f95-68d7-41d3-88a9-8c323eb66f4f",
222-
"value": "005d6f95-68d7-41d3-88a9-8c323eb66f4f"
223-
}
224-
],
225-
"query": "0006fa7e-b193-4dd2-a746-6c6be16f7d8c,0009ad79-6814-44c4-b33b-66326af7e849,00225b05-6417-49d6-846a-6aab6a105695,005d6f95-68d7-41d3-88a9-8c323eb66f4f",
226-
"type": "custom"
200+
"options": [],
201+
"query": "SELECT id FROM build LIMIT 1",
202+
"refresh": 1,
203+
"regex": "",
204+
"sort": 0,
205+
"tagValuesQuery": "",
206+
"tags": [],
207+
"tagsQuery": "",
208+
"type": "query",
209+
"useTags": false
227210
}
228211
]
229212
},

deploy/infrabox/grafana/dashboards/cluster_inspector.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -753,11 +753,6 @@
753753
"list": [
754754
{
755755
"allValue": null,
756-
"current": {
757-
"tags": [],
758-
"text": "eu-de-2",
759-
"value": "eu-de-2"
760-
},
761756
"datasource": "infrabox",
762757
"hide": 0,
763758
"includeAll": false,

deploy/infrabox/grafana/dashboards/job_inspector.json

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -480,24 +480,22 @@
480480
"list": [
481481
{
482482
"allValue": null,
483-
"current": {
484-
"text": "7ee5fa36-deca-4e32-9cb8-a8ee64ca92db",
485-
"value": "7ee5fa36-deca-4e32-9cb8-a8ee64ca92db"
486-
},
483+
"datasource": "infrabox",
487484
"hide": 2,
488485
"includeAll": false,
489486
"label": "",
490487
"multi": false,
491488
"name": "id",
492-
"options": [
493-
{
494-
"selected": true,
495-
"text": "7ee5fa36-deca-4e32-9cb8-a8ee64ca92db",
496-
"value": "7ee5fa36-deca-4e32-9cb8-a8ee64ca92db"
497-
}
498-
],
499-
"query": "7ee5fa36-deca-4e32-9cb8-a8ee64ca92db",
500-
"type": "custom"
489+
"options": [],
490+
"query": "SELECT id FROM job LIMIT 1",
491+
"refresh": 1,
492+
"regex": "",
493+
"sort": 0,
494+
"tagValuesQuery": "",
495+
"tags": [],
496+
"tagsQuery": "",
497+
"type": "query",
498+
"useTags": false
501499
}
502500
]
503501
},

deploy/infrabox/grafana/dashboards/node_inspector.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -849,10 +849,6 @@
849849
"list": [
850850
{
851851
"allValue": null,
852-
"current": {
853-
"text": "k8s-ib-ha-worker-002",
854-
"value": "k8s-ib-ha-worker-002"
855-
},
856852
"datasource": "infrabox",
857853
"hide": 0,
858854
"includeAll": false,

deploy/infrabox/grafana/dashboards/project_inspector.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1024,10 +1024,6 @@
10241024
"list": [
10251025
{
10261026
"allValue": null,
1027-
"current": {
1028-
"text": "hanalite-releasepack",
1029-
"value": "hanalite-releasepack"
1030-
},
10311027
"datasource": "infrabox",
10321028
"hide": 0,
10331029
"includeAll": false,
@@ -1047,11 +1043,6 @@
10471043
},
10481044
{
10491045
"allValue": "'%'",
1050-
"current": {
1051-
"tags": [],
1052-
"text": "calico",
1053-
"value": "calico"
1054-
},
10551046
"datasource": "infrabox",
10561047
"hide": 0,
10571048
"includeAll": true,

src/metrics/collector_server/server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ def main():
165165
get_env('INFRABOX_DATABASE_PASSWORD')
166166
get_env('INFRABOX_DATABASE_HOST')
167167
get_env('INFRABOX_DATABASE_PORT')
168-
server_port = os.environ.get('INFRABOX_PORT', 8043)
168+
server_port = os.environ.get('INFRABOX_PORT', 8080)
169169

170170
# Copied from review.py, could be changed over time
171171
conn = connect_db()

0 commit comments

Comments
 (0)