Skip to content

Commit a42d327

Browse files
authored
Merge pull request #576 from chengshifan/disable-managed-prometheus
chore: disable managed prometheus by default
2 parents e8a1a5b + 8408a3c commit a42d327

4 files changed

Lines changed: 9 additions & 3 deletions

File tree

src/services/gcp/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ RUN dep ensure
1313
RUN ./tmp/build/build.sh
1414

1515
FROM alpine:3.7
16-
ENV CLOUD_SDK_VERSION 330.0.0
16+
ENV CLOUD_SDK_VERSION 408.0.0
1717

1818
ENV PATH /google-cloud-sdk/bin:$PATH
1919

src/services/gcp/infrabox-service-gcp/templates/crd.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ metadata:
44
name: gkeclusters.gcp.service.infrabox.net
55
spec:
66
group: gcp.service.infrabox.net
7-
versions:
7+
versions:
88
- name: v1alpha1
99
served: true
1010
storage: true
@@ -50,6 +50,8 @@ spec:
5050
type: string
5151
clusterCidr:
5252
type: string
53+
enableManagedPrometheus:
54+
type: boolean
5355
status:
5456
x-kubernetes-preserve-unknown-fields: true
5557
names:

src/services/gcp/pkg/apis/gcp/v1alpha1/types.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ type GKEClusterSpec struct {
3030
Zone string `json:"zone"`
3131
ServiceCidr string `json:"serviceCidr,omitempty"`
3232
ClusterCidr string `json:"clusterCidr,omitempty"`
33+
EnableManagedPrometheus bool `json:"enableManagedPrometheus,omitempty"`
3334
}
3435

3536
type GKEClusterStatus struct {

src/services/gcp/pkg/stub/handler.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,9 @@ func createCluster(cr *v1alpha1.GKECluster, log *logrus.Entry) (*v1alpha1.GKEClu
223223
args = append(args, "--enable-private-nodes")
224224
args = append(args, "--master-ipv4-cidr", finalCIDR)
225225
args = append(args, "--enable-master-authorized-networks")
226+
if !cr.Spec.EnableManagedPrometheus {
227+
args = append(args, "--no-enable-managed-prometheus")
228+
}
226229
master_authorized_networks := os.Getenv("ALLOW_IPS")
227230
if master_authorized_networks == "" {
228231
master_authorized_networks = "0.0.0.0/0"
@@ -1241,7 +1244,7 @@ func updateClusterFirewall(cluster *RemoteCluster, log *logrus.Entry) error {
12411244
err = fmt.Errorf("failed to update firewall rule for cluster %s: %v", cluster.Name, err)
12421245
log.Error(err)
12431246
return err
1244-
}
1247+
}
12451248
return nil
12461249
}
12471250
log.Warningf("MasterIpv4CidrBlock fetching failed for cluster %s", cluster.Name)

0 commit comments

Comments
 (0)