Renaming methods to be clearer

Author: Razmo99

src/PowerShellEditorServices/Services/PowerShell/Refactoring/IterativeFunctionVistor.cs

@@ -30,7 +30,7 @@ public IterativeFunctionRename(string OldName, string NewName, int StartLineNumb
             this.StartColumnNumber = StartColumnNumber;
             this.ScriptAst = ScriptAst;
 
-            Ast Node = Utilities.GetAstNodeByLineAndColumn(StartLineNumber, StartColumnNumber, ScriptAst,
+            Ast Node = Utilities.GetAstAtPositionOfType(StartLineNumber, StartColumnNumber, ScriptAst,
             typeof(FunctionDefinitionAst), typeof(CommandAst));
 
             if (Node != null)

src/PowerShellEditorServices/Services/PowerShell/Refactoring/IterativeVariableVisitor.cs

@@ -43,7 +43,7 @@ public IterativeVariableRename(string NewName, int StartLineNumber, int StartCol
                     isParam = true;
                     Ast parent = Node;
                     // Look for a target function that the parameterAst will be within if it exists
-                    parent = Utilities.LookForParentOfType(parent, typeof(FunctionDefinitionAst));
+                    parent = Utilities.GetAstParentOfType(parent, typeof(FunctionDefinitionAst));
                     if (parent != null)
                     {
                         TargetFunction = (FunctionDefinitionAst)parent;
@@ -60,7 +60,7 @@ public static Ast GetVariableTopAssignment(int StartLineNumber, int StartColumnN
         {
 
             // Look up the target object
-            Ast node = Utilities.GetAstNodeByLineAndColumn(StartLineNumber, StartColumnNumber,
+            Ast node = Utilities.GetAstAtPositionOfType(StartLineNumber, StartColumnNumber,
             ScriptAst, typeof(VariableExpressionAst), typeof(CommandParameterAst), typeof(StringConstantExpressionAst));
 
             string name = node switch
@@ -77,7 +77,7 @@ public static Ast GetVariableTopAssignment(int StartLineNumber, int StartColumnN
             if (node is StringConstantExpressionAst)
             {
                 Ast parent = node;
-                parent = Utilities.LookForParentOfType(parent, typeof(AssignmentStatementAst));
+                parent = Utilities.GetAstParentOfType(parent, typeof(AssignmentStatementAst));
                 if (parent is not null and AssignmentStatementAst assignmentStatementAst)
                 {
                     splatAssignment = (VariableExpressionAst)assignmentStatementAst.Left.Find(
@@ -181,7 +181,7 @@ internal static Ast GetAstParentScope(Ast node)
         {
             Ast parent = node;
             // Walk backwards up the tree looking for a ScriptBLock of a FunctionDefinition
-            parent = Utilities.LookForParentOfType(parent, typeof(ScriptBlockAst), typeof(FunctionDefinitionAst));
+            parent = Utilities.GetAstParentOfType(parent, typeof(ScriptBlockAst), typeof(FunctionDefinitionAst));
             if (parent is ScriptBlockAst && parent.Parent != null && parent.Parent is FunctionDefinitionAst)
             {
                 parent = parent.Parent;

src/PowerShellEditorServices/Services/PowerShell/Refactoring/Utilities.cs

@@ -11,7 +11,7 @@ namespace Microsoft.PowerShell.EditorServices.Refactoring
     internal class Utilities
     {
 
-        public static Ast GetAstNodeByLineAndColumn(int StartLineNumber, int StartColumnNumber, Ast ScriptAst, params Type[] type)
+        public static Ast GetAstAtPositionOfType(int StartLineNumber, int StartColumnNumber, Ast ScriptAst, params Type[] type)
         {
             Ast result = null;
             result = ScriptAst.Find(ast =>
@@ -27,7 +27,7 @@ public static Ast GetAstNodeByLineAndColumn(int StartLineNumber, int StartColumn
             return result;
         }
 
-        public static Ast LookForParentOfType(Ast ast, params Type[] type)
+        public static Ast GetAstParentOfType(Ast ast, params Type[] type)
         {
             Ast parent = ast;
             // walk backwards till we hit a parent of the specified type or return null
@@ -46,7 +46,7 @@ public static Ast LookForParentOfType(Ast ast, params Type[] type)
         public static FunctionDefinitionAst GetFunctionDefByCommandAst(string OldName, int StartLineNumber, int StartColumnNumber, Ast ScriptFile)
         {
             // Look up the targetted object
-            CommandAst TargetCommand = (CommandAst)Utilities.GetAstNodeByLineAndColumn(StartLineNumber, StartColumnNumber, ScriptFile
+            CommandAst TargetCommand = (CommandAst)Utilities.GetAstAtPositionOfType(StartLineNumber, StartColumnNumber, ScriptFile
             , typeof(CommandAst));
 
             if (TargetCommand.GetCommandName().ToLower() != OldName.ToLower())