refactor(song): update song entity and DTO to enforce maximum length constraints

- Introduced maximum length constraints for title, originalAuthor, and description fields in the Song entity using UPLOAD_CONSTANTS.
- Simplified the songPreviewFromSongDocumentWithUser function to default the description to an empty string if not provided.
- Updated the SongPreview DTO to reflect the new maximum length validations for title, originalAuthor, and description fields.

Author: tomast1337

apps/backend/src/song/song.util.ts

@@ -106,19 +106,14 @@ export function uploadSongDtoFromSongDocument(song: SongEntity): UploadSongDto {
 export function songPreviewFromSongDocumentWithUser(
   song: SongPreviewSource,
 ): SongPreviewDto {
-  const description =
-    song.description?.trim() && song.description.trim().length > 0
-      ? song.description
-      : ' ';
-
   return {
     publicId: song.publicId,
     uploader: {
       username: song.uploader.username,
       profileImage: song.uploader.profileImage,
     },
     title: song.title,
-    description,
+    description: song.description ?? '',
     originalAuthor: song.originalAuthor ?? '',
     duration: song.stats.duration,
     noteCount: song.stats.noteCount,

packages/database/src/song/song.entity.ts

@@ -1,6 +1,7 @@
 import { Prop, Schema, SchemaFactory } from '@nestjs/mongoose';
 import { Document, Types } from 'mongoose';
 
+import { UPLOAD_CONSTANTS } from '@nbw/config';
 import type {
   CategoryType,
   LicenseType,
@@ -73,13 +74,25 @@ export class Song {
   @Prop({ type: Boolean, required: true, default: true })
   allowDownload: boolean;
 
-  @Prop({ type: String, required: true })
+  @Prop({
+    type: String,
+    required: true,
+    maxlength: UPLOAD_CONSTANTS.title.maxLength,
+  })
   title: string;
 
-  @Prop({ type: String, required: false })
+  @Prop({
+    type: String,
+    required: false,
+    maxlength: UPLOAD_CONSTANTS.originalAuthor.maxLength,
+  })
   originalAuthor: string;
 
-  @Prop({ type: String, required: false })
+  @Prop({
+    type: String,
+    required: false,
+    maxlength: UPLOAD_CONSTANTS.description.maxLength,
+  })
   description: string;
 
   // SONG FILE ATTRIBUTES (Populated from NBS file - immutable)

packages/validation/src/song/SongPreview.dto.ts

@@ -1,5 +1,7 @@
 import { z } from 'zod';
 
+import { UPLOAD_CONSTANTS } from '@nbw/config';
+
 import type { VisibilityType } from './uploadMeta.js';
 
 const songPreviewUploaderSchema = z.object({
@@ -10,9 +12,9 @@ const songPreviewUploaderSchema = z.object({
 export const songPreviewDtoSchema = z.object({
   publicId: z.string().min(1),
   uploader: songPreviewUploaderSchema,
-  title: z.string().min(1).max(128),
-  description: z.string().min(1),
-  originalAuthor: z.string().min(1).max(64),
+  title: z.string().min(1).max(UPLOAD_CONSTANTS.title.maxLength),
+  description: z.string().max(UPLOAD_CONSTANTS.description.maxLength),
+  originalAuthor: z.string().max(UPLOAD_CONSTANTS.originalAuthor.maxLength),
   duration: z.number().min(0),
   noteCount: z.number().int().min(0),
   thumbnailUrl: z.url(),