metadata: avoid double-free when validation of provider metadata fails

zandbelt · zandbelt · commit 4543c6ca7d11 · 2025-11-17T09:31:23.000+01:00
Signed-off-by: Hans Zandbelt &lt;hans.zandbelt@openidc.com&gt;
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,6 @@
+11/17/2025
+- metadata: avoid double-free when validation of provider metadata fails
+
 11/14/2025
 - test: add test/test_proto.c and migrate proto tests from test.c
 
diff --git a/src/metadata.c b/src/metadata.c
@@ -753,7 +753,6 @@ apr_byte_t oidc_metadata_provider_retrieve(request_rec *r, oidc_cfg_t *cfg, cons
 
 	/* check to see if it is valid metadata */
 	if (oidc_metadata_provider_is_valid(r, cfg, *j_metadata, issuer) == FALSE) {
-		json_decref(*j_metadata);
 		return FALSE;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -753,7 +753,6 @@ apr_byte_t oidc_metadata_provider_retrieve(request_rec r, oidc_cfg_t cfg, cons`
`753`	`753`
`754`	`754`	`/* check to see if it is valid metadata */`
`755`	`755`	`if (oidc_metadata_provider_is_valid(r, cfg, *j_metadata, issuer) == FALSE) {`
`756`		`- json_decref(*j_metadata);`
`757`	`756`	`return FALSE;`
`758`	`757`	`}`
`759`	`758`