feat: added metrics for P99 and slow command statistics#3071
Open
Mixficsol wants to merge 2 commits intoOpenAtomFoundation:3.5from
Open
feat: added metrics for P99 and slow command statistics#3071Mixficsol wants to merge 2 commits intoOpenAtomFoundation:3.5from
Mixficsol wants to merge 2 commits intoOpenAtomFoundation:3.5from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Mixficsol
force-pushed
the
feature/add_p99
branch
6 times, most recently
from
629ecc0 to
99e4623
Compare
Mixficsol
force-pushed
the
feature/add_p99
branch
from
99e4623 to
1f046c4
Compare
YuCai18
reviewed
Jul 14, 2025
| "command_p99_info": { | ||
| Parser: ®exParser{ | ||
| name: "command_p99_info", | ||
| reg: regexp.MustCompile(`Command:\s*(?P<cmd>\S+)\s*\r?\n(?:.*\r?\n)*?TP99 ms:\s*(?P<tp99>[\d.]+)\s*\r?\n.*?TP999 ms:\s*(?P<tp999>[\d.]+)\s*\r?\n.*?TP9999 ms:\s*(?P<tp9999>[\d.]+)`), |
Collaborator
There was a problem hiding this comment.
多层嵌套匹配效率低，建议改为更简单的非贪婪匹配：Command:\s*(?P<cmd>\S+)[\s\S]*?TP99 ms:\s*(?P<tp99>[\d.]+)[\s\S]*?TP999 ms:\s*(?P<tp999>[\d.]+)[\s\S]*?TP9999 ms:\s*(?P<tp9999>[\d.]+)
| "slow_command_info": { | ||
| Parser: ®exParser{ | ||
| name: "slow_command_info", | ||
| reg: regexp.MustCompile(`(?P<cmd>\S+):slow_count=(?P<slow_count>\d+)`), |
Collaborator
There was a problem hiding this comment.
写法\S+ 会去匹配任意非空白字符（包括冒号 :），建议改为[^\s:]+
| } else { | ||
| tmp_stream << "Command: " << command_name << "\r\n"; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
对于P99理论上至少需要100个样本才有意义。建议增加一个判断，若total_count < 100就continue。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.