Fixed some potential bugs

Author: YuCai18

src/pika_admin.cc

@@ -1541,6 +1541,9 @@ void InfoCmd::InfoCommandP99(std::string& info) {
         tmp_stream << "Command: " << command_name << "\r\n";
       }
 
+      if (total_count < 100) {
+        continue;
+      }
       double tp99_threshold = total_count * 0.99;
       double tp999_threshold = total_count * 0.999;
       double tp9999_threshold = total_count * 0.9999;

src/pika_cmd_table_manager.cc

@@ -82,15 +82,12 @@ prometheus::Histogram& PikaCmdTableManager::GetHistogram(const std::string& opt)
     data_copy = data_; 
   }
 
-  {
-    std::shared_lock<std::shared_mutex> read_lock(histograms_mutex_);
-    auto it = data_copy->histograms.find(opt);
-    if (it != data_copy->histograms.end()) {
-      return *(it->second);
-    }
+  std::unique_lock<std::shared_mutex> write_lock(histograms_mutex_);
+  auto it = data_copy->histograms.find(opt);
+  if (it != data_copy->histograms.end()) {
+    return *(it->second);
   }
 
-  std::unique_lock<std::shared_mutex> write_lock(histograms_mutex_);
   auto& new_histogram = data_copy->family->Add(
       {{"command", opt}},
       prometheus::Histogram::BucketBoundaries{0.5, 1, 2, 3, 5, 7, 10, 15, 20, 30, 40, 50, 65, 75, 85, 100, 125, 140, 150, 160, 175, 185, 200, 300, 400, 500, 750, 1000, 2000, 5000, 10000}
@@ -109,19 +106,7 @@ std::shared_ptr<HistogramData> PikaCmdTableManager::GetHistogramsData() {
 }
 
 void PikaCmdTableManager::UpdateSlowCommandCount(const std::string& opt) {
-  {
-    std::shared_lock<std::shared_mutex> read_lock(slow_command_mutex_);
-    if (slow_command_count_.find(opt) != slow_command_count_.end()) {
-      slow_command_count_[opt].cmd_count.fetch_add(1);
-      return;
-    }
-  }
-
-  {
-    std::unique_lock<std::shared_mutex> write_lock(slow_command_mutex_);
-    slow_command_count_[opt]; 
-  }
-
+  std::unique_lock<std::shared_mutex> write_lock(slow_command_mutex_);
   slow_command_count_[opt].cmd_count.fetch_add(1);
 }
 

tools/pika_exporter/exporter/metrics/commandp99.go

@@ -12,7 +12,7 @@ var collectCommandP99Metrics = map[string]MetricConfig{
     "command_p99_info": {
         Parser: &regexParser{
             name: "command_p99_info",
-            reg: regexp.MustCompile(`Command:\s*(?P<cmd>\S+)\s*\r?\n(?:.*\r?\n)*?TP99 ms:\s*(?P<tp99>[\d.]+)\s*\r?\n.*?TP999 ms:\s*(?P<tp999>[\d.]+)\s*\r?\n.*?TP9999 ms:\s*(?P<tp9999>[\d.]+)`),
+            reg: regexp.MustCompile(`Command:\s*(?P<cmd>\S+)[\s\S]*?TP99 ms:\s*(?P<tp99>[\d.]+)[\s\S]*?TP999 ms:\s*(?P<tp999>[\d.]+)[\s\S]*?TP9999 ms:\s*(?P<tp9999>[\d.]+)`),
             Parser: &normalParser{},
         },
         MetricMeta: MetaDatas{

tools/pika_exporter/exporter/metrics/slowcommand.go

@@ -12,7 +12,7 @@ var collectSlowCommandMetrics = map[string]MetricConfig{
     "slow_command_info": {
         Parser: &regexParser{
             name: "slow_command_info",
-            reg: regexp.MustCompile(`(?P<cmd>\S+):slow_count=(?P<slow_count>\d+)`),
+            reg: regexp.MustCompile(`(?P<cmd>[^\s:]+):slow_count=(?P<slow_count>\d+)`),
             Parser: &normalParser{},
         },
         MetricMeta: MetaDatas{