modify

Author: Z-G-H1

conf/pika.conf

@@ -31,7 +31,7 @@ thread-pool-size : 12
 # This parameter is used to control whether to separate fast and slow commands.
 # When slow-cmd-pool is set to yes, fast and slow commands are separated.
 # When set to no, they are not separated.
-slow-cmd-pool : yes
+slow-cmd-pool : no
 
 # Enable thread pool borrowing mechanism, which allows threads to help each other when one pool is busy
 # and another is idle. This can improve resource utilization and reduce command latency under uneven load.
@@ -66,7 +66,7 @@ slow-cmd-thread-pool-size : 1
 admin-thread-pool-size : 2
 
 # Slow cmd list e.g. hgetall, mset
-slow-cmd-list : keys
+slow-cmd-list :
 
 # List of commands considered as administrative. These commands will be handled by the admin thread pool. Modify this list as needed.
 # Default commands: info, ping, monitor

src/pika_admin.cc

@@ -2730,7 +2730,7 @@ void ConfigCmd::ConfigSet(std::shared_ptr<DB> db) {
     g_pika_conf->SetThreadPoolSize(static_cast<int>(thread_pool_size));
     res_.AppendStringRaw("+OK\r\n");
   } else if (set_item == "slow-cmd-thread-pool-size") {
-    if (pstd::string2int(value.data(), value.size(), &ival) == 0 || ival <= 0 || ival > 1024) {
+    if (pstd::string2int(value.data(), value.size(), &ival) == 0 || ival <= 0 || ival > 24) {
       res_.AppendStringRaw("-ERR Invalid argument \'" + value + "\' for CONFIG SET 'slow-cmd-thread-pool-size'\r\n");
       return;
     }

src/pika_client_conn.cc

@@ -428,15 +428,6 @@ bool PikaClientConn::ReadCmdInCache(const net::RedisCmdArgsType& argv, const std
     time_stat_->process_done_ts_ = pstd::NowMicros();
     (*cmdstat_map)[argv[0]].cmd_count.fetch_add(1);
     (*cmdstat_map)[argv[0]].cmd_time_consuming.fetch_add(time_stat_->total_time());
-
-    uint64_t duration_us = time_stat_->total_time();
-    ThreadPoolMetrics* metrics = (task_pool_type_ == TaskPoolType::kSlowCmdPool)
-                                  ? g_pika_server->GetSlowPoolMetrics()
-                                  : g_pika_server->GetFastPoolMetrics();
-    if (metrics) {
-      metrics->RecordLatency(duration_us);
-      metrics->tasks_completed.fetch_add(1, std::memory_order_relaxed);
-    }
     resp_array.emplace_back(std::make_shared<std::string>(std::move(c_ptr->res().message())));
     TryWriteResp();
   }

src/pika_server.cc

@@ -836,7 +836,7 @@ void PikaServer::ScheduleClientPool(net::TaskFunc func, void* arg, bool is_slow_
     return;
   }
   // if slow cmd thread pool disabled
-  if(!g_pika_conf->slow_cmd_pool()) {
+  if (!g_pika_conf->slow_cmd_pool()) {
     pika_client_processor_->SchedulePool(func, arg);
     return;
   }