test: add test for SPOP response format compatibility

Author: Z-G-H1

tests/integration/network_stability_test.go

@@ -0,0 +1,57 @@
+package pika_integration
+
+import (
+	"net"
+	. "github.com/bsm/ginkgo/v2"
+	. "github.com/bsm/gomega"
+)
+
+var _ = Describe("Telnet", func() {
+	Describe("core dump fix", func() {
+		It("should handle empty commands without crashing (telnet core dump fix)", func() {
+			conn, err := net.Dial("tcp", SINGLEADDR)
+			Expect(err).NotTo(HaveOccurred())
+			defer conn.Close()
+
+			_, err = conn.Write([]byte("\n"))
+			Expect(err).NotTo(HaveOccurred())
+
+			_, err = conn.Write([]byte("*1\r\n$4\r\nPING\r\n"))
+			Expect(err).NotTo(HaveOccurred())
+
+			buf := make([]byte, 1024)
+			n, err := conn.Read(buf)
+			Expect(err).NotTo(HaveOccurred())
+			response := string(buf[:n])
+			Expect(response).To(ContainSubstring("+PONG"))
+
+			_, err = conn.Write([]byte("*2\r\n$4\r\nECHO\r\n$4\r\nTEST\r\n"))
+			Expect(err).NotTo(HaveOccurred())
+
+			n, err = conn.Read(buf)
+			Expect(err).NotTo(HaveOccurred())
+			response = string(buf[:n])
+			Expect(response).To(ContainSubstring("$4\r\nTEST"))
+		})
+
+		It("should handle multiple empty commands without crashing", func() {
+			conn, err := net.Dial("tcp", SINGLEADDR)
+			Expect(err).NotTo(HaveOccurred())
+			defer conn.Close()
+
+			for i := 0; i < 5; i++ {
+				_, err = conn.Write([]byte("\r\n"))
+				Expect(err).NotTo(HaveOccurred())
+			}
+
+			_, err = conn.Write([]byte("*1\r\n$4\r\nPING\r\n"))
+			Expect(err).NotTo(HaveOccurred())
+
+			buf := make([]byte, 1024)
+			n, err := conn.Read(buf)
+			Expect(err).NotTo(HaveOccurred())
+			response := string(buf[:n])
+			Expect(response).To(ContainSubstring("+PONG"))
+		})
+	})
+})

tests/unit/type/set.tcl

@@ -310,6 +310,31 @@ start_server {
         }
     }
 
+    test {SPOP response format for PHP Redis client compatibility} {
+        r del myset
+        r sadd myset "element1" "element2" "element3"
+        set single_pop [r spop myset]
+        assert {[lsearch {"element1" "element2" "element3"} $single_pop] >= 0}
+        
+        r del myset
+        r sadd myset "element1" "element2" "element3"
+        set single_array_pop [r spop myset 1]
+        assert_equal 1 [llength $single_array_pop]
+        assert {[lsearch {"element1" "element2" "element3"} [lindex $single_array_pop 0]] >= 0}
+        
+        r del myset
+        r sadd myset "element1" "element2" "element3"
+        set multi_pop [r spop myset 2]
+        assert_equal 2 [llength $multi_pop]
+        
+        r del emptyset
+        set empty_pop [r spop emptyset]
+        assert_equal {} $empty_pop
+        
+        set empty_array_pop [r spop emptyset 1]
+        assert_equal 0 [llength $empty_array_pop]
+    }
+
     test "SRANDMEMBER with <count> against non existing key" {
         r srandmember nonexisting_key 100
     } {}