fix: ai review bug 修复

Author: chenbt-hz

.gitignore

@@ -73,4 +73,5 @@ pkg
 # include codis fe javascript lib files
 !codis/cmd/fe/assets/**
 
-tests/tmp
+tests/tmp
+.claude

src/pika_server.cc

@@ -1241,6 +1241,9 @@ void PikaServer::AutoCompactRange() {
     struct timeval now;
     gettimeofday(&now, nullptr);
     int interval = g_pika_conf->incremental_compact_interval();
+    if (interval <= 0) {
+      return;
+    }
     if (last_incremental_compact_time_.tv_sec == 0 ||
         now.tv_sec - last_incremental_compact_time_.tv_sec >= interval) {
       gettimeofday(&last_incremental_compact_time_, nullptr);

src/storage/src/redis.cc

@@ -6,7 +6,6 @@
 #include <chrono>
 #include <sstream>
 #include <ctime>
-#include <thread>
 
 #include "rocksdb/env.h"
 
@@ -272,9 +271,9 @@ void SelectColumnFamilyHandles(const DataType& option_type, const ColumnFamilyTy
 Status Redis::LongestNotCompactionSstCompact(const DataType& option_type, std::vector<Status>* compact_result_vec,
                                               const ColumnFamilyType& type) {
   bool no_compact = false;
-  bool to_comapct = true;
-  if (!in_compact_flag_.compare_exchange_weak(no_compact, to_comapct, std::memory_order_relaxed,
-                                              std::memory_order_relaxed)) {
+  bool to_compact = true;
+  if (!in_compact_flag_.compare_exchange_strong(no_compact, to_compact, std::memory_order_relaxed,
+                                                std::memory_order_relaxed)) {
     return Status::Busy("compact running");
   }
 
@@ -465,8 +464,8 @@ Status Redis::IncrementalCompact(const DataType& option_type, std::vector<Status
   // 1. 并发控制
   bool no_compact = false;
   bool to_compact = true;
-  if (!in_compact_flag_.compare_exchange_weak(no_compact, to_compact, std::memory_order_relaxed,
-                                              std::memory_order_relaxed)) {
+  if (!in_compact_flag_.compare_exchange_strong(no_compact, to_compact, std::memory_order_relaxed,
+                                                std::memory_order_relaxed)) {
     return Status::Busy("compact running");
   }
   DEFER { in_compact_flag_.store(false); };
@@ -551,6 +550,9 @@ Status Redis::IncrementalCompact(const DataType& option_type, std::vector<Status
       if (!s.ok()) {
         LOG(WARNING) << "IncrementalCompact failed for file " << oldest_file
                      << ": " << s.ToString();
+        if (compact_result_vec) {
+          compact_result_vec->push_back(s);
+        }
         break;
       }
 
@@ -568,7 +570,7 @@ Status Redis::IncrementalCompact(const DataType& option_type, std::vector<Status
       processed++;
     }
 
-    if (compact_result_vec) {
+    if (compact_result_vec && (compact_result_vec->empty() || compact_result_vec->back().ok())) {
       compact_result_vec->push_back(Status::OK());
     }
   }

src/storage/src/redis.h

@@ -525,7 +525,7 @@ class Redis {
   rocksdb::WriteOptions default_write_options_;
   rocksdb::ReadOptions default_read_options_;
   rocksdb::CompactRangeOptions default_compact_range_options_;
-  std::atomic<bool> in_compact_flag_;
+  std::atomic<bool> in_compact_flag_{false};
   OBDSstListener listener_; // listening created sst file while compacting in OBD-compact
 
   // For Scan

src/storage/src/storage.cc

@@ -1697,7 +1697,7 @@ Status Storage::StartBGThread() {
 
 Status Storage::AddBGTask(const BGTask& bg_task) {
   bg_tasks_mutex_.lock();
-  if (bg_task.type == DataType::kAll) {
+  if (bg_task.operation == kCleanAll) {
     // if current task it is global compact,
     // clear the bg_tasks_queue_;
     std::queue<BGTask> empty_queue;