forked from ember-cli/eslint-plugin-ember
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathtemplate-no-this-in-template-only-components.js
More file actions
106 lines (102 loc) · 3.47 KB
/
template-no-this-in-template-only-components.js
File metadata and controls
106 lines (102 loc) · 3.47 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
const rule = require('../../../lib/rules/template-no-this-in-template-only-components');
const RuleTester = require('eslint').RuleTester;
const ruleTester = new RuleTester({
parser: require.resolve('ember-eslint-parser'),
parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
});
ruleTester.run('template-no-this-in-template-only-components', rule, {
valid: [
'<template>{{@foo}}</template>',
'<template>{{welcome-page}}</template>',
'<template><WelcomePage /></template>',
'<template><MyComponent @prop={{can "edit" @model}} /></template>',
'<template>{{my-component model=model}}</template>',
// Class components should not be flagged (not template-only)
'class MyComponent extends Component { <template>{{this.foo}}</template> }',
'class MyComponent extends Component { <template>{{this.bar}} {{this.baz}}</template> }',
],
invalid: [
{
code: '<template>{{this.foo}}</template>',
output: '<template>{{@foo}}</template>',
errors: [{ messageId: 'noThis' }],
},
{
code: '<template>{{my-component model=this.model}}</template>',
output: '<template>{{my-component model=@model}}</template>',
errors: [{ messageId: 'noThis' }],
},
{
code: '<template>{{my-component action=(action this.myAction)}}</template>',
output: '<template>{{my-component action=(action @myAction)}}</template>',
errors: [{ messageId: 'noThis' }],
},
{
code: '<template><MyComponent @prop={{can "edit" this.model}} /></template>',
output: '<template><MyComponent @prop={{can "edit" @model}} /></template>',
errors: [{ messageId: 'noThis' }],
},
{
code: '<template>{{input id=(concat this.elementId "-username")}}</template>',
output: null,
errors: [{ messageId: 'noThis' }],
},
],
});
const hbsRuleTester = new RuleTester({
parser: require.resolve('ember-eslint-parser/hbs'),
parserOptions: {
ecmaVersion: 2022,
sourceType: 'module',
},
});
hbsRuleTester.run('template-no-this-in-template-only-components', rule, {
valid: [
'{{welcome-page}}',
'<WelcomePage />',
'<MyComponent @prop={{can "edit" @model}} />',
'{{my-component model=model}}',
],
invalid: [
{
code: '{{my-component model=this.model}}',
output: '{{my-component model=@model}}',
errors: [
{
message:
"Usage of 'this' in path 'this.model' is not allowed in a template-only component. Use '@model' if it is a named argument.",
},
],
},
{
code: '{{my-component action=(action this.myAction)}}',
output: '{{my-component action=(action @myAction)}}',
errors: [
{
message:
"Usage of 'this' in path 'this.myAction' is not allowed in a template-only component. Use '@myAction' if it is a named argument.",
},
],
},
{
code: '<MyComponent @prop={{can "edit" this.model}} />',
output: '<MyComponent @prop={{can "edit" @model}} />',
errors: [
{
message:
"Usage of 'this' in path 'this.model' is not allowed in a template-only component. Use '@model' if it is a named argument.",
},
],
},
{
code: '{{input id=(concat this.elementId "-username")}}',
output: null,
errors: [
{
message:
"Usage of 'this' in path 'this.elementId' is not allowed in a template-only component. Use '@elementId' if it is a named argument.",
},
],
},
],
});