Address PR comments

Author: erdembayar

src/NuGet.Services.KeyVault/KeyVaultConfiguration.cs

@@ -18,7 +18,14 @@ public class KeyVaultConfiguration
         /// <summary>
         /// The constructor for keyvault configuration when using managed identities
         /// </summary>
-        public KeyVaultConfiguration(string vaultName, string clientId = null)
+        public KeyVaultConfiguration(string vaultName)
+            : this(vaultName, clientId : null)
+        { }
+
+        /// <summary>
+        /// The constructor for keyvault configuration when using managed identities
+        /// </summary>
+        public KeyVaultConfiguration(string vaultName, string clientId)
         {
             if (string.IsNullOrWhiteSpace(vaultName))
             {

src/NuGet.Services.KeyVault/KeyVaultConfigurationExtensions.cs

@@ -7,6 +7,7 @@
 using Azure.Identity;
 using Azure.Security.KeyVault.Secrets;
 using Microsoft.Extensions.Logging;
+using AzureSecurityKeyVaultSecret = Azure.Security.KeyVault.Secrets.KeyVaultSecret;
 
 namespace NuGet.Services.KeyVault
 {
@@ -39,9 +40,8 @@ public async Task<string> GetSecretAsync(string secretName)
 
         public async Task<string> GetSecretAsync(string secretName, ILogger logger)
         {
-            var response = await _keyVaultClient.Value.GetSecretAsync(secretName);
-            var secret = response.Value;
-            return secret.Value;
+            AzureSecurityKeyVaultSecret response = await _keyVaultClient.Value.GetSecretAsync(secretName);
+            return response.Value;
         }
 
         public async Task<ISecret> GetSecretObjectAsync(string secretName)
@@ -51,9 +51,8 @@ public async Task<ISecret> GetSecretObjectAsync(string secretName)
 
         public async Task<ISecret> GetSecretObjectAsync(string secretName, ILogger logger)
         {
-            var response = await _keyVaultClient.Value.GetSecretAsync(secretName);
-            var secret = response.Value;
-            return new KeyVaultSecret(secretName, secret.Value, secret.Properties.ExpiresOn);
+            AzureSecurityKeyVaultSecret response = await _keyVaultClient.Value.GetSecretAsync(secretName);
+            return new KeyVaultSecret(secretName, response.Value, response.Properties.ExpiresOn);
         }
 
         private SecretClient InitializeClient()
@@ -75,8 +74,13 @@ private SecretClient InitializeClient()
             {
                 credential = new ClientCertificateCredential(_configuration.TenantId, _configuration.ClientId, _configuration.Certificate);
             }
-            return new SecretClient(_configuration.GetKeyVaultUri(), credential);
+            return new SecretClient(GetKeyVaultUri(_configuration), credential);
         }
-    }
 
+        private Uri GetKeyVaultUri(KeyVaultConfiguration keyVaultConfiguration)
+        {
+            var uriString = $"https://{keyVaultConfiguration.VaultName}.vault.azure.net/";
+            return new Uri(uriString);
+        }
+    }
 }

src/NuGet.Services.KeyVault/KeyVaultReader.cs

@@ -8,9 +8,6 @@
   <ItemGroup>
     <PackageReference Include="Azure.Identity" Version="1.8.0" />
     <PackageReference Include="Azure.Security.KeyVault.Secrets" Version="4.4.0" />
-    <PackageReference Include="Microsoft.Azure.Services.AppAuthentication">
-      <Version>1.4.0</Version>
-    </PackageReference>
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions">
       <Version>2.2.0</Version>
     </PackageReference>