DevSkim warnings addressed. (#408)

agr · web-flow · commit 2e29011de5dd · 2023-05-25T16:58:42.000-07:00
* DevSkim warning suppressions.

* Removed code enabling TLS 1.2 (assuming by now it is enabled by default).

* Suppression that works with new devskim
diff --git a/build/common.ps1 b/build/common.ps1
@@ -151,7 +151,7 @@ Function Invoke-BuildStep {
         $completed = $false
 
         try {
-            Invoke-Command $Expression -ArgumentList $Arguments -ErrorVariable err
+            Invoke-Command $Expression -ArgumentList $Arguments -ErrorVariable err #DevSkim: ignore DS104456. Internal build tool called from our build scripts.
             $completed = $true
         }
         finally {
@@ -906,7 +906,7 @@ Function Install-PrivateBuildTools() {
     $commit = $env:PRIVATE_BUILD_TOOLS_COMMIT
 
     if (-Not $commit) {
-        $commit = '4b7460b2e08249e4c65307e5383dfba7fe4da8b7'
+        $commit = '4b7460b2e08249e4c65307e5383dfba7fe4da8b7' #DevSkim: ignore DS173237. Not a token/secret. It is a git commit hash.
     }
 
     if (-Not $repository) {
diff --git a/build/runcodeanalysis.ps1 b/build/runcodeanalysis.ps1
@@ -12,9 +12,6 @@ param (
     [string]$FxCopOutputDirectory
 )
 
-# Enable TLS 1.2 since GitHub requires it.
-[Net.ServicePointManager]::SecurityProtocol = [Net.ServicePointManager]::SecurityProtocol -bor [Net.SecurityProtocolType]::Tls12
-
 # To avoid repository dependencies, this script relies on the following assumptions:
 # - parent directory contains a single *.sln
 # - parent directory contains a build.ps1

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ Function Invoke-BuildStep {`
`151`	`151`	`$completed = $false`
`152`	`152`
`153`	`153`	`try {`
`154`		`- Invoke-Command $Expression -ArgumentList $Arguments -ErrorVariable err`
	`154`	`+ Invoke-Command $Expression -ArgumentList $Arguments -ErrorVariable err #DevSkim: ignore DS104456. Internal build tool called from our build scripts.`
`155`	`155`	`$completed = $true`
`156`	`156`	`}`
`157`	`157`	`finally {`
`@@ -906,7 +906,7 @@ Function Install-PrivateBuildTools() {`
`906`	`906`	`$commit = $env:PRIVATE_BUILD_TOOLS_COMMIT`
`907`	`907`
`908`	`908`	`if (-Not $commit) {`
`909`		`- $commit = '4b7460b2e08249e4c65307e5383dfba7fe4da8b7'`
	`909`	`+ $commit = '4b7460b2e08249e4c65307e5383dfba7fe4da8b7' #DevSkim: ignore DS173237. Not a token/secret. It is a git commit hash.`
`910`	`910`	`}`
`911`	`911`
`912`	`912`	`if (-Not $repository) {`
Original file line number	Diff line number	Diff line change
`@@ -12,9 +12,6 @@ param (`
`12`	`12`	`[string]$FxCopOutputDirectory`
`13`	`13`	`)`
`14`	`14`
`15`		`-# Enable TLS 1.2 since GitHub requires it.`
`16`		`-[Net.ServicePointManager]::SecurityProtocol = [Net.ServicePointManager]::SecurityProtocol -bor [Net.SecurityProtocolType]::Tls12`
`17`		`-`
`18`	`15`	`# To avoid repository dependencies, this script relies on the following assumptions:`
`19`	`16`	`# - parent directory contains a single *.sln`
`20`	`17`	`# - parent directory contains a build.ps1`