[A11y] Removed incorrect role attribute from breadcrumb headings (#9311)

advay26 · web-flow · commit f47285032599 · 2022-11-14T17:45:40.000-08:00
diff --git a/src/NuGetGallery/App_Code/ViewHelpers.cshtml b/src/NuGetGallery/App_Code/ViewHelpers.cshtml
@@ -588,10 +588,10 @@ var hlp = new AccordionHelper(name, formModelStatePrefix, expanded, page);
 
 @helper Breadcrumb(bool showDivider, params Func<MvcHtmlString, HelperResult>[] segments)
 {
-    <h1 role="list" class="ms-font-xl breadcrumb-title">
+    <h1 class="ms-font-xl breadcrumb-title">
         @for (int i = 0; i < segments.Length; i++)
         {
-            <span role="listitem" class="ms-noWrap">@segments[i](MvcHtmlString.Empty)</span>
+            <span class="ms-noWrap">@segments[i](MvcHtmlString.Empty)</span>
 
             if (i < segments.Length - 1)
             {

Original file line number	Diff line number	Diff line change
`@@ -588,10 +588,10 @@ var hlp = new AccordionHelper(name, formModelStatePrefix, expanded, page);`
`588`	`588`
`589`	`589`	`@helper Breadcrumb(bool showDivider, params Func<MvcHtmlString, HelperResult>[] segments)`
`590`	`590`	`{`
`591`		`- <h1 role="list" class="ms-font-xl breadcrumb-title">`
	`591`	`+ <h1 class="ms-font-xl breadcrumb-title">`
`592`	`592`	`@for (int i = 0; i < segments.Length; i++)`
`593`	`593`	`{`
`594`		`- <span role="listitem" class="ms-noWrap">@segments[i](MvcHtmlString.Empty)</span>`
	`594`	`+ <span class="ms-noWrap">@segments[i](MvcHtmlString.Empty)</span>`
`595`	`595`
`596`	`596`	`if (i < segments.Length - 1)`
`597`	`597`	`{`