Removed unused localIP member of CloudAuditingService. (#8306)

Author: agr

src/NuGetGallery.Core/Auditing/CloudAuditingService.cs

@@ -22,19 +22,15 @@ public class CloudAuditingService : AuditingService, ICloudStorageStatusDependen
         public static readonly string DefaultContainerName = "auditing";
 
         private CloudBlobContainer _auditContainer;
-        private string _instanceId;
-        private string _localIP;
         private Func<Task<AuditActor>> _getOnBehalfOf;
 
-        public CloudAuditingService(string instanceId, string localIP, string storageConnectionString, bool readAccessGeoRedundant, Func<Task<AuditActor>> getOnBehalfOf)
-            : this(instanceId, localIP, GetContainer(storageConnectionString, readAccessGeoRedundant), getOnBehalfOf)
+        public CloudAuditingService(string storageConnectionString, bool readAccessGeoRedundant, Func<Task<AuditActor>> getOnBehalfOf)
+            : this(GetContainer(storageConnectionString, readAccessGeoRedundant), getOnBehalfOf)
         {
         }
 
-        public CloudAuditingService(string instanceId, string localIP, CloudBlobContainer auditContainer, Func<Task<AuditActor>> getOnBehalfOf)
+        public CloudAuditingService(CloudBlobContainer auditContainer, Func<Task<AuditActor>> getOnBehalfOf)
         {
-            _instanceId = instanceId;
-            _localIP = localIP;
             _auditContainer = auditContainer;
             _getOnBehalfOf = getOnBehalfOf;
         }

src/NuGetGallery/App_Start/DefaultDependenciesModule.cs

@@ -1404,11 +1404,7 @@ private static void ConfigureForAzureStorage(ContainerBuilder builder, IGalleryC
 
         private static IAuditingService GetAuditingServiceForAzureStorage(ContainerBuilder builder, IGalleryConfigurationService configuration)
         {
-            string instanceId = HostMachine.Name;
-
-            var localIp = AuditActor.GetLocalIpAddressAsync().Result;
-
-            var service = new CloudAuditingService(instanceId, localIp, configuration.Current.AzureStorage_Auditing_ConnectionString, configuration.Current.AzureStorageReadAccessGeoRedundant, AuditActor.GetAspNetOnBehalfOfAsync);
+            var service = new CloudAuditingService(configuration.Current.AzureStorage_Auditing_ConnectionString, configuration.Current.AzureStorageReadAccessGeoRedundant, AuditActor.GetAspNetOnBehalfOfAsync);
 
             builder.RegisterInstance(service)
                 .As<ICloudStorageStatusDependency>()

tests/NuGetGallery.Core.Facts/Auditing/CloudAuditingServiceTests.cs

@@ -18,7 +18,7 @@ public void CloudAuditServiceObfuscateAuditRecord()
         {
             // Arrange
             CloudBlobContainer nullBlobContainer = null;
-            var service = new CloudAuditingService("id", "1.1.1.1", nullBlobContainer, AuditActor.GetCurrentMachineActorAsync);
+            var service = new CloudAuditingService(nullBlobContainer, AuditActor.GetCurrentMachineActorAsync);
 
             AuditActor onBehalfOf = new AuditActor("machineName", "3.3.3.3", "userName1", "NoAuthentication", "someKey", DateTime.Now, null);
             AuditActor auditActor = new AuditActor("machineName", "2.2.2.2", "userName1", "NoAuthentication", "someKey", DateTime.Now, onBehalfOf);
@@ -57,7 +57,7 @@ public void OnlyPackageAuditRecordsWillBeSaved(AuditRecord record, bool expected
         {
             // Arrange
             CloudBlobContainer nullBlobContainer = null;
-            var service = new CloudAuditingService("id", "1.1.1.1", nullBlobContainer, AuditActor.GetCurrentMachineActorAsync);
+            var service = new CloudAuditingService(nullBlobContainer, AuditActor.GetCurrentMachineActorAsync);
 
             // Act + Assert
             Assert.Equal<bool>(expectedResult, service.RecordWillBePersisted(record));