Disable public blob access on search containers (#10136)

Author: joelverhagen

src/NuGet.Services.AzureSearch/BlobContainerBuilder.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
@@ -59,7 +59,7 @@ public async Task CreateAsync(bool retryOnConflict)
             {
                 try
                 {
-                    await Container.CreateAsync(enablePublicAccess: true);
+                    await Container.CreateAsync(enablePublicAccess: false);
                     containerCreated = true;
                 }
                 catch (CloudBlobConflictException) when (retryOnConflict)
@@ -108,4 +108,4 @@ public async Task<bool> DeleteIfExistsAsync()
             return containerDeleted;
         }
     }
-}
+}

tests/NuGet.Services.AzureSearch.Tests/IndexBuilderFacts.cs

@@ -34,7 +34,7 @@ public async Task CreatesIndex(bool retryOnConflict)
                 await _target.CreateAsync(retryOnConflict);
 
                 VerifyGetContainer();
-                _cloudBlobContainer.Verify(x => x.CreateAsync(true), Times.Once);
+                _cloudBlobContainer.Verify(x => x.CreateAsync(false), Times.Once);
                 _cloudBlobContainer.Verify(x => x.CreateIfNotExistAsync(It.IsAny<bool>()), Times.Never);
                 _cloudBlobContainer.Verify(x => x.DeleteIfExistsAsync(), Times.Never);
             }
@@ -46,7 +46,7 @@ public async Task CanRetryOnConflict()
 
                 await _target.CreateAsync(retryOnConflict: true);
 
-                _cloudBlobContainer.Verify(x => x.CreateAsync(true), Times.Exactly(2));
+                _cloudBlobContainer.Verify(x => x.CreateAsync(false), Times.Exactly(2));
             }
 
             [Fact]
@@ -72,7 +72,7 @@ public async Task CreatesIndexIfNotExists()
                 await _target.CreateIfNotExistsAsync();
 
                 VerifyGetContainer();
-                _cloudBlobContainer.Verify(x => x.CreateAsync(true), Times.Once);
+                _cloudBlobContainer.Verify(x => x.CreateAsync(false), Times.Once);
                 _cloudBlobContainer.Verify(x => x.CreateIfNotExistAsync(It.IsAny<bool>()), Times.Never);
                 _cloudBlobContainer.Verify(x => x.DeleteIfExistsAsync(), Times.Never);
             }