Manage disposal of httpclient directly - autofac disposing early (#9195)

drewgillies · web-flow · commit ee1bd6b6650c · 2022-08-17T14:43:17.000+10:00
diff --git a/src/GitHubVulnerabilities2Db/Job.cs b/src/GitHubVulnerabilities2Db/Job.cs
@@ -134,7 +134,8 @@ protected void ConfigureQueryServices(ContainerBuilder containerBuilder)
         {
             containerBuilder
                 .RegisterInstance(_client)
-                .As<HttpClient>();
+                .As<HttpClient>()
+                .ExternallyOwned(); // We don't want autofac disposing this--see https://github.com/NuGet/NuGetGallery/issues/9194
 
             containerBuilder
                 .RegisterType<QueryService>()

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,8 @@ protected void ConfigureQueryServices(ContainerBuilder containerBuilder)`
`134`	`134`	`{`
`135`	`135`	`containerBuilder`
`136`	`136`	`.RegisterInstance(_client)`
`137`		`- .As<HttpClient>();`
	`137`	`+ .As<HttpClient>()`
	`138`	`+ .ExternallyOwned(); // We don't want autofac disposing this--see https://github.com/NuGet/NuGetGallery/issues/9194`
`138`	`139`
`139`	`140`	`containerBuilder`
`140`	`141`	`.RegisterType<QueryService>()`