Remove unused constants (found when investigating legacy README container) (#9062)

Author: joelverhagen

src/NuGetGallery/GalleryConstants.cs

@@ -10,7 +10,6 @@ public static class GalleryConstants
     {
         public const string AlphabeticSortOrder = "package-title";
         public const int DefaultPackageListPageSize = 20;
-        public const string DefaultPackageListSortOrder = "package-download-count";
         public const int PasswordResetTokenExpirationHours = 1;
 
         public const int ColumnsAuthenticationSm = 6;
@@ -19,39 +18,22 @@ public static class GalleryConstants
         public const int ColumnsWideAuthenticationMd = 6;
         public const int ColumnsFormMd = 12;
 
-        public const int VisibleVersions = 5;
-
         public const int GravatarElementSize = 32;
         public const int GravatarImageSize = GravatarElementSize * 2;
         public const int GravatarImageSizeLarge = 332;
         public const int GravatarCacheDurationSeconds = 300;
 
-        public const int MaxEmailSubjectLength = 255;
         public const int MaxFileLengthBytes = 1024 * 1024; // 1MB for License, Icon, readme file
         internal static readonly NuGetVersion MaxSupportedMinClientVersion = new NuGetVersion("5.9.0.0");
-        public const string PackageFileDownloadUriTemplate = "packages/{0}/{1}/download";
-
-        public const string ReadMeFileSavePathTemplateActive = "active/{0}/{1}{2}";
-        public const string ReadMeFileSavePathTemplatePending = "pending/{0}/{1}{2}";
 
-        public const string PopularitySortOrder = "package-download-count";
         public const string RecentSortOrder = "package-created";
-        public const string RelevanceSortOrder = "relevance";
-
-        public const string PBKDF2HashAlgorithmId = "PBKDF2";
 
         public const string UploadFileNameTemplate = "{0}{1}";
-        public const string NuGetCommandLinePackageId = "NuGet.CommandLine";
 
         public static readonly string ReturnUrlViewDataKey = "ReturnUrl";
         public static readonly string ReturnUrlMessageViewDataKey = "ReturnUrlMessage";
         public const string AskUserToEnable2FA = "AskUserToEnable2FA";
 
-        public const string UrlValidationRegEx = @"(https?):\/\/[^ ""]+$";
-        public const string UrlValidationErrorMessage = "This doesn't appear to be a valid HTTP/HTTPS URL";
-
-        public const string PackageBaseAddress = "PackageBaseAddress/3.0.0";
-
         // Note: regexes must be tested to work in JavaScript
         // We do NOT follow strictly the RFCs at this time, and we choose not to support many obscure email address variants.
         // Specifically the following are not supported by-design:
@@ -85,13 +67,10 @@ public static class GalleryConstants
         /// </summary>
         internal const string CustomQueryHeaderName = "X-NuGet-CustomQuery";
 
-        public static readonly string ReturnUrlParameterName = "ReturnUrl";
-
         public const string LicenseDeprecationUrl = "https://aka.ms/deprecateLicenseUrl";
 
         public static class ContentNames
         {
-            public static readonly string ReadOnly = "ReadOnly";
             public static readonly string TermsOfUse = "Terms-Of-Use";
             public static readonly string PrivacyPolicy = "Privacy-Policy";
             public static readonly string Team = "Team";
@@ -102,7 +81,6 @@ public static class StatisticsDimensions
             public const string Version = "Version";
             public const string ClientName = "ClientName";
             public const string ClientVersion = "ClientVersion";
-            public const string Operation = "Operation";
         }
 
         public static class FAQLinks