Skip to content

Commit e8c507b

Browse files
authored
Move the error message container outside of the Upload section (#9338)
Fix #9336
1 parent db1bdb2 commit e8c507b

2 files changed

Lines changed: 8 additions & 7 deletions

File tree

src/NuGetGallery/Services/UploadPackageMissingReadme.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
namespace NuGetGallery
22
{
33
/// <summary>
4-
/// Represents a package ID reservation conflict
4+
/// Represents package missing an embedded README.
55
/// </summary>
66
public class UploadPackageMissingReadme : IValidationMessage
77
{

src/NuGetGallery/Views/Packages/UploadPackage.cshtml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
@if (Model.IsUserLocked)
2121
{
2222
@ViewHelpers.AlertDanger(
23-
@<text>
24-
@ServicesStrings.UserAccountIsLocked
25-
</text>)
23+
@<text>
24+
@ServicesStrings.UserAccountIsLocked
25+
</text>)
2626
}
2727
else
2828
{
@@ -33,6 +33,10 @@
3333
<a href="https://docs.microsoft.com/nuget/create-packages/package-authoring-best-practices" alt="Best Practices" aria-label="Read here about publishing packages">Best Practices</a> page.
3434
</p>
3535
</div>
36+
37+
<div id="validation-failure-container" class="hidden">
38+
</div>
39+
3640
<div id="upload-package-container">
3741
<h2>
3842
<a href="#" role="button" data-toggle="collapse" data-target="#upload-package-form"
@@ -61,9 +65,6 @@
6165
<div id="upload-progress-bar-container" class="progress hidden">
6266
<div id="upload-progress-bar" class="progress-bar active" role="progressbar" aria-valuemin="0" aria-valuemax="100"></div>
6367
</div>
64-
65-
<div id="validation-failure-container" class="hidden">
66-
</div>
6768
</div>
6869
</div>
6970

0 commit comments

Comments
 (0)