Skip to content

Commit e8a3972

Browse files
authored
Merge pull request #9459 from NuGet/ryuyu-fix-orgdropdownlabels
[A11y][Organizations]Ensures select element has an accessible name
2 parents e088121 + 06580fa commit e8a3972

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/NuGetGallery/Views/Organizations/_OrganizationAccountManageMembers.cshtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
<input id="new-member-textbox" class="form-control" placeholder="Add existing NuGet.org user" data-bind="textInput: NewMemberUsername, submit: AddMember" aria-label="Enter username to add member"/>
4141
</div>
4242
<div class="form-group col-sm-3">
43-
<select class="form-control" data-bind="value: AddMemberRole, options: RoleNames" aria-labelledby="RoleNames"></select>
43+
<select class="form-control" data-bind="value: AddMemberRole, options: RoleNames" aria-label="Role Filter"></select>
4444
</div>
4545
<div class="col-sm-1">
4646
<button class="btn btn-primary" type="submit" title="Add new member" aria-label="Add new member" data-bind="click: AddMember">Add</button>
@@ -72,8 +72,8 @@
7272
<div>
7373
@if (Model.CanManageMemberships)
7474
{
75-
<select class="form-control" aria-labelledby="OrganizationViewModel.RoleNames"
76-
data-bind="value: SelectedRole, options: OrganizationViewModel.RoleNames, event: { change: ToggleIsAdmin }">
75+
<select class="form-control"
76+
data-bind="value: SelectedRole, options: OrganizationViewModel.RoleNames, event: { change: ToggleIsAdmin }, attr: { 'aria-label': 'Role for ' + Username }">
7777
</select>
7878
}
7979
else

0 commit comments

Comments
 (0)