Limit release notes to 35000 characters (#6720)

Address NuGet/Engineering#1953

Author: joelverhagen

src/NuGetGallery/Helpers/PackageHelper.cs

@@ -109,6 +109,10 @@ public static void ValidateNuGetPackageMetadata(PackageMetadata packageMetadata)
             {
                 throw new EntityException(Strings.NuGetPackagePropertyTooLong, "Summary", "4000");
             }
+            if (packageMetadata.ReleaseNotes != null && packageMetadata.ReleaseNotes.Length > 35000)
+            {
+                throw new EntityException(Strings.NuGetPackagePropertyTooLong, "ReleaseNotes", "35000");
+            }
             if (packageMetadata.Tags != null && packageMetadata.Tags.Length > 4000)
             {
                 throw new EntityException(Strings.NuGetPackagePropertyTooLong, "Tags", "4000");

tests/NuGetGallery.Facts/Services/PackageServiceFacts.cs

@@ -543,6 +543,17 @@ private async Task WillThrowIfTheNuGetPackageCopyrightIsLongerThan4000()
                 Assert.Equal(String.Format(Strings.NuGetPackagePropertyTooLong, "Copyright", "4000"), ex.Message);
             }
 
+            [Fact]
+            private async Task WillThrowIfTheNuGetPackageReleaseNotesIsLongerThan35000()
+            {
+                var service = CreateService();
+                var nugetPackage = PackageServiceUtility.CreateNuGetPackage(releaseNotes: "theReleaseNotes".PadRight(35001, '_'));
+
+                var ex = await Assert.ThrowsAsync<InvalidPackageException>(async () => await service.CreatePackageAsync(nugetPackage.Object, new PackageStreamMetadata(), owner: null, currentUser: null, isVerified: false));
+
+                Assert.Equal(String.Format(Strings.NuGetPackagePropertyTooLong, "ReleaseNotes", "35000"), ex.Message);
+            }
+
             [Fact]
             private async Task WillThrowIfTheVersionIsLongerThan64Characters()
             {