Removed duplicate EntityException type. (#7001)

* Removed duplicate EntityException type.

* Fix typo in comment

* Remove unused using statements

* Field can be made readonly.

Author: xavierdecoster

src/NuGetGallery.Core/Entities/EntityException.cs

@@ -12,17 +12,17 @@ namespace NuGetGallery
     /// </summary>
     public class ElmahException : Exception
     {
-        private Exception _baseException;
+        private readonly Exception _baseException;
 
         /// <summary>
-        /// Server variables values in Elamh logs will be overwritten by these values.
+        /// Server variables values in Elmah logs will be overwritten by these values.
         /// </summary>
         public Dictionary<string, string> ServerVariables
         {
             get;
         }
 
-        public ElmahException(Exception e, Dictionary<string,string> serverVariables) : base (e.Message, e.InnerException)
+        public ElmahException(Exception e, Dictionary<string, string> serverVariables) : base(e.Message, e.InnerException)
         {
             ServerVariables = serverVariables ?? new Dictionary<string, string>();
             _baseException = e;
@@ -46,4 +46,4 @@ public override string ToString()
             return _baseException.ToString();
         }
     }
-}
+}

src/NuGetGallery.Core/Infrastructure/ElmahException.cs

@@ -118,7 +118,6 @@
     <Compile Include="Entities\IDbContextTransaction.cs" />
     <Compile Include="Entities\EntitiesConfiguration.cs" />
     <Compile Include="Entities\EntitiesContext.cs" />
-    <Compile Include="Entities\EntityException.cs" />
     <Compile Include="Entities\Interception\ObjectMaterializedInterception.cs" />
     <Compile Include="Entities\Interception\ObjectMaterializedInterceptingDbContext.cs" />
     <Compile Include="Entities\EntityRepository.cs" />

src/NuGetGallery.Core/NuGetGallery.Core.csproj

@@ -2,10 +2,6 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace NuGetGallery
 {