Skip to content

Commit e031d69

Browse files
authored
Selectively render the vulnerable element on manage packages page (#9328)
Progress on #5877
1 parent d74e331 commit e031d69

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

src/NuGetGallery/Scripts/gallery/common.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@
462462

463463
nuget.setPopovers = function () {
464464
var popoverElement = $(this);
465-
var popoverElementDom = popoverElement.get(0);
465+
var popoverElementDom = this;
466466
var originalLabel = popoverElementDom.ariaLabel;
467467
var popoverHideTimeMS = 2000;
468468
var popoverFadeTimeMS = 200;

src/NuGetGallery/Views/Users/Packages.cshtml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,11 @@
179179
{
180180
var title = "This version has at least one known vulnerability. Click on the package name for details.";
181181
<td class="package-icon-cell">
182-
<span class="package-warning-icon" aria-label="@title" data-content="@title" data-bind="visible: IsVulnerable" tabindex="0">
182+
<!-- ko if: IsVulnerable -->
183+
<span class="package-warning-icon" aria-label="@title" data-content="@title" tabindex="0">
183184
<i class="ms-Icon ms-Icon--Warning package-icon"></i>
184185
</span>
186+
<!-- /ko -->
185187
</td>
186188
}
187189
<td class="text-right align-middle package-controls">

0 commit comments

Comments
 (0)