Skip to content

Commit e003bd6

Browse files
authored
Fixed tooltip layout (#10064)
1 parent 9482371 commit e003bd6

1 file changed

Lines changed: 9 additions & 13 deletions

File tree

src/NuGetGallery/Views/Shared/ListPackages.cshtml

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -94,24 +94,20 @@
9494
<legend style="display: flex; gap: 6px;">
9595
<a href="@(Model.FrameworksFilteringInformationLink)" class="frameworkfilters-info"
9696
data-content="@NuGetGallery.Strings.FrameworkFilters_Tooltip"
97-
aria-label="@NuGetGallery.Strings.FrameworkFilters_Tooltip"
98-
id="frameworksfiltersid">
97+
aria-label="@NuGetGallery.Strings.FrameworkFilters_Tooltip">
9998
Frameworks
10099
</a>
101-
<span class="tooltip-target" href="javascript:void(0)">
102-
<span>
103-
<i class="framework-filter-info-icon ms-Icon ms-Icon--Info"></i>
104-
</span>
105-
<span class="tooltip-block" role="tooltip" aria-labelledby="frameworksfiltersid">
100+
<a class="tooltip-target" href="javascript:void(0)" role="button" aria-labelledby="frameworksfiltersid">
101+
<i class="framework-filter-info-icon ms-Icon ms-Icon--Info"></i>
102+
<span class="tooltip-block" role="tooltip" id="frameworksfiltersid">
106103
<span class="tooltip-wrapper tooltip-with-icon popover right">
107104
<span class="arrow"></span>
108105
<span class="popover-content">
109106
@NuGetGallery.Strings.FrameworkFilters_Tooltip
110-
<a href="@(Model.FrameworksFilteringInformationLink)">Click here to learn more.</a>
111107
</span>
112108
</span>
113109
</span>
114-
</span>
110+
</a>
115111
</legend>
116112
@if (Model.IsAdvancedFrameworkFilteringEnabled)
117113
{
@@ -125,19 +121,19 @@
125121
<input type="hidden" id="includeComputedFrameworks" name="includeComputedFrameworks" value="@Model.IncludeComputedFrameworks.ToString().ToLower()">
126122
</div>
127123
<div class="framework-filter-mode-option">
128-
<p id="frameworkfiltermodeid">
124+
<p>
129125
Framework Filter Mode
130-
<span class="tooltip-target" href="javascript:void(0)">
126+
<a class="tooltip-target" href="javascript:void(0)" role="button" aria-labelledby="frameworkfiltermodeid">
131127
<i class="frameworkfiltermode-info ms-Icon ms-Icon--Info"></i>
132-
<span class="tooltip-block" role="tooltip" aria-labelledby="frameworkfiltermodeid">
128+
<span class="tooltip-block" role="tooltip" id="frameworkfiltermodeid">
133129
<span class="tooltip-wrapper tooltip-with-icon popover right">
134130
<span class="arrow"></span>
135131
<span class="popover-content">
136132
Decides whether to show packages matching ALL of the selected Target Frameworks (TFMs), or ANY of them.
137133
</span>
138134
</span>
139135
</span>
140-
</span>
136+
</a>
141137
</p>
142138
<div class="toggle-switch-control">
143139
<input type="radio" id="all-selector" name="frameworkFilterMode" value="all" tabindex="0" @(Model.FrameworkFilterMode == "any" ? "" : "checked") />

0 commit comments

Comments
 (0)