Add search heuristic based on package registration age (#8943)

joelverhagen · web-flow · commit dcbcb45bc0e6 · 2022-01-13T21:59:17.000-08:00
* Add search heuristic based on package registration age
* Add feature flag
* Add BlockSearchEngineIndexing to V2 page
diff --git a/src/AccountDeleter/EmptyFeatureFlagService.cs b/src/AccountDeleter/EmptyFeatureFlagService.cs
@@ -246,6 +246,11 @@ public bool IsPreviewHijackEnabled()
             throw new NotImplementedException();
         }
 
+        public bool IsRecentPackagesNoIndexEnabled()
+        {
+            throw new NotImplementedException();
+        }
+
         public bool IsSearchSideBySideEnabled(User user)
         {
             throw new NotImplementedException();
diff --git a/src/GitHubVulnerabilities2Db/Fakes/FakeFeatureFlagService.cs b/src/GitHubVulnerabilities2Db/Fakes/FakeFeatureFlagService.cs
@@ -279,5 +279,10 @@ public bool IsComputeTargetFrameworkEnabled()
         {
             throw new NotImplementedException();
         }
+
+        public bool IsRecentPackagesNoIndexEnabled()
+        {
+            throw new NotImplementedException();
+        }
     }
 }
diff --git a/src/NuGetGallery.Services/Configuration/FeatureFlagService.cs b/src/NuGetGallery.Services/Configuration/FeatureFlagService.cs
@@ -54,6 +54,7 @@ public class FeatureFlagService : IFeatureFlagService
         private const string ShowReportAbuseSafetyChanges = GalleryPrefix + "ShowReportAbuseSafetyChanges";
         private const string DisplayTargetFrameworkFeatureName = GalleryPrefix + "DisplayTargetFramework";
         private const string ComputeTargetFrameworkFeatureName = GalleryPrefix + "ComputeTargetFramework";
+        private const string RecentPackagesNoIndexFeatureName = GalleryPrefix + "RecentPackagesNoIndex";
 
         private const string ODataV1GetAllNonHijackedFeatureName = GalleryPrefix + "ODataV1GetAllNonHijacked";
         private const string ODataV1GetAllCountNonHijackedFeatureName = GalleryPrefix + "ODataV1GetAllCountNonHijacked";
@@ -368,5 +369,10 @@ public bool IsComputeTargetFrameworkEnabled()
         {
             return _client.IsEnabled(ComputeTargetFrameworkFeatureName, defaultValue: false);
         }
+
+        public bool IsRecentPackagesNoIndexEnabled()
+        {
+            return _client.IsEnabled(RecentPackagesNoIndexFeatureName, defaultValue: false);
+        }
     }
 }
diff --git a/src/NuGetGallery.Services/Configuration/IFeatureFlagService.cs b/src/NuGetGallery.Services/Configuration/IFeatureFlagService.cs
@@ -296,5 +296,10 @@ public interface IFeatureFlagService
         /// Whether or not to compute backend operations for target framework. This flag is overridden by <see cref="IsDisplayTargetFrameworkEnabled"/> if that flag is true.
         /// </summary>
         bool IsComputeTargetFrameworkEnabled();
+
+        /// <summary>
+        /// Whether or not recent packages has no index applied to block search engine indexing.
+        /// </summary>
+        bool IsRecentPackagesNoIndexEnabled();
     }
 }
diff --git a/src/NuGetGallery/Controllers/PackagesController.cs b/src/NuGetGallery/Controllers/PackagesController.cs
@@ -942,7 +942,8 @@ public virtual async Task<ActionResult> DisplayPackage(string id, string version
             model.IsNuGetPackageExplorerLinkEnabled = _featureFlagService.IsDisplayNuGetPackageExplorerLinkEnabled();
             model.IsPackageRenamesEnabled = _featureFlagService.IsPackageRenamesEnabled(currentUser);
             model.IsPackageDependentsEnabled = _featureFlagService.IsPackageDependentsEnabled(currentUser);
-           
+            model.IsRecentPackagesNoIndexEnabled = _featureFlagService.IsRecentPackagesNoIndexEnabled();
+
             if (model.IsPackageDependentsEnabled)
             {
                 model.PackageDependents = GetPackageDependents(id);
diff --git a/src/NuGetGallery/ViewModels/DisplayPackageViewModel.cs b/src/NuGetGallery/ViewModels/DisplayPackageViewModel.cs
@@ -40,6 +40,7 @@ public class DisplayPackageViewModel : ListPackageItemViewModel
         public bool IsPackageRenamesEnabled { get; set; }
         public bool IsGitHubUsageEnabled { get; set; }
         public bool IsPackageDependentsEnabled { get; set; }
+        public bool IsRecentPackagesNoIndexEnabled { get; set; }
         public NuGetPackageGitHubInformation GitHubDependenciesInformation { get; set; }
         public bool HasEmbeddedIcon { get; set; }
         public bool HasEmbeddedReadmeFile { get; set; }
@@ -136,6 +137,14 @@ public bool CanDisplayFuGetLink()
             return IsFuGetLinksEnabled && !string.IsNullOrEmpty(FuGetUrl) && Available;
         }
 
+        public bool BlockSearchEngineIndexing
+        {
+            get
+            {
+                return !Listed || !Available || (IsRecentPackagesNoIndexEnabled && TotalDaysSinceCreated < 7);
+            }
+        }
+
         public enum RepositoryKind
         {
             Unknown,
diff --git a/src/NuGetGallery/Views/Packages/DisplayPackage.cshtml b/src/NuGetGallery/Views/Packages/DisplayPackage.cshtml
@@ -5,7 +5,7 @@
 @{
     ViewBag.Title = Model.Id + " " + Model.Version;
     ViewBag.Tab = "Packages";
-    ViewBag.BlockSearchEngineIndexing = !Model.Listed || !Model.Available;
+    ViewBag.BlockSearchEngineIndexing = Model.BlockSearchEngineIndexing;
 
     var absolutePackageUrl = Url.Absolute(Url.Package(Model.Id));
 
diff --git a/src/NuGetGallery/Views/Packages/DisplayPackageV2.cshtml b/src/NuGetGallery/Views/Packages/DisplayPackageV2.cshtml
@@ -5,7 +5,7 @@
 @{
     ViewBag.Title = Model.Id + " " + Model.Version;
     ViewBag.Tab = "Packages";
-    ViewBag.BlockSearchEngineIndexing = !Model.Listed || !Model.Available;
+    ViewBag.BlockSearchEngineIndexing = Model.BlockSearchEngineIndexing;
 
     var absolutePackageUrl = Url.Absolute(Url.Package(Model.Id));
 
diff --git a/src/NuGetGallery/Web.config b/src/NuGetGallery/Web.config
@@ -574,14 +574,14 @@
   </system.diagnostics>
   <runtime>
     <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
-    <dependentAssembly>
+      <dependentAssembly>
         <assemblyIdentity name="Microsoft.IdentityModel.Tokens" publicKeyToken="31BF3856AD364E35" culture="neutral"/>
         <bindingRedirect oldVersion="0.0.0.0-6.7.1.0" newVersion="6.7.1.0"/>
-    </dependentAssembly>
-    <dependentAssembly>
+      </dependentAssembly>
+      <dependentAssembly>
         <assemblyIdentity name="Microsoft.IdentityModel.Logging" publicKeyToken="31BF3856AD364E35" culture="neutral"/>
         <bindingRedirect oldVersion="0.0.0.0-6.7.1.0" newVersion="6.7.1.0"/>
-    </dependentAssembly>
+      </dependentAssembly>
       <dependentAssembly>
         <assemblyIdentity name="WebGrease" publicKeyToken="31BF3856AD364E35" culture="neutral"/>
         <bindingRedirect oldVersion="0.0.0.0-1.6.5135.21930" newVersion="1.6.5135.21930"/>
diff --git a/src/VerifyMicrosoftPackage/Fakes/FakeFeatureFlagService.cs b/src/VerifyMicrosoftPackage/Fakes/FakeFeatureFlagService.cs
@@ -123,5 +123,7 @@ public bool IsDisplayPackagePageV2PreviewEnabled(User user)
         public bool IsDisplayTargetFrameworkEnabled(User user) => throw new NotImplementedException();
 
         public bool IsComputeTargetFrameworkEnabled() => throw new NotImplementedException();
+
+        public bool IsRecentPackagesNoIndexEnabled() => throw new NotImplementedException();
     }
 }
diff --git a/tests/NuGetGallery.Facts/ViewModels/DisplayPackageViewModelFacts.cs b/tests/NuGetGallery.Facts/ViewModels/DisplayPackageViewModelFacts.cs
@@ -17,6 +17,69 @@ public class DisplayPackageViewModelFacts
     {
         private Random gen = new Random();
 
+        public class TheBlockSearchEngineIndexingProperty
+        {
+            [Fact]
+            public void DoesNotBlockListedAvailableOlderPackages()
+            {
+                Assert.False(Target.BlockSearchEngineIndexing);
+            }
+
+            [Fact]
+            public void BlocksUnlisted()
+            {
+                Target.Listed = false;
+
+                Assert.True(Target.BlockSearchEngineIndexing);
+            }
+
+            [Fact]
+            public void BlocksUnavailable()
+            {
+                Target.Available = false;
+
+                Assert.True(Target.BlockSearchEngineIndexing);
+            }
+
+            [Theory]
+            [InlineData(0, true)]
+            [InlineData(1, true)]
+            [InlineData(2, true)]
+            [InlineData(3, true)]
+            [InlineData(4, true)]
+            [InlineData(5, true)]
+            [InlineData(6, true)]
+            [InlineData(7, false)]
+            [InlineData(8, false)]
+            public void BlocksNewSingleVersion(int days, bool expected)
+            {
+                Target.TotalDaysSinceCreated = days;
+
+                Assert.Equal(expected, Target.BlockSearchEngineIndexing);
+            }
+
+            [Fact]
+            public void DoesNotBlockRecentIfFeatureFlagIsOff()
+            {
+                Target.TotalDaysSinceCreated = 0;
+                Target.IsRecentPackagesNoIndexEnabled = false;
+
+                Assert.False(Target.BlockSearchEngineIndexing);
+            }
+
+            public TheBlockSearchEngineIndexingProperty()
+            {
+                Target = new DisplayPackageViewModel();
+                Target.Version = "1.0.0";
+                Target.Listed = true;
+                Target.Available = true;
+                Target.IsRecentPackagesNoIndexEnabled = true;
+                Target.TotalDaysSinceCreated = 14;
+            }
+
+            public DisplayPackageViewModel Target { get; }
+        }
+
         private DateTime RandomDay()
         {
             DateTime start = new DateTime(1995, 1, 1);

Original file line number	Diff line number	Diff line change
`@@ -246,6 +246,11 @@ public bool IsPreviewHijackEnabled()`
`246`	`246`	`throw new NotImplementedException();`
`247`	`247`	`}`
`248`	`248`
	`249`	`+ public bool IsRecentPackagesNoIndexEnabled()`
	`250`	`+ {`
	`251`	`+ throw new NotImplementedException();`
	`252`	`+ }`
	`253`	`+`
`249`	`254`	`public bool IsSearchSideBySideEnabled(User user)`
`250`	`255`	`{`
`251`	`256`	`throw new NotImplementedException();`
Original file line number	Diff line number	Diff line change
`@@ -279,5 +279,10 @@ public bool IsComputeTargetFrameworkEnabled()`
`279`	`279`	`{`
`280`	`280`	`throw new NotImplementedException();`
`281`	`281`	`}`
	`282`	`+`
	`283`	`+ public bool IsRecentPackagesNoIndexEnabled()`
	`284`	`+ {`
	`285`	`+ throw new NotImplementedException();`
	`286`	`+ }`
`282`	`287`	`}`
`283`	`288`	`}`
Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@ public class FeatureFlagService : IFeatureFlagService`
`54`	`54`	`private const string ShowReportAbuseSafetyChanges = GalleryPrefix + "ShowReportAbuseSafetyChanges";`
`55`	`55`	`private const string DisplayTargetFrameworkFeatureName = GalleryPrefix + "DisplayTargetFramework";`
`56`	`56`	`private const string ComputeTargetFrameworkFeatureName = GalleryPrefix + "ComputeTargetFramework";`
	`57`	`+ private const string RecentPackagesNoIndexFeatureName = GalleryPrefix + "RecentPackagesNoIndex";`
`57`	`58`
`58`	`59`	`private const string ODataV1GetAllNonHijackedFeatureName = GalleryPrefix + "ODataV1GetAllNonHijacked";`
`59`	`60`	`private const string ODataV1GetAllCountNonHijackedFeatureName = GalleryPrefix + "ODataV1GetAllCountNonHijacked";`
`@@ -368,5 +369,10 @@ public bool IsComputeTargetFrameworkEnabled()`
`368`	`369`	`{`
`369`	`370`	`return _client.IsEnabled(ComputeTargetFrameworkFeatureName, defaultValue: false);`
`370`	`371`	`}`
	`372`	`+`
	`373`	`+ public bool IsRecentPackagesNoIndexEnabled()`
	`374`	`+ {`
	`375`	`+ return _client.IsEnabled(RecentPackagesNoIndexFeatureName, defaultValue: false);`
	`376`	`+ }`
`371`	`377`	`}`
`372`	`378`	`}`
Original file line number	Diff line number	Diff line change
`@@ -296,5 +296,10 @@ public interface IFeatureFlagService`
`296`	`296`	`/// Whether or not to compute backend operations for target framework. This flag is overridden by <see cref="IsDisplayTargetFrameworkEnabled"/> if that flag is true.`
`297`	`297`	`/// </summary>`
`298`	`298`	`bool IsComputeTargetFrameworkEnabled();`
	`299`	`+`
	`300`	`+ /// <summary>`
	`301`	`+ /// Whether or not recent packages has no index applied to block search engine indexing.`
	`302`	`+ /// </summary>`
	`303`	`+ bool IsRecentPackagesNoIndexEnabled();`
`299`	`304`	`}`
`300`	`305`	`}`
Original file line number	Diff line number	Diff line change
`@@ -123,5 +123,7 @@ public bool IsDisplayPackagePageV2PreviewEnabled(User user)`
`123`	`123`	`public bool IsDisplayTargetFrameworkEnabled(User user) => throw new NotImplementedException();`
`124`	`124`
`125`	`125`	`public bool IsComputeTargetFrameworkEnabled() => throw new NotImplementedException();`
	`126`	`+`
	`127`	`+ public bool IsRecentPackagesNoIndexEnabled() => throw new NotImplementedException();`
`126`	`128`	`}`
`127`	`129`	`}`