Merge pull request #8226 from NuGet/learn-more-upload

Accessibility fix: Make Learn more link more descriptive

Author: lyndaidaii

src/NuGetGallery/Services/IconUrlDeprecationValidationMessage.cs

@@ -9,6 +9,6 @@ public class IconUrlDeprecationValidationMessage : IValidationMessage
 
         public bool HasRawHtmlRepresentation => true;
 
-        public string RawHtmlMessage => $"{Strings.UploadPackage_IconUrlDeprecated.Replace("<", "&lt;").Replace(">", "&gt;")} <a href=\"https://aka.ms/deprecateIconUrl\">{Strings.UploadPackage_LearnMore}</a>.";
+        public string RawHtmlMessage => $"{Strings.UploadPackage_IconUrlDeprecated.Replace("<", "&lt;").Replace(">", "&gt;")} <a href=\"https://aka.ms/deprecateIconUrl\" aria-label= \"{Strings.UploadPackage_LearnMore_IconUrlDeprecation}\">{Strings.UploadPackage_LearnMore}</a>.";
     }
 }

src/NuGetGallery/Services/InvalidLicenseUrlValidationMessage.cs

@@ -11,7 +11,7 @@ namespace NuGetGallery
     /// </summary>
     public class InvalidLicenseUrlValidationMessage : IValidationMessage
     {
-        private string DetailsLink => $"<a href=\"https://aka.ms/invalidNuGetLicenseUrl\">{Strings.UploadPackage_LearnMore}</a>.";
+        private string DetailsLink => $"<a href=\"https://aka.ms/invalidNuGetLicenseUrl\" aria-label= \"{Strings.UploadPackage_LearMore_PackagingLicense}\">{Strings.UploadPackage_LearnMore}</a>.";
         private string DetailsPlainText => "https://aka.ms/invalidNuGetLicenseUrl";
 
         private readonly string _baseMessage;

src/NuGetGallery/Services/InvalidUrlEncodingForLicenseUrlValidationMessage.cs

@@ -9,7 +9,7 @@ namespace NuGetGallery
     /// </summary>
     public class InvalidUrlEncodingForLicenseUrlValidationMessage : IValidationMessage
     {
-        private string DetailsLink => $"<a href=\"https://aka.ms/malformedNuGetLicenseUrl\">{Strings.UploadPackage_LearnMore}</a>.";
+        private string DetailsLink => $"<a href=\"https://aka.ms/malformedNuGetLicenseUrl\" aria-label= \"{Strings.UploadPackage_LearnMore_InvalidLicenseUrlEncoding}\">{Strings.UploadPackage_LearnMore}</a>.";
         private string DetailsPlainText => "https://aka.ms/malformedNuGetLicenseUrl";
 
         private string BaseMessage => Strings.UploadPackage_MalformedLicenseUrl;

src/NuGetGallery/Services/LicenseUrlDeprecationValidationMessage.cs

@@ -12,7 +12,7 @@ namespace NuGetGallery
     /// </summary>
     public class LicenseUrlDeprecationValidationMessage : IValidationMessage
     {
-        private string DeprecationLink => $"<a href=\"{GalleryConstants.LicenseDeprecationUrl}\">{Strings.UploadPackage_LearnMore}</a>.";
+        private string DeprecationLink => $"<a href=\"{GalleryConstants.LicenseDeprecationUrl}\" aria-label= \"{Strings.UploadPackage_LearnMore_LicenseUrlDreprecation}\">{Strings.UploadPackage_LearnMore}</a>.";
 
         private readonly string _baseMessage;
 

src/NuGetGallery/Strings.Designer.cs

@@ -1187,4 +1187,16 @@ The {1} Team</value>
   <data name="ReadmeNotEditableWithEmbeddedReadme" xml:space="preserve">
     <value>The readme is not editable with the package has the embedded readme</value>
   </data>
+  <data name="UploadPackage_LearMore_PackagingLicense" xml:space="preserve">
+    <value>Learn more about including a license within the package</value>
+  </data>
+  <data name="UploadPackage_LearnMore_IconUrlDeprecation" xml:space="preserve">
+    <value>Learn more about icon URL deprecation</value>
+  </data>
+  <data name="UploadPackage_LearnMore_InvalidLicenseUrlEncoding" xml:space="preserve">
+    <value>Learn more about invalid license URL encoding</value>
+  </data>
+  <data name="UploadPackage_LearnMore_LicenseUrlDreprecation" xml:space="preserve">
+    <value>Learn more about license URL deprecation</value>
+  </data>
 </root>