Skip to content

Commit db3cc47

Browse files
authored
Migrate GithubVulnerabilities2V3 to MSI (#10239)
* Migrate GitHubVulnerabilities2V3 job to MSI for storage access * Addressed feedback
1 parent d6ff752 commit db3cc47

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

  • src/GitHubVulnerabilities2v3

src/GitHubVulnerabilities2v3/Job.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
using System.Threading;
88
using System.Threading.Tasks;
99
using Autofac;
10+
using Azure.Identity;
1011
using Azure.Storage.Blobs;
1112
using GitHubVulnerabilities2v3.Configuration;
1213
using GitHubVulnerabilities2v3.Extensions;
@@ -16,6 +17,7 @@
1617
using Microsoft.Extensions.Logging;
1718
using Microsoft.Extensions.Options;
1819
using NuGet.Jobs;
20+
using NuGet.Services.Configuration;
1921
using NuGet.Services.Cursor;
2022
using NuGet.Services.GitHub.Collector;
2123
using NuGet.Services.GitHub.Configuration;
@@ -68,7 +70,7 @@ protected override void ConfigureAutofacServices(ContainerBuilder containerBuild
6870

6971
ConfigureQueryServices(containerBuilder);
7072
ConfigureIngestionServices(containerBuilder);
71-
ConfigureCollectorServices(containerBuilder);
73+
ConfigureCollectorServices(containerBuilder, configurationRoot);
7274
}
7375

7476
protected void ConfigureIngestionServices(ContainerBuilder containerBuilder)
@@ -111,14 +113,14 @@ protected void ConfigureQueryServices(ContainerBuilder containerBuilder)
111113
.As<IAdvisoryQueryService>();
112114
}
113115

114-
protected void ConfigureCollectorServices(ContainerBuilder containerBuilder)
116+
protected void ConfigureCollectorServices(ContainerBuilder containerBuilder, IConfigurationRoot configurationRoot)
115117
{
116118
containerBuilder
117119
.Register(ctx =>
118120
{
119121
var config = ctx.Resolve<GitHubVulnerabilities2v3Configuration>();
120-
var connectionString = AzureStorageFactory.PrepareConnectionString(config.StorageConnectionString);
121-
return new BlobServiceClient(connectionString);
122+
var credential = new ManagedIdentityCredential(configurationRoot[Constants.ManagedIdentityClientIdKey]);
123+
return new BlobServiceClient(new Uri(config.StorageConnectionString), credential);
122124
})
123125
.As<BlobServiceClient>();
124126

0 commit comments

Comments
 (0)