Merge pull request #8299 from NuGet/dev

[ReleasePrep][2020.10.27]NuGetGallery of dev into master

Author: lyndaidaii

README.md

@@ -9,7 +9,7 @@ This project has adopted the [Microsoft Open Source Code of Conduct](https://ope
 ## Build and Run the Gallery in (arbitrary number) easy steps
 
 1. Prerequisites:
-    1. Visual Studio 2017 - Install the following `Workloads`:
+    1. Visual Studio 2019 - Install the following `Workloads`:
         * ASP.NET and web development
         * Azure development
     2. PowerShell 4.0

src/Bootstrap/dist/css/bootstrap-theme.css

@@ -4,8 +4,6 @@
   // WebKit-specific. Other browsers will keep their default outline style.
   // (Initially tried to also force default via `outline: initial`,
   // but that seems to erroneously remove the outline in Firefox altogether.)
-  // The next line came from: https://stackoverflow.com/a/38571103
-  outline: 2px auto Highlight;
   outline: 5px auto -webkit-focus-ring-color;
   outline-offset: -2px;
 }

src/Bootstrap/dist/css/bootstrap.css

@@ -1,6 +1,7 @@
 //== Theme Variables
 @panel-footer-color:  @navbar-inverse-color;
 @default-margin-bottom: 24px;
+@package-list-line-height: 20px;
 
 //== Theme Definition
 html, body {
@@ -321,12 +322,11 @@ img.reserved-indicator-icon {
 .package-list {
   margin-top: 8px;
   margin-bottom: 8px;
-  margin-left: -5px;
   padding-left: 0;
-  line-height: 20px;
+  line-height: @package-list-line-height;
   color: @gray-light;
 
-  a {
+  a:not(.more-tags) {
     color: @gray-light;
   }
 
@@ -338,14 +338,10 @@ img.reserved-indicator-icon {
   @media (min-width: @screen-sm-min) {
     li {
       display: inline-block;
-    }
-
-    li + li {
-      margin-left: @padding-small-horizontal;
-      padding-left: @padding-small-horizontal;
-      border-left-style: solid;
-      border-width: 1px;
-      border-color: @gray-lighter;
+      line-height: @package-list-line-height;
+      max-height: (@package-list-line-height * 5 + 1px);
+      overflow-y: hidden;
+      padding-right: @padding-small-horizontal;
     }
   }
 }

src/Bootstrap/less/mixins/tab-focus.less

@@ -51,19 +51,6 @@
       color: @text-color;
       line-height: 20px;
     }
-
-
-    .package-list {
-      @media (min-width: @screen-sm-min) {
-        white-space: nowrap;
-        overflow: hidden;
-        text-overflow: ellipsis;
-
-        li {
-          display: inline;
-        }
-      }
-    }
   }
 }
 

src/Bootstrap/less/theme/base.less

@@ -171,7 +171,8 @@
   .gh-star {
     font-size: 14px;
     line-height: 12px;
-    color: @brand-warning;
+    /* Use a slightly darker orange color to increase contrast for accessibility */
+    color: darken(@brand-warning, 4.5%);
   }
 
   .used-by {

src/Bootstrap/less/theme/common-list-packages.less

@@ -26,7 +26,7 @@ public void TrackABTestEnrollmentInitialized(int schemaVersion, int previewSearc
             throw new NotImplementedException();
         }
 
-        public void TrackABTestEnrollmentUpgraded(int schemaVersion, int previewSearchBucket, int packageDepentsBucket)
+        public void TrackABTestEnrollmentUpgraded(int oldSchemaVersion, int newSchemaVersion, int previewSearchBucket, int packageDepentsBucket)
         {
             throw new NotImplementedException();
         }

src/Bootstrap/less/theme/page-display-package.less

@@ -13,43 +13,29 @@ public class CookieExpirationService : ICookieExpirationService
         private static readonly DateTime CookieExpirationTime = new DateTime(2010, 1, 1);
 
         // Google Analytics cookies
-        private static readonly IReadOnlyList<string> GoogleAnalyticsCookies = new[]
+        private static readonly string[] GoogleAnalyticsCookies = new[]
         {
             "_ga",
             "_gid",
             "_gat",
         };
 
         // Application Insights cookies
-        private static readonly IReadOnlyList<string> ApplicationInsightsCookies = new[]
+        private static readonly string[] ApplicationInsightsCookies = new[]
         {
             "ai_user",
             "ai_session",
         };
 
-        private readonly string _domain;
-        private readonly string _rootDomain;
-
-        public CookieExpirationService(string domain)
-        {
-            if (string.IsNullOrEmpty(domain))
-            {
-                throw new ArgumentException(CoreStrings.ArgumentCannotBeNullOrEmpty, nameof(domain));
-            }
-
-            _domain = domain;
-            _rootDomain = GetRootDomain(_domain);
-        }
-
         public void ExpireAnalyticsCookies(HttpContextBase httpContext)
         {
             if (httpContext == null)
             {
                 throw new ArgumentNullException(nameof(httpContext));
             }
 
-            GoogleAnalyticsCookies.ToList().ForEach(cookieName => ExpireCookieByName(httpContext, cookieName, _rootDomain));
-            ApplicationInsightsCookies.ToList().ForEach(cookieName => ExpireCookieByName(httpContext, cookieName));
+            Array.ForEach(GoogleAnalyticsCookies, cookieName => ExpireCookieByName(httpContext, cookieName));
+            Array.ForEach(ApplicationInsightsCookies, cookieName => ExpireCookieByName(httpContext, cookieName));
         }
 
         public void ExpireSocialMediaCookies(HttpContextBase httpContext) { }
@@ -84,22 +70,5 @@ public void ExpireCookieByName(HttpContextBase httpContext, string cookieName, s
                 }
             }
         }
-
-        private string GetRootDomain(string domain)
-        {
-            var index1 = domain.LastIndexOf('.');
-            if (index1 < 0)
-            {
-                return domain;
-            }
-
-            var index2 = domain.LastIndexOf('.', index1 - 1);
-            if (index2 < 0)
-            {
-                return domain;
-            }
-
-            return domain.Substring(index2 + 1);
-        }
     }
 }

src/GitHubVulnerabilities2Db/Gallery/ThrowingTelemetryService.cs

@@ -378,11 +378,13 @@ void TrackABTestEnrollmentInitialized(
         /// <summary>
         /// Track when an A/B test enrollment is upgraded
         /// </summary>
-        /// <param name="schemaVersion">The schema version.</param>
+        /// <param name="oldSchemaVersion">The old schema version.</param>
+        /// <param name="newSchemaVersion">The new schema version.</param>
         /// <param name="previewSearchBucket">The bucket for the preview search test.</param>
         /// <param name="packageDependentBucket">The bucket for the package dependents test</param>
         void TrackABTestEnrollmentUpgraded(
-            int schemaVersion,
+            int oldSchemaVersion,
+            int newSchemaVersion,
             int previewSearchBucket,
             int packageDependentBucket);