Add new symbol validation issues. (#7015)

Add the new validation issues.

Author: cristinamanum

src/NuGetGallery.Core/Extensions/ValidationIssueExtensions.cs

@@ -59,6 +59,10 @@ public static string ToMarkdownString(this ValidationIssue validationIssue, stri
                     return "The uploaded symbols package contains pdb(s) for a corresponding dll(s) not found in the nuget package.";
                 case ValidationIssueCode.SymbolErrorCode_PdbIsNotPortable:
                     return "The uploaded symbols package contains one or more pdbs that are not portable.";
+                case ValidationIssueCode.SymbolErrorCode_SnupkgDoesNotContainSymbols:
+                    return "The uploaded symbols package does not contain any symbol files.";
+                case ValidationIssueCode.SymbolErrorCode_SnupkgContainsEntriesNotSafeForExtraction:
+                    return "The uploaded symbols package contains entries that are not safe for extraction.";
                 default:
                     return "There was an unknown failure when validating your package.";
             }

src/NuGetGallery.Core/NuGetGallery.Core.csproj

@@ -219,19 +219,19 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="NuGet.Services.Entities">
-      <Version>2.43.0</Version>
+      <Version>2.44.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.FeatureFlags">
-      <Version>2.43.0</Version>
+      <Version>2.44.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Messaging.Email">
-      <Version>2.43.0</Version>
+      <Version>2.44.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Validation">
-      <Version>2.43.0</Version>
+      <Version>2.44.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Validation.Issues">
-      <Version>2.43.0</Version>
+      <Version>2.44.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.StrongName.AnglicanGeek.MarkdownMailer">
       <Version>1.2.0</Version>

src/NuGetGallery/NuGetGallery.csproj

@@ -2124,7 +2124,7 @@
       <Version>2.2.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Licenses">
-      <Version>2.43.0</Version>
+      <Version>2.44.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.StrongName.AnglicanGeek.MarkdownMailer">
       <Version>1.2.0</Version>
@@ -2348,16 +2348,16 @@
       <Version>5.0.0-preview1.5665</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.KeyVault">
-      <Version>2.43.0</Version>
+      <Version>2.44.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Logging">
-      <Version>2.43.0</Version>
+      <Version>2.44.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Owin">
-      <Version>2.43.0</Version>
+      <Version>2.44.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Sql">
-      <Version>2.43.0</Version>
+      <Version>2.44.0</Version>
     </PackageReference>
     <PackageReference Include="Owin">
       <Version>1.0.0</Version>

src/NuGetGallery/Views/Packages/_ValidationIssue.cshtml

@@ -73,6 +73,16 @@
             The uploaded symbols package contains one or more pdbs that are not portable.
         </text>
         break;
+    case ValidationIssueCode.SymbolErrorCode_SnupkgDoesNotContainSymbols:
+        <text>
+            The uploaded symbols package does not contain any symbol files.
+        </text>
+	break;
+    case ValidationIssueCode.SymbolErrorCode_SnupkgContainsEntriesNotSafeForExtraction:
+        <text>
+            The uploaded symbols package contains entries that are not safe for extraction.
+        </text>
+        break;
     default:
         <text>
             There was an unknown failure when validating your package.

tests/NuGetGallery.Facts/Infrastructure/Mail/MarkdownMessageServiceFacts.cs

@@ -2326,6 +2326,10 @@ private static string ParseValidationIssue(ValidationIssue validationIssue, stri
                         return "The uploaded symbols package contains pdb(s) for a corresponding dll(s) not found in the nuget package.";
                     case ValidationIssueCode.SymbolErrorCode_PdbIsNotPortable:
                         return "The uploaded symbols package contains one or more pdbs that are not portable.";
+                    case ValidationIssueCode.SymbolErrorCode_SnupkgDoesNotContainSymbols:
+                        return "The uploaded symbols package does not contain any symbol files.";
+                    case ValidationIssueCode.SymbolErrorCode_SnupkgContainsEntriesNotSafeForExtraction:
+                        return "The uploaded symbols package contains entries that are not safe for extraction.";
                     default:
                         return "There was an unknown failure when validating your package.";
                 }

tests/NuGetGallery.Facts/Views/Packages/ValidationIssueFacts.cs

@@ -102,6 +102,8 @@ public static IEnumerable<ValidationIssue> KnownValidationIssues
                 yield return ValidationIssue.SymbolErrorCode_ChecksumDoesNotMatch;
                 yield return ValidationIssue.SymbolErrorCode_MatchingAssemblyNotFound;
                 yield return ValidationIssue.SymbolErrorCode_PdbIsNotPortable;
+                yield return ValidationIssue.SymbolErrorCode_SnupkgDoesNotContainSymbols;
+                yield return ValidationIssue.SymbolErrorCode_SnupkgContainsEntriesNotSafeForExtraction;
                 yield return new UnauthorizedCertificateFailure("thumbprint");
             }
         }