Do not CC sender for Contact Owners emails

Scott Bommarito · Scott Bommarito · commit c6e3c4729eec · 2018-10-30T16:00:28.000-07:00
diff --git a/src/NuGetGallery.Core/NuGetGallery.Core.csproj b/src/NuGetGallery.Core/NuGetGallery.Core.csproj
@@ -203,10 +203,10 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="NuGet.Services.Entities">
-      <Version>2.30.0</Version>
+      <Version>2.31.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Messaging">
-      <Version>2.30.0</Version>
+      <Version>2.31.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.StrongName.AnglicanGeek.MarkdownMailer">
       <Version>1.2.0</Version>
@@ -242,10 +242,10 @@
       <Version>4.8.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Validation">
-      <Version>2.30.0</Version>
+      <Version>2.31.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Validation.Issues">
-      <Version>2.30.0</Version>
+      <Version>2.31.0</Version>
     </PackageReference>
     <PackageReference Include="WindowsAzure.Storage">
       <Version>7.1.2</Version>
diff --git a/src/NuGetGallery/Infrastructure/Mail/BackgroundMarkdownMessageService.cs b/src/NuGetGallery/Infrastructure/Mail/BackgroundMarkdownMessageService.cs
@@ -30,7 +30,7 @@ public BackgroundMarkdownMessageService(
         private Func<BackgroundMarkdownMessageService> _messageServiceFactory;
         private bool _sentMessage;
 
-        protected override Task SendMessageInternalAsync(MailMessage mailMessage, bool copySender = false, bool discloseSenderAddress = false)
+        protected override Task SendMessageInternalAsync(MailMessage mailMessage)
         {
             // Some MVC controller actions send more than one message. Since this method sends
             // the message async, we need a new IMessageService per email, to avoid calling
@@ -39,7 +39,7 @@ protected override Task SendMessageInternalAsync(MailMessage mailMessage, bool c
             if (_sentMessage)
             {
                 var newMessageService = _messageServiceFactory.Invoke();
-                return newMessageService.SendMessageInternalAsync(mailMessage, copySender, discloseSenderAddress);
+                return newMessageService.SendMessageInternalAsync(mailMessage);
             }
             else
             {
@@ -55,7 +55,7 @@ protected override Task SendMessageInternalAsync(MailMessage mailMessage, bool c
                     {
                         try
                         {
-                            await base.SendMessageInternalAsync(messageCopy, copySender, discloseSenderAddress);
+                            await base.SendMessageInternalAsync(messageCopy);
                         }
                         catch (Exception ex)
                         {
diff --git a/src/NuGetGallery/NuGetGallery.csproj b/src/NuGetGallery/NuGetGallery.csproj
@@ -1977,13 +1977,13 @@
       <Version>0.15.4</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Entities">
-      <Version>2.30.0</Version>
+      <Version>2.31.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Messaging">
-      <Version>2.30.0</Version>
+      <Version>2.31.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Messaging.Email">
-      <Version>2.30.0</Version>
+      <Version>2.31.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.StrongName.AnglicanGeek.MarkdownMailer">
       <Version>1.2.0</Version>
@@ -2210,16 +2210,16 @@
       <Version>4.8.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.KeyVault">
-      <Version>2.30.0</Version>
+      <Version>2.31.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Logging">
-      <Version>2.30.0</Version>
+      <Version>2.31.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Owin">
-      <Version>2.30.0</Version>
+      <Version>2.31.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Sql">
-      <Version>2.30.0</Version>
+      <Version>2.31.0</Version>
     </PackageReference>
     <PackageReference Include="Owin">
       <Version>1.0.0</Version>

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public BackgroundMarkdownMessageService(`
`30`	`30`	`private Func<BackgroundMarkdownMessageService> _messageServiceFactory;`
`31`	`31`	`private bool _sentMessage;`
`32`	`32`
`33`		`- protected override Task SendMessageInternalAsync(MailMessage mailMessage, bool copySender = false, bool discloseSenderAddress = false)`
	`33`	`+ protected override Task SendMessageInternalAsync(MailMessage mailMessage)`
`34`	`34`	`{`
`35`	`35`	`// Some MVC controller actions send more than one message. Since this method sends`
`36`	`36`	`// the message async, we need a new IMessageService per email, to avoid calling`
`@@ -39,7 +39,7 @@ protected override Task SendMessageInternalAsync(MailMessage mailMessage, bool c`
`39`	`39`	`if (_sentMessage)`
`40`	`40`	`{`
`41`	`41`	`var newMessageService = _messageServiceFactory.Invoke();`
`42`		`- return newMessageService.SendMessageInternalAsync(mailMessage, copySender, discloseSenderAddress);`
	`42`	`+ return newMessageService.SendMessageInternalAsync(mailMessage);`
`43`	`43`	`}`
`44`	`44`	`else`
`45`	`45`	`{`
`@@ -55,7 +55,7 @@ protected override Task SendMessageInternalAsync(MailMessage mailMessage, bool c`
`55`	`55`	`{`
`56`	`56`	`try`
`57`	`57`	`{`
`58`		`- await base.SendMessageInternalAsync(messageCopy, copySender, discloseSenderAddress);`
	`58`	`+ await base.SendMessageInternalAsync(messageCopy);`
`59`	`59`	`}`
`60`	`60`	`catch (Exception ex)`
`61`	`61`	`{`