Merge pull request #9864 from NuGet/dev

[ReleasePrep][2024.03.19]RI of dev into main

Author: v-ayushchat

CredScanSuppressions.json

@@ -0,0 +1,17 @@
+{
+    "tool": "Credential Scanner",
+    "suppressions": [
+        {
+            "file": "tests/NuGetGallery.Facts/Infrastructure/Authentication/ApiKeyV4Facts.cs",
+            "_justification": "Test file containing fake credentials"
+        },
+        {
+            "file": "tests/NuGetGallery.Facts/Infrastructure/Authentication/V3HasherTests.cs",
+            "_justification": "Test file containing fake credentials"
+        },
+        {
+            "file": "tests/NuGetGallery.Facts/Framework/Fakes.cs",
+            "_justification": "Test file containing fake credentials"
+        }
+    ]
+}

src/NuGetGallery.Core/Frameworks/SupportedFrameworks.cs

@@ -21,8 +21,6 @@ namespace NuGetGallery.Frameworks
     /// </remarks>
     public static class SupportedFrameworks
     {
-        public static readonly Version Version8 = new Version(8, 0, 0, 0); // https://github.com/NuGet/Engineering/issues/5112
-
         public static readonly NuGetFramework MonoAndroid = new NuGetFramework(FrameworkIdentifiers.MonoAndroid, EmptyVersion);
         public static readonly NuGetFramework MonoTouch = new NuGetFramework(FrameworkIdentifiers.MonoTouch, EmptyVersion);
         public static readonly NuGetFramework MonoMac = new NuGetFramework(FrameworkIdentifiers.MonoMac, EmptyVersion);
@@ -42,7 +40,6 @@ public static class SupportedFrameworks
         public static readonly NuGetFramework Net70MacCatalyst = new NuGetFramework(FrameworkIdentifiers.NetCoreApp, Version7, "maccatalyst", EmptyVersion);
         public static readonly NuGetFramework Net70TvOs = new NuGetFramework(FrameworkIdentifiers.NetCoreApp, Version7, "tvos", EmptyVersion);
         public static readonly NuGetFramework Net70Windows = new NuGetFramework(FrameworkIdentifiers.NetCoreApp, Version7, "windows", EmptyVersion);
-        public static readonly NuGetFramework Net80 = new NuGetFramework(FrameworkIdentifiers.NetCoreApp, Version8); // https://github.com/NuGet/Engineering/issues/5112
         public static readonly NuGetFramework Net80Android = new NuGetFramework(FrameworkIdentifiers.NetCoreApp, Version8, "android", EmptyVersion);
         public static readonly NuGetFramework Net80Browser = new NuGetFramework(FrameworkIdentifiers.NetCoreApp, Version8, "browser", EmptyVersion);
         public static readonly NuGetFramework Net80Ios = new NuGetFramework(FrameworkIdentifiers.NetCoreApp, Version8, "ios", EmptyVersion);

src/NuGetGallery/Strings.Designer.cs

@@ -1278,4 +1278,7 @@ The {1} Team</value>
   <data name="SupportedFrameworks_EmptyVersion_Template_Tooltip" xml:space="preserve">
     <value>This package is compatible with all versions of {0}.</value>
   </data>
+  <data name="FrameworkFilters_Tooltip" xml:space="preserve">
+    <value>Filters packages based on the target frameworks they are compatible with. Click here to learn more.</value>
+  </data>
 </root>

src/NuGetGallery/Strings.resx

@@ -74,8 +74,11 @@
                 @if (Model.IsAdvancedSearchFlightEnabled)
                 {
                     <div class="toggle-advanced-search-panel">
-                        Advanced search filters <button class ="advanced-search-toggle-button" aria-label="Toggles search filters on narrow screens" aria-expanded="false" aria-controls="advancedSearchToggleButton" tabindex="0" id="advancedSearchToggleButton" type="button">
-                        <i class="ms-Icon ms-Icon--ChevronDown" id="advancedSearchToggleChevron" ></i></button>
+                        Advanced search filters
+                        <button class="advanced-search-toggle-button" aria-label="Toggles search filters on narrow screens" aria-expanded="false"
+                                aria-controls="advancedSearchToggleButton" tabindex="0" id="advancedSearchToggleButton" type="button">
+                            <i class="ms-Icon ms-Icon--ChevronDown" id="advancedSearchToggleChevron"></i>
+                        </button>
                     </div>
                     <div class="row clearfix advanced-search-panel" id="advancedSearchPanel">
                         <input type="text" hidden id="frameworks" name="frameworks" value="@Model.Frameworks">
@@ -86,7 +89,9 @@
                                 <fieldset id="frameworkfilters">
                                     <legend>
                                         Frameworks
-                                        <a href="@(Model.FrameworksFilteringInformationLink)" class="frameworkfilters-info" data-content="Filters packages based on the target frameworks they are compatible with. Click here to learn more.">
+                                        <a href="@(Model.FrameworksFilteringInformationLink)" class="frameworkfilters-info"
+                                           data-content="@NuGetGallery.Strings.FrameworkFilters_Tooltip"
+                                           aria-label="@NuGetGallery.Strings.FrameworkFilters_Tooltip">
                                             <i class="framework-filter-info-icon ms-Icon ms-Icon--Info"></i>
                                         </a>
                                     </legend>