Skip to content

Commit b5783d2

Browse files
authored
Add vulnerable warnings to Manage Packages page (#8436)
Show vulnerability alerts on manage packages page
1 parent 62bd2c3 commit b5783d2

6 files changed

Lines changed: 42 additions & 4 deletions

File tree

src/Bootstrap/dist/css/bootstrap-theme.css

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Bootstrap/less/theme/page-manage-packages.less

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,19 @@
6060

6161
.inner-table {
6262
margin-bottom: 0px;
63+
64+
.package-icon-cell {
65+
cursor: default;
66+
padding-left: 0;
67+
padding-right: 0;
68+
text-align: right;
69+
70+
.package-icon {
71+
padding-left: 6px;
72+
padding-right: 6px;
73+
padding-top: 6px;
74+
}
75+
}
6376
}
6477

6578
.required-signer {

src/NuGetGallery.Services/Telemetry/TelemetryService.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
using System.Net.Http;
88
using System.Security.Principal;
99
using System.Web;
10+
using Microsoft.Owin.Security.MicrosoftAccount;
1011
using Newtonsoft.Json;
1112
using NuGet.Services.Entities;
1213
using NuGet.Services.FeatureFlags;

src/NuGetGallery/Controllers/UsersController.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
using System;
55
using System.Collections.Generic;
6+
using System.Diagnostics;
67
using System.Globalization;
78
using System.Linq;
89
using System.Net;

src/NuGetGallery/Scripts/gallery/page-manage-packages.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
this.ShowRequiredSigner = packageItem.ShowRequiredSigner;
3636
this.ShowTextBox = packageItem.ShowTextBox;
3737
this.CanEditRequiredSigner = packageItem.CanEditRequiredSigner;
38+
this.IsVulnerable = packageItem.IsVulnerable;
3839
this.CanEdit = packageItem.CanEdit;
3940
this.CanManageOwners = packageItem.CanManageOwners;
4041
this.CanDelete = packageItem.CanDelete;

src/NuGetGallery/Views/Users/Packages.cshtml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,14 @@
116116
<th class="sortable">Owners</th>
117117
@if (Model.IsCertificatesUIEnabled)
118118
{
119-
<th class="sortable">Signing Owner</th>
119+
<th class="sortable">Signing Owner</th>
120+
}
121+
<th class="sortable">Downloads</th>
122+
<th class="sortable">Latest Version</th>
123+
@if (Model.IsPackageVulnerabilitiesEnabled)
124+
{
125+
<th><span class="hidden">Package warnings</span></th>
120126
}
121-
<th class="sortable">Downloads</th>
122-
<th class="sortable">Latest Version</th>
123127
<th><span class="hidden">Icon</span></th>
124128
</tr>
125129
</thead>
@@ -171,6 +175,12 @@
171175
<td class="align-middle text-nowrap" data-bind="attr: { 'data-sortby': VersionSortOrder }">
172176
<span data-bind="text: LatestVersion"></span>
173177
</td>
178+
@if (Model.IsPackageVulnerabilitiesEnabled)
179+
{
180+
<td class="package-icon-cell">
181+
<i class="ms-Icon ms-Icon--Warning package-icon" data-bind="visible: IsVulnerable" title="This version has at least one known vulnerability. Click on the package name for details."></i>
182+
</td>
183+
}
174184
<td class="text-right align-middle package-controls">
175185
<span data-bind="visible: CanEdit || CanManageOwners || CanDelete">
176186
<a class="btn" title="Manage Package" data-bind="attr: { href: ManageUrl,
@@ -353,7 +363,8 @@
353363
p.CanEditRequiredSigner,
354364
p.ShowRequiredSigner,
355365
p.ShowTextBox,
356-
p.VersionSortOrder
366+
p.VersionSortOrder,
367+
p.IsVulnerable
357368
};
358369
}
359370

0 commit comments

Comments
 (0)