Use throw instead of throw ex to preserve call stack (#8410)

Author: joelverhagen

src/NuGetGallery/Controllers/ApiController.cs

@@ -528,7 +528,7 @@ await AuditingService.SaveAuditRecordAsync(
             {
                 ex.Log();
                 TelemetryService.TrackSymbolPackagePushFailureEvent(id, normalizedVersion);
-                throw ex;
+                throw;
             }
         }
 

src/NuGetGallery/Controllers/PackagesController.cs

@@ -2426,8 +2426,9 @@ public virtual async Task<JsonResult> VerifyPackage(VerifyPackageRequest formDat
             }
             catch (Exception ex)
             {
+                ex.Log();
                 _telemetryService.TrackPackagePushFailureEvent(id: null, version: null);
-                throw ex;
+                throw;
             }
         }
 

src/NuGetGallery/Services/PackageUploadService.cs

@@ -264,17 +264,24 @@ await _coreReadmeFileService.DeleteReadmeFileAsync(
                         package.NormalizedVersion);
                 }
 
-                return ReturnConflictOrThrow(ex);
+                if (IsConflict(ex))
+                {
+                    return PackageCommitResult.Conflict;
+                }
+                else
+                {
+                    throw;
+                }
             }
 
             return PackageCommitResult.Success;
         }
 
-        private PackageCommitResult ReturnConflictOrThrow(Exception ex)
+        private bool IsConflict(Exception ex)
         {
             if (ex is DbUpdateConcurrencyException concurrencyEx)
             {
-                return PackageCommitResult.Conflict;
+                return true;
             }
             else if (ex is DbUpdateException dbUpdateEx)
             {
@@ -287,13 +294,13 @@ private PackageCommitResult ReturnConflictOrThrow(Exception ex)
                             case 547:   // Constraint check violation
                             case 2601:  // Duplicated key row error
                             case 2627:  // Unique constraint error
-                                return PackageCommitResult.Conflict;
+                                return true;
                         }
                     }
                 }
             }
 
-            throw ex;
+            return false;
         }
     }
 }

src/NuGetGallery/Services/SymbolPackageUploadService.cs

@@ -241,7 +241,7 @@ await _symbolPackageFileService.DeletePackageFileAsync(
                             package.Version);
                     }
 
-                    throw ex;
+                    throw;
                 }
             }
             catch (FileAlreadyExistsException ex)

tests/NuGetGallery.Facts/Infrastructure/Lucene/SearchPolicyFacts.cs

@@ -479,7 +479,7 @@ public async Task<HttpResponseMessage> GetAsync(Uri uri)
                 catch (Exception ex)
                 {
                     _logger.LogError(0, ex, "[{Type}] EXCEPTION", nameof(TestSearchHttpClient));
-                    throw ex;
+                    throw;
                 }
             }
         }