Add link to search for pending validations (#7925)

Today the on-call engineer has to connect to the database to find the pending validations. This adds a link to the admin panel to fetch the currently pending validations

Addresses #7926

Author: loic-sharma

src/NuGetGallery/Areas/Admin/Controllers/ValidationController.cs

@@ -27,15 +27,35 @@ public virtual ActionResult Index()
             return View(nameof(Index), new ValidationPageViewModel());
         }
 
+        [HttpGet]
+        public virtual ActionResult Pending()
+        {
+            var validationSets = _validationAdminService.GetPending();
+            var validatedPackages = ToValidatedPackages(validationSets);
+            var validationSetIds = validatedPackages
+                .SelectMany(p => p.ValidationSets)
+                .Select(s => s.ValidationTrackingId);
+            var query = string.Join("\r\n", validationSetIds);
+
+            return View(nameof(Index), new ValidationPageViewModel(query, validatedPackages));
+        }
+
         [HttpGet]
         public virtual ActionResult Search(string q)
         {
             var packageValidationSets = _validationAdminService.Search(q ?? string.Empty);
+            var validatedPackages = ToValidatedPackages(packageValidationSets);
+
+            return View(nameof(Index), new ValidationPageViewModel(q, validatedPackages));
+        }
+
+        private List<ValidatedPackageViewModel> ToValidatedPackages(IReadOnlyList<PackageValidationSet> packageValidationSets)
+        {
             var validatedPackages = new List<ValidatedPackageViewModel>();
             AppendValidatedPackages(validatedPackages, packageValidationSets, ValidatingType.Package);
             AppendValidatedPackages(validatedPackages, packageValidationSets, ValidatingType.SymbolPackage);
 
-            return View(nameof(Index), new ValidationPageViewModel(q, validatedPackages));
+            return validatedPackages;
         }
 
         private void AppendValidatedPackages(List<ValidatedPackageViewModel> validatedPackages, IEnumerable<PackageValidationSet> validationSets, ValidatingType validatingType)

src/NuGetGallery/Areas/Admin/Services/ValidationAdminService.cs

@@ -14,6 +14,8 @@ namespace NuGetGallery.Areas.Admin.Services
 {
     public class ValidationAdminService
     {
+        private const int PendingValidationsBatchSize = 100;
+
         private readonly IEntityRepository<PackageValidationSet> _validationSets;
         private readonly IEntityRepository<PackageValidation> _validations;
         private readonly IEntityRepository<Package> _packages;
@@ -56,6 +58,29 @@ public IReadOnlyList<PackageValidationSet> Search(string query)
                 .ToList();
         }
 
+        /// <summary>
+        /// Fetch the list of validation sets whose packages are in the "validating" status.
+        /// </summary>
+        public IReadOnlyList<PackageValidationSet> GetPending()
+        {
+            var pendingValidations = new List<PackageValidationSet>();
+            var pendingPackages = _packages
+                .GetAll()
+                .Where(p => p.PackageStatusKey == PackageStatus.Validating)
+                .Select(p => p.Key)
+                .ToList();
+            var pendingSymbolPackages = _symbolPackages
+                .GetAll()
+                .Where(s => s.StatusKey == PackageStatus.Validating)
+                .Select(s => s.Key)
+                .ToList();
+
+            AddPendingValidationSets(pendingValidations, pendingPackages, ValidatingType.Package);
+            AddPendingValidationSets(pendingValidations, pendingSymbolPackages, ValidatingType.SymbolPackage);
+
+            return pendingValidations;
+        }
+
         public PackageDeletedStatus GetDeletedStatus(int key, ValidatingType validatingType)
         {
             switch (validatingType)
@@ -200,5 +225,28 @@ private void SearchByPackageId(Dictionary<long, PackageValidationSet> validation
                 validationSets[validationSet.Key] = validationSet;
             }
         }
+
+        private void AddPendingValidationSets(
+            List<PackageValidationSet> validationSets,
+            IReadOnlyList<int> packageKeys,
+            ValidatingType type)
+        {
+            foreach (var packageKeyBatch in Batch(packageKeys, PendingValidationsBatchSize))
+            {
+                validationSets.AddRange(
+                    _validationSets
+                        .GetAll()
+                        .Where(v => v.ValidatingType == type)
+                        .Where(v => packageKeys.Contains(v.PackageKey)));
+            }
+        }
+
+        private IEnumerable<IEnumerable<TElement>> Batch<TElement>(IReadOnlyList<TElement> input, int size)
+        {
+            for (var i = 0; i < input.Count; i += size)
+            {
+                yield return input.Skip(i).Take(size);
+            }
+        }
     }
 }

src/NuGetGallery/Areas/Admin/Views/Validation/Index.cshtml

@@ -17,6 +17,8 @@
 <section role="main" class="container main-container">
     <h2>Package Validations</h2>
 
+    <p>Get <a href="@Url.Action(actionName:"Pending")">pending validations</a>.</p>
+
     <form method="get" action="@Url.Action(actionName: "Search")">
         <p>
             <textarea name="q" placeholder="Search for package validations..." autocomplete="off" autofocus style="width: 100%" rows="5">@Model.Query</textarea>
@@ -28,9 +30,9 @@
 
     @if (Model.HasQuery && !Model.HasResults)
     {
-        <p>No results found.</p>
+        <p>No results found. Try <a href="@Url.Action(actionName: "Pending")">pending validations</a>.</p>
     }
-    else if(!Model.HasQuery)
+    else if (!Model.HasQuery)
     {
         <p>You can search by:</p>
         <ul>
@@ -59,7 +61,17 @@
                         break;
                 }
 
-                <b>@package.ValidatingType Key:</b> @package.PackageKey<br />
+                @switch (package.ValidatingType)
+                {
+                    case ValidatingType.SymbolPackage:
+                        <b>Symbol Package Key:</b> @package.PackageKey<br />
+                        break;
+
+                    default:
+                        <b>@package.ValidatingType Key:</b> @package.PackageKey<br />
+                        break;
+                }
+
                 @if (package.DeletedStatus == PackageDeletedStatus.NotDeleted)
                 {
                     if (package.ValidatingType == ValidatingType.Package)
@@ -98,7 +110,7 @@
 
                 @if (package.DeletedStatus != PackageDeletedStatus.Unknown)
                 {
-                    <a href="@Url.Package(package)">Package Details</a>
+                    <a href="@Url.Package(package)">Package details</a>
                 }
             </p>