Add index to UserSecurityPolicy (#7042)

* Add index to UserSecurityPolicy

* Use fluent syntax for new index

Author: xavierdecoster

src/NuGet.Services.Entities/UserSecurityPolicy.cs

@@ -31,7 +31,7 @@ public UserSecurityPolicy(string name, string subscription, string value = null)
         /// Policy key.
         /// </summary>
         public int Key { get; set; }
-        
+
         /// <summary>
         /// User key.
         /// </summary>

src/NuGetGallery.Core/Entities/EntitiesContext.cs

@@ -15,6 +15,7 @@ public class EntitiesContext
         : ObjectMaterializedInterceptingDbContext, IEntitiesContext
     {
         private const string CertificatesThumbprintIndex = "IX_Certificates_Thumbprint";
+        private const string UserSecurityPolicyUserKeyNameSubscriptionIndex = "IX_UserSecurityPolicy_UserKeyNameSubscription";
 
         static EntitiesContext()
         {
@@ -219,6 +220,50 @@ protected override void OnModelCreating(DbModelBuilder modelBuilder)
             modelBuilder.Entity<UserSecurityPolicy>()
                 .HasKey(p => p.Key);
 
+            modelBuilder.Entity<UserSecurityPolicy>()
+                .Property(e => e.UserKey)
+                .IsRequired()
+                .HasColumnAnnotation(
+                    IndexAnnotation.AnnotationName,
+                    new IndexAnnotation(new[]
+                    {
+                        new IndexAttribute(UserSecurityPolicyUserKeyNameSubscriptionIndex, order: 0)
+                        {
+                            IsUnique = true
+                        }
+                    })
+                );
+
+            modelBuilder.Entity<UserSecurityPolicy>()
+               .Property(e => e.Name)
+               .HasMaxLength(256)
+               .IsRequired()
+               .HasColumnAnnotation(
+                   IndexAnnotation.AnnotationName,
+                   new IndexAnnotation(new[]
+                   {
+                        new IndexAttribute(UserSecurityPolicyUserKeyNameSubscriptionIndex, order: 1)
+                        {
+                            IsUnique = true
+                        }
+                   })
+               );
+
+            modelBuilder.Entity<UserSecurityPolicy>()
+               .Property(e => e.Subscription)
+               .HasMaxLength(256)
+               .IsRequired()
+               .HasColumnAnnotation(
+                   IndexAnnotation.AnnotationName,
+                   new IndexAnnotation(new[]
+                   {
+                        new IndexAttribute(UserSecurityPolicyUserKeyNameSubscriptionIndex, order: 2)
+                        {
+                            IsUnique = true
+                        }
+                   })
+               );
+
             modelBuilder.Entity<EmailMessage>()
                 .HasKey(em => em.Key);
 

src/NuGetGallery/Migrations/201904081230004_AddIndexToUserSecurityPolicy.Designer.cs

@@ -0,0 +1,20 @@
+namespace NuGetGallery.Migrations
+{
+    using System;
+    using System.Data.Entity.Migrations;
+    
+    public partial class AddIndexToUserSecurityPolicy : DbMigration
+    {
+        public override void Up()
+        {
+            DropIndex("dbo.UserSecurityPolicies", new[] { "UserKey" });
+            CreateIndex("dbo.UserSecurityPolicies", new[] { "UserKey", "Name", "Subscription" }, unique: true, name: "IX_UserSecurityPolicy_UserKeyNameSubscription");
+        }
+        
+        public override void Down()
+        {
+            DropIndex("dbo.UserSecurityPolicies", "IX_UserSecurityPolicy_UserKeyNameSubscription");
+            CreateIndex("dbo.UserSecurityPolicies", "UserKey");
+        }
+    }
+}

src/NuGetGallery/Migrations/201904081230004_AddIndexToUserSecurityPolicy.cs

@@ -228,6 +228,10 @@
     <Compile Include="Migrations\201903020136235_CvesCanBeEmpty.Designer.cs">
       <DependentUpon>201903020136235_CvesCanBeEmpty.cs</DependentUpon>
     </Compile>
+    <Compile Include="Migrations\201904081230004_AddIndexToUserSecurityPolicy.cs" />
+    <Compile Include="Migrations\201904081230004_AddIndexToUserSecurityPolicy.Designer.cs">
+      <DependentUpon>201904081230004_AddIndexToUserSecurityPolicy.cs</DependentUpon>
+    </Compile>
     <Compile Include="Queries\AutocompleteCveIdQueryResults.cs" />
     <Compile Include="Queries\AutocompleteCweIdQueryResults.cs" />
     <Compile Include="Queries\AutocompleteCveIdQueryResult.cs" />
@@ -1709,6 +1713,9 @@
     <EmbeddedResource Include="Migrations\201903020136235_CvesCanBeEmpty.resx">
       <DependentUpon>201903020136235_CvesCanBeEmpty.cs</DependentUpon>
     </EmbeddedResource>
+    <EmbeddedResource Include="Migrations\201904081230004_AddIndexToUserSecurityPolicy.resx">
+      <DependentUpon>201904081230004_AddIndexToUserSecurityPolicy.cs</DependentUpon>
+    </EmbeddedResource>
     <EmbeddedResource Include="OData\QueryAllowed\Data\apiv1packages.json" />
     <EmbeddedResource Include="OData\QueryAllowed\Data\apiv1search.json" />
     <EmbeddedResource Include="OData\QueryAllowed\Data\apiv2getupdates.json" />