Merge pull request #9024 from NuGet/dg-ableistlanguage

Improve inclusiveness of language used in code

Author: drewgillies

tests/NuGetGallery.Facts/Authentication/AuthenticationServiceFacts.cs

@@ -2448,9 +2448,9 @@ public static bool VerifyPasswordHash(string hash, string algorithm, string pass
             var validator = CredentialValidator.Validators[algorithm];
             bool canAuthenticate = validator(password, new Credential { Value = hash });
 
-            bool sanity = validator("not_the_password", new Credential { Value = hash });
+            bool confidenceCheck = validator("not_the_password", new Credential { Value = hash });
 
-            return canAuthenticate && !sanity;
+            return canAuthenticate && !confidenceCheck;
         }
     }
 }

tests/NuGetGallery.FunctionalTests/Commandline/NuGetCommandLineTests.cs

@@ -155,7 +155,7 @@ public async Task LockedPackageCannotBeModified()
             Assert.Contains("locked", processResult.StandardError);
 
             // 2. Try unlisting the locked package 
-            // Perform a sanity check that the package exists
+            // Perform a spot check that the package exists
             await _clientSdkHelper.VerifyPackageExistsInV2Async(LockedPackageId, LockedPackageVersion);
             TestOutputHelper.WriteLine($"5. Trying to unlist locked package '{LockedPackageId}', version '{LockedPackageVersion}'.");
             processResult = await _commandlineHelper.DeletePackageAsync(LockedPackageId, LockedPackageVersion, UrlHelper.V2FeedPushSourceUrl);

tests/NuGetGallery.FunctionalTests/Statistics/PackageStatisticsTests.cs

@@ -18,7 +18,7 @@ public class PackageStatisticsTests
         [Description("Verify the webresponse for stats/downloads/last6weeks/ returns all 6 fields")]
         [Priority(1)]
         [Category("P1Tests")]
-        public async Task PackageFeedStatsSanityTest()
+        public async Task PackageFeedStatsConfidenceTest()
         {
             var requestUrl = UrlHelper.V2FeedRootUrl + @"stats/downloads/last6weeks/";