Merge pull request #7858 from NuGet/zhhyu-ECR-SQL

[ECR] Enable the active update of SQL certificates without restarting.

Author: zhhyu

src/NuGetGallery.Services/Configuration/ConfigurationService.cs

@@ -31,6 +31,11 @@ public class ConfigurationService : IGalleryConfigurationService
         private readonly Lazy<FeatureConfiguration> _lazyFeatureConfiguration;
         private readonly Lazy<IServiceBusConfiguration> _lazyServiceBusConfiguration;
         private readonly Lazy<IPackageDeleteConfiguration> _lazyPackageDeleteConfiguration;
+        private readonly HashSet<string> _NotInjectedSettingNames = new HashSet<string>(StringComparer.OrdinalIgnoreCase) {
+            SettingPrefix + "SqlServer",
+            SettingPrefix + "SqlServerReadOnlyReplica",
+            SettingPrefix + "SupportRequestSqlServer",
+            SettingPrefix + "ValidationSqlServer" };
 
         public ISecretInjector SecretInjector { get; set; }
 
@@ -120,7 +125,7 @@ public async Task<string> ReadSettingAsync(string settingName)
         {
             var value = ReadRawSetting(settingName);
 
-            if (!string.IsNullOrEmpty(value))
+            if (!string.IsNullOrEmpty(value) && !_NotInjectedSettingNames.Contains(settingName))
             {
                 value = await SecretInjector.InjectAsync(value);
             }

tests/NuGetGallery.Facts/App_Start/ConfigurationServiceFacts.cs

@@ -187,6 +187,33 @@ public async Task WhenSettingIsNotEmptySecretInjectorIsRan()
                 // Assert
                 Assert.Equal("somevalueparsed", result);
             }
+
+            [Theory]
+            [InlineData("Gallery.SqlServer")]
+            [InlineData("Gallery.SqlServerReadOnlyReplica")]
+            [InlineData("Gallery.SupportRequestSqlServer")]
+            [InlineData("Gallery.ValidationSqlServer")]
+            [InlineData("Gallery.sqlserver")]
+            [InlineData("Gallery.sqlserverreadonlyreplica")]
+            [InlineData("Gallery.supportrequestsqlserver")]
+            [InlineData("Gallery.validationsqlserver")]
+            public async Task GivenNotInjectedSettingNameSecretInjectorIsNotRan(string settingName)
+            {
+                // Arrange
+                var secretInjectorMock = new Mock<ISecretInjector>();
+                secretInjectorMock.Setup(x => x.InjectAsync(It.IsAny<string>()))
+                    .Returns<string>(s => Task.FromResult(s + "parsed"));
+
+                var configurationService = new TestableConfigurationService(secretInjectorMock.Object);
+                configurationService.CloudSettingStub = "somevalue";
+
+                // Act
+                string result = await configurationService.ReadSettingAsync(settingName);
+
+                // Assert
+                secretInjectorMock.Verify(x => x.InjectAsync(It.IsAny<string>()), Times.Never);
+                Assert.Equal("somevalue", result);
+            }
         }
     }
 }