Hotfix: ManageDeprecation is not enabled for logged out users (#7020)

Author: Scott Bommarito

src/NuGetGallery/Controllers/PackagesController.cs

@@ -748,7 +748,7 @@ public virtual async Task<ActionResult> DisplayPackage(string id, string version
             model.SymbolsPackageValidationIssues = _validationService.GetLatestPackageValidationIssues(model.LatestSymbolsPackage);
             model.IsCertificatesUIEnabled = _contentObjectService.CertificatesConfiguration?.IsUIEnabledForUser(currentUser) ?? false;
             model.IsAtomFeedEnabled = _featureFlagService.IsPackagesAtomFeedEnabled();
-            model.IsPackageDeprecationEnabled = _featureFlagService.IsManageDeprecationEnabled(currentUser);
+            model.IsPackageDeprecationEnabled = currentUser != null && _featureFlagService.IsManageDeprecationEnabled(currentUser);
 
             model.ReadMeHtml = await _readMeService.GetReadMeHtmlAsync(package);
 

tests/NuGetGallery.Facts/Controllers/PackagesControllerFacts.cs

@@ -1076,6 +1076,60 @@ public async Task ShowsAtomFeedIfEnabled(bool isAtomFeedEnabled)
                 deprecationService.Verify();
             }
 
+            [Theory]
+            [InlineData(false)]
+            [InlineData(true)]
+            public async Task DoesNotShowDeprecationToLoggedOutUsers(bool isDeprecationEnabled)
+            {
+                var featureFlagService = new Mock<IFeatureFlagService>();
+                var packageService = new Mock<IPackageService>();
+                var deprecationService = new Mock<IPackageDeprecationService>();
+                var controller = CreateController(
+                    GetConfigurationService(),
+                    packageService: packageService,
+                    featureFlagService: featureFlagService,
+                    deprecationService: deprecationService);
+
+                var id = "Foo";
+                var package = new Package()
+                {
+                    PackageRegistration = new PackageRegistration()
+                    {
+                        Id = id,
+                        Owners = new List<User>()
+                    },
+                    Version = "01.1.01",
+                    NormalizedVersion = "1.1.1",
+                    Title = "A test package!"
+                };
+
+                var packages = new[] { package };
+                packageService
+                    .Setup(p => p.FindPackagesById(id, PackageDeprecationFieldsToInclude.Deprecation))
+                    .Returns(packages);
+
+                packageService
+                    .Setup(p => p.FilterLatestPackage(packages, SemVerLevelKey.SemVer2, true))
+                    .Returns(package);
+
+                featureFlagService
+                    .Setup(x => x.IsManageDeprecationEnabled(It.IsAny<User>()))
+                    .Returns(isDeprecationEnabled);
+
+                deprecationService
+                    .Setup(x => x.GetDeprecationByPackage(package))
+                    .Verifiable();
+
+                // Arrange and Act
+                var result = await controller.DisplayPackage(id, version: null);
+
+                // Assert
+                var model = ResultAssert.IsView<DisplayPackageViewModel>(result);
+                Assert.False(model.IsPackageDeprecationEnabled);
+
+                deprecationService.Verify();
+            }
+
             [Theory]
             [InlineData(false)]
             [InlineData(true)]